From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f74.google.com (mail-oa1-f74.google.com [209.85.160.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CAE4223708 for ; Tue, 1 Apr 2025 18:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531937; cv=none; b=LXYRwbPZbHq97jRuaucehBaCIYKqFM5C1omGmxebYuKJ5HxDiMJm+q1IOa3K92W6Y6x12Bsz2QfVPZ1D+w1pa1xtlG9uUm2O3JUY3xppcXZ/IVNOBAemKL4z55sG20fQX80/Hie7lVn4Nquu38KJ4zkpqBSlC5sNH0NaJkxoqsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531937; c=relaxed/simple; bh=TA9MBJKZGnM8bN2F3H667zTwUG3oMX/UHc/LW06bLSE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=MRFr4+QiYikX5r9BX+opbBeKs8teRqHj3YePane1LbaU3fjuA9o+YBIJLQPYNbiXZLct5x9Ww3N7BI30eQp8s1E+6TXa2nPd6PexLd2zGxC6dhbd+Y5pAb2fKIKubPdTtDV6j1vU2eQcZ9ZZ2wucXUIcU0Hx2xz3nPOvIipQXio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D8C+JmWj; arc=none smtp.client-ip=209.85.160.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D8C+JmWj" Received: by mail-oa1-f74.google.com with SMTP id 586e51a60fabf-2c2a9abc5b2so1826869fac.1 for ; Tue, 01 Apr 2025 11:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743531935; x=1744136735; darn=lists.linux.dev; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=3QC+vjZ+uxGeny3upI0J2RrDdb+/2bXijdeBhXiDIiY=; b=D8C+JmWjophh26igcgtSU1g40p2V/TfjhpmKowjZpg5UZ8u74LaQmCQs74+uwoVnPJ XZ4zMDj4JzwNZ93H11F2TVMTxDUD5IrJKsmhmufsrFOhq+5bD7CjwyHBAulVAf67use2 A449KY9inS5Is+QuzXye8IHQ/OQ0HBofzMiqF33IXQS4QzV8BR8FfP12N9w9imCRVN2Q +rdUop9kjbcCDKET0G+ppfEZoJOgnVe6YkKCYb2ct9XHMCL3rLid8bDdx78A/7LKdXQN LwMuyrVPyrDmfAA93UH/jTBs5WTxkrbR+1g7snIGla+zT2lvHSm+HVRHi5CoSWH5ryDh fUmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743531935; x=1744136735; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3QC+vjZ+uxGeny3upI0J2RrDdb+/2bXijdeBhXiDIiY=; b=HO2r/xg34TVHMXK7p6vGBzJE2EyXy0/BBTq3GTmXO9x3hazoLxlCjD4t2PQHDJh/3l doIY6nFUYOStcE1eJgFo5uwrLzYJaJP1QRVs9HhXScJQFOyIkZFnCvoDF+LNT/NX38qL +3inpIjZNwzjVHugvbw0NaGtxkOCGfWNCKo9c6lDL0+iFwjVsd1JtDMuZCoIgSRvPrJ5 4UBdY6VPx5G/C6cfhSFsKth9TnS8UQo9BNotb7E5TSShEpACWur9WftJwRn6kcLujq5E Ux+lr+xiJsj4wOmWtxX24rfp5JR+WlOLsMLEtV1yj39KCNWgGoA/apEreTv+2qhaze0w Qi8w== X-Forwarded-Encrypted: i=1; AJvYcCVNeNgkrPRd/PyNxakfTTcFyIt5X77e97mgBezNUYS8OlCtGwQHqwm+ASm826E7mBf2/3B5@lists.linux.dev X-Gm-Message-State: AOJu0Yx7bv7yPwnF1EuBoCllv3FUMnKHygRiHa+yPF4/tk0Y66wVIvbk olMEX/JptEIBull7pxleuVXZ6W8TOXv+PLfYUE+31qOTyFi0V5wCvMhbcqgVhaOXVmFvW7rvoDv 4jZOexw== X-Google-Smtp-Source: AGHT+IExn2cUPsKHag87+ixWWT8lIhcsbUX86fXDEHLuW52QwQ4G2bpj9G8hgmkcPun76Arl4dDyofdwGznJ X-Received: from oabhl24.prod.google.com ([2002:a05:6870:1b18:b0:289:d40:52c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6870:b149:b0:2c2:5c26:2d8e with SMTP id 586e51a60fabf-2cbcf51534cmr8318955fac.16.1743531934478; Tue, 01 Apr 2025 11:25:34 -0700 (PDT) Date: Tue, 1 Apr 2025 11:23:27 -0700 In-Reply-To: <20250401182347.3422199-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250401182347.3422199-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250401182347.3422199-30-irogers@google.com> Subject: [PATCH v1 29/48] perf buildid: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Yury Norov , Rasmus Villemoes , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/builtin-buildid-cache.c | 2 +- tools/perf/builtin-buildid-list.c | 2 +- tools/perf/util/build-id.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c index b0511d16aeb6..7f7ebd625ed6 100644 --- a/tools/perf/builtin-buildid-cache.c +++ b/tools/perf/builtin-buildid-cache.c @@ -450,7 +450,7 @@ int cmd_buildid_cache(int argc, const char **argv) session = perf_session__new(&data, NULL); if (IS_ERR(session)) - return PTR_ERR(session); + return (int)PTR_ERR(session); } if (symbol__init(session ? &session->header.env : NULL) < 0) diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c index 52dfacaff8e3..ef84d1adb98f 100644 --- a/tools/perf/builtin-buildid-list.c +++ b/tools/perf/builtin-buildid-list.c @@ -109,7 +109,7 @@ static int perf_session__list_build_ids(bool force, bool with_hits) session = perf_session__new(&data, &build_id__mark_dso_hit_ops); if (IS_ERR(session)) - return PTR_ERR(session); + return (int)PTR_ERR(session); /* * We take all buildids when the file contains AUX area tracing data diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index e763e8d99a43..6a3ae17b1ccf 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -81,7 +81,7 @@ int build_id__sprintf(const struct build_id *build_id, char *bf) bid += 2; } - return (bid - bf) + 1; + return (int)(bid - bf) + 1; } int sysfs__sprintf_build_id(const char *root_dir, char *sbuild_id) -- 2.49.0.504.g3bcea36a83-goog