From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 633F4224AF2 for ; Tue, 1 Apr 2025 18:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531946; cv=none; b=JpCzpad4Bv0r2jT6FULswA3py93oNirT8ApinjNhdugPH5J+KtqjHLZBVVjWVM8d/q7eIOQbErUEVcOj9303uW+5QJsMlS3kjNrCOuti/Cn+6s9lvwhHIO++NDz71ow6NZWMCvzCvXKb1rE2PmHJXavFtsIsOi0Yn7Lr+bykh7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531946; c=relaxed/simple; bh=Qu3ENIwjPtRUy2H8z/5cBW7sG1RGzLF/ISAym7rxPVQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=E7+8DHk5j2+6YNjJt2WPJQ7kQrD9flJdG8EHTqQ77eg28r+Ijez0aVH/jsvGJplWG5UPOGylRM+KsdkzI6vZXpCylYHSgwG7ChVO96n4FP8ClHvChBG4i0iwoCPzwE/utBzG9yG2ztnhvaSvJyVkr+vsQVd5XM1qKn65HN6uvI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XpC3CFDX; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XpC3CFDX" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2242ce15cc3so109581605ad.1 for ; Tue, 01 Apr 2025 11:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743531945; x=1744136745; darn=lists.linux.dev; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=vvFsqXOQnMSY0FwcqTPMe5NcrPZKJkPdo6X7LXEIfzg=; b=XpC3CFDXe8FfEU0TUVBNAYs5nWsutzw0IutbSRMEkcDc7YzzpPXV4oCGUGJynoqPeT bvDJeqXUeRIgm35tyZ6wrI6uyz0HuKuouSOTip7K5Xklhbvvvg47NkYHGuwXz0SgEPx2 ZTGlRNR3xC6Qr2rs1S504Do8MnsJKW46p/rTPytamMh7ivHAEvZFbxNPOEkp4anwzzIa 9F1HTtlBlSFiqXsl82ncSVRoLsTEYCMtihWuQOqnVaipY0K7Yv9B6zrSKPxTumFO+3BU wRFDFJ2aopge8kK3syODLxuotV21wStwDa4m+J5FziZ/yFYs50SWcAoYdPihs67dl+yL l9wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743531945; x=1744136745; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vvFsqXOQnMSY0FwcqTPMe5NcrPZKJkPdo6X7LXEIfzg=; b=UClRe8cAtQy51ESO1T9vDN6/o1ICoXpYH5FpHqq+Tyh+TxQd/iok5e9b8OlTATkLjO wbN443UgUizkij1LvBozOmb4wM4cpE7MQDrwM8J+b0dNMGtX9QOJw7P52/b/MNq0Vm2c KM55znvh1YcYK+fMrkqzle8M2XNtj4YZe01BVztsDzJkqqhOgQMR5RsfRRuYw/yU8JBB Jm7LyanzouPELhqfAD3YrpFS7xkKzePb7K7qvlFDZwGNKNINA1+NmAgQTvznIgsLNP4/ WmFZAunljCzkDMz65kj80DIPfgZKJ1AbQTA1ZDaOoScewLhdoBNP9unR8FfPx75fwfIa Iekg== X-Forwarded-Encrypted: i=1; AJvYcCVUArSUvykR94OKYsginHaSRkXY1Z+IyjI/r7lpDzet6d6Lvq5UzSt16FNg8p3/aUkmuIp0@lists.linux.dev X-Gm-Message-State: AOJu0Yx4I6lijK4/0HqOxqR3RD7DMUpyqifYteINj0zoO0TtbxUgPTun K0O+S8fyGJmms4KcnmjU9fzUQ3chiU+sL3iovYBJ4659mZr0VMSx2n8eEbBG72OF45k1xEwHlc2 Ou8fn0w== X-Google-Smtp-Source: AGHT+IHW/4wmxkq4+EIq5aHOMrmtVB2GZ7+Z/8jfNXSu21JgnRUTXtDc8Kcd6rJ8130lmEAYOc9SAvaid5cP X-Received: from pfgs4.prod.google.com ([2002:a05:6a00:1784:b0:736:451f:b9f4]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ebc7:b0:224:160d:3f54 with SMTP id d9443c01a7336-2292f97caa0mr233931205ad.31.1743531944799; Tue, 01 Apr 2025 11:25:44 -0700 (PDT) Date: Tue, 1 Apr 2025 11:23:32 -0700 In-Reply-To: <20250401182347.3422199-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250401182347.3422199-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250401182347.3422199-35-irogers@google.com> Subject: [PATCH v1 34/48] perf bpf_counter: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Yury Norov , Rasmus Villemoes , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/util/bpf_counter.c | 6 +++--- tools/perf/util/bpf_counter_cgroup.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c index 73fcafbffc6a..3b1dbf1f5f66 100644 --- a/tools/perf/util/bpf_counter.c +++ b/tools/perf/util/bpf_counter.c @@ -177,7 +177,7 @@ static int bpf_program_profiler__load(struct evsel *evsel, struct target *target return -1; while ((tok = strtok_r(bpf_str, ",", &saveptr)) != NULL) { - prog_id = strtoul(tok, &p, 10); + prog_id = (unsigned int)strtoul(tok, &p, 10); if (prog_id == 0 || prog_id == UINT_MAX || (*p != '\0' && *p != ',')) { pr_err("Failed to parse bpf prog ids %s\n", @@ -418,7 +418,7 @@ static int bperf_reload_leader_program(struct evsel *evsel, int attr_map_fd, link = bpf_program__attach(skel->progs.on_switch); if (IS_ERR(link)) { pr_err("Failed to attach leader program\n"); - err = PTR_ERR(link); + err = (int)PTR_ERR(link); goto out; } @@ -459,7 +459,7 @@ static int bperf_attach_follower_program(struct bperf_follower_bpf *skel, else { link = bpf_program__attach(skel->progs.fexit_XXX); if (IS_ERR(link)) - err = PTR_ERR(link); + err = (int)PTR_ERR(link); } return err; diff --git a/tools/perf/util/bpf_counter_cgroup.c b/tools/perf/util/bpf_counter_cgroup.c index 6ff42619de12..35d1b950e803 100644 --- a/tools/perf/util/bpf_counter_cgroup.c +++ b/tools/perf/util/bpf_counter_cgroup.c @@ -98,7 +98,7 @@ static int bperf_load_program(struct evlist *evlist) FD(cgrp_switch, i)); if (IS_ERR(link)) { pr_err("Failed to attach cgroup program\n"); - err = PTR_ERR(link); + err = (int)PTR_ERR(link); goto out; } } -- 2.49.0.504.g3bcea36a83-goog