Re: [RFC PATCH bpf-next 1/4] cgroup: Add bpf prog revisions to struct cgroup_bpf

Re: [RFC PATCH bpf-next 1/4] cgroup: Add bpf prog revisions to struct cgroup_bpf

[kernel test robot]

Hi Yonghong,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Yonghong-Song/cgroup-Add-bpf-prog-revisions-to-struct-cgroup_bpf/20250411-091743
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20250411011528.1839359-1-yonghong.song%40linux.dev
patch subject: [RFC PATCH bpf-next 1/4] cgroup: Add bpf prog revisions to struct cgroup_bpf
config: x86_64-buildonly-randconfig-004-20250412 (https://download.01.org/0day-ci/archive/20250412/202504120859.YZRdhT38-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250412/202504120859.YZRdhT38-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504120859.YZRdhT38-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/cgroup/cgroup.c:2074:39: error: no member named 'revisions' in 'struct cgroup_bpf'
    2074 |         for (i = 0; i < ARRAY_SIZE(cgrp->bpf.revisions); i++)
         |                                    ~~~~~~~~~ ^
   include/linux/array_size.h:11:33: note: expanded from macro 'ARRAY_SIZE'
      11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
         |                                 ^~~
>> kernel/cgroup/cgroup.c:2074:39: error: no member named 'revisions' in 'struct cgroup_bpf'
    2074 |         for (i = 0; i < ARRAY_SIZE(cgrp->bpf.revisions); i++)
         |                                    ~~~~~~~~~ ^
   include/linux/array_size.h:11:48: note: expanded from macro 'ARRAY_SIZE'
      11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
         |                                                ^~~
>> kernel/cgroup/cgroup.c:2074:39: error: no member named 'revisions' in 'struct cgroup_bpf'
    2074 |         for (i = 0; i < ARRAY_SIZE(cgrp->bpf.revisions); i++)
         |                                    ~~~~~~~~~ ^
   include/linux/array_size.h:11:75: note: expanded from macro 'ARRAY_SIZE'
      11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
         |                                                                           ^~~
   include/linux/compiler.h:202:64: note: expanded from macro '__must_be_array'
     202 | #define __must_be_array(a)      __BUILD_BUG_ON_ZERO_MSG(!__is_array(a), \
         |                                                                     ^
   include/linux/compiler.h:201:39: note: expanded from macro '__is_array'
     201 | #define __is_array(a)           (!__same_type((a), &(a)[0]))
         |                                                ^
   include/linux/compiler_types.h:498:63: note: expanded from macro '__same_type'
     498 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
         |                                                               ^
   include/linux/compiler.h:197:79: note: expanded from macro '__BUILD_BUG_ON_ZERO_MSG'
     197 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Static_assert(!(e), msg);}))
         |                                                                               ^
   kernel/cgroup/cgroup.c:2075:27: error: no member named 'revisions' in 'struct cgroup_bpf'
    2075 |                 atomic64_set(&cgrp->bpf.revisions[i], 1);
         |                               ~~~~~~~~~ ^
   4 errors generated.


vim +2074 kernel/cgroup/cgroup.c

  2052	
  2053	static void init_cgroup_housekeeping(struct cgroup *cgrp)
  2054	{
  2055		struct cgroup_subsys *ss;
  2056		int i, ssid;
  2057	
  2058		INIT_LIST_HEAD(&cgrp->self.sibling);
  2059		INIT_LIST_HEAD(&cgrp->self.children);
  2060		INIT_LIST_HEAD(&cgrp->cset_links);
  2061		INIT_LIST_HEAD(&cgrp->pidlists);
  2062		mutex_init(&cgrp->pidlist_mutex);
  2063		cgrp->self.cgroup = cgrp;
  2064		cgrp->self.flags |= CSS_ONLINE;
  2065		cgrp->dom_cgrp = cgrp;
  2066		cgrp->max_descendants = INT_MAX;
  2067		cgrp->max_depth = INT_MAX;
  2068		INIT_LIST_HEAD(&cgrp->rstat_css_list);
  2069		prev_cputime_init(&cgrp->prev_cputime);
  2070	
  2071		for_each_subsys(ss, ssid)
  2072			INIT_LIST_HEAD(&cgrp->e_csets[ssid]);
  2073	
> 2074		for (i = 0; i < ARRAY_SIZE(cgrp->bpf.revisions); i++)
  2075			atomic64_set(&cgrp->bpf.revisions[i], 1);
  2076	
  2077		init_waitqueue_head(&cgrp->offline_waitq);
  2078		INIT_WORK(&cgrp->release_agent_work, cgroup1_release_agent);
  2079	}
  2080	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki