From: kernel test robot <lkp@intel.com>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [krzk:next/drivers 7/7] drivers/firmware/samsung/exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node'
Date: Tue, 22 Apr 2025 20:52:52 +0800 [thread overview]
Message-ID: <202504222051.7TqaSQ48-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git next/drivers
head: a8dc26a0ec43fd416ca781a8030807e65f71cfc5
commit: a8dc26a0ec43fd416ca781a8030807e65f71cfc5 [7/7] firmware: exynos-acpm: introduce devm_acpm_get_by_node()
config: i386-buildonly-randconfig-001-20250422 (https://download.01.org/0day-ci/archive/20250422/202504222051.7TqaSQ48-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250422/202504222051.7TqaSQ48-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504222051.7TqaSQ48-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/firmware/samsung/exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node'
>> drivers/firmware/samsung/exynos-acpm.c:672: warning: expecting prototype for acpm_get_by_phandle(). Prototype was for acpm_get_by_node() instead
vim +672 drivers/firmware/samsung/exynos-acpm.c
a88927b534ba18 Tudor Ambarus 2025-02-13 662
a88927b534ba18 Tudor Ambarus 2025-02-13 663 /**
a88927b534ba18 Tudor Ambarus 2025-02-13 664 * acpm_get_by_phandle() - get the ACPM handle using DT phandle.
a88927b534ba18 Tudor Ambarus 2025-02-13 665 * @dev: device pointer requesting ACPM handle.
a88927b534ba18 Tudor Ambarus 2025-02-13 666 * @property: property name containing phandle on ACPM node.
a88927b534ba18 Tudor Ambarus 2025-02-13 667 *
a88927b534ba18 Tudor Ambarus 2025-02-13 668 * Return: pointer to handle on success, ERR_PTR(-errno) otherwise.
a88927b534ba18 Tudor Ambarus 2025-02-13 669 */
a8dc26a0ec43fd André Draszik 2025-03-27 670 static const struct acpm_handle *acpm_get_by_node(struct device *dev,
a8dc26a0ec43fd André Draszik 2025-03-27 671 struct device_node *acpm_np)
a88927b534ba18 Tudor Ambarus 2025-02-13 @672 {
a88927b534ba18 Tudor Ambarus 2025-02-13 673 struct platform_device *pdev;
a88927b534ba18 Tudor Ambarus 2025-02-13 674 struct device_link *link;
a88927b534ba18 Tudor Ambarus 2025-02-13 675 struct acpm_info *acpm;
a88927b534ba18 Tudor Ambarus 2025-02-13 676
a88927b534ba18 Tudor Ambarus 2025-02-13 677 pdev = of_find_device_by_node(acpm_np);
53734383a73888 André Draszik 2025-03-19 678 if (!pdev)
a88927b534ba18 Tudor Ambarus 2025-02-13 679 return ERR_PTR(-EPROBE_DEFER);
a88927b534ba18 Tudor Ambarus 2025-02-13 680
a88927b534ba18 Tudor Ambarus 2025-02-13 681 acpm = platform_get_drvdata(pdev);
a88927b534ba18 Tudor Ambarus 2025-02-13 682 if (!acpm) {
a88927b534ba18 Tudor Ambarus 2025-02-13 683 platform_device_put(pdev);
a88927b534ba18 Tudor Ambarus 2025-02-13 684 return ERR_PTR(-EPROBE_DEFER);
a88927b534ba18 Tudor Ambarus 2025-02-13 685 }
a88927b534ba18 Tudor Ambarus 2025-02-13 686
a88927b534ba18 Tudor Ambarus 2025-02-13 687 if (!try_module_get(pdev->dev.driver->owner)) {
a88927b534ba18 Tudor Ambarus 2025-02-13 688 platform_device_put(pdev);
a88927b534ba18 Tudor Ambarus 2025-02-13 689 return ERR_PTR(-EPROBE_DEFER);
a88927b534ba18 Tudor Ambarus 2025-02-13 690 }
a88927b534ba18 Tudor Ambarus 2025-02-13 691
a88927b534ba18 Tudor Ambarus 2025-02-13 692 link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER);
a88927b534ba18 Tudor Ambarus 2025-02-13 693 if (!link) {
a88927b534ba18 Tudor Ambarus 2025-02-13 694 dev_err(&pdev->dev,
a88927b534ba18 Tudor Ambarus 2025-02-13 695 "Failed to create device link to consumer %s.\n",
a88927b534ba18 Tudor Ambarus 2025-02-13 696 dev_name(dev));
a88927b534ba18 Tudor Ambarus 2025-02-13 697 platform_device_put(pdev);
a88927b534ba18 Tudor Ambarus 2025-02-13 698 module_put(pdev->dev.driver->owner);
a88927b534ba18 Tudor Ambarus 2025-02-13 699 return ERR_PTR(-EINVAL);
a88927b534ba18 Tudor Ambarus 2025-02-13 700 }
a88927b534ba18 Tudor Ambarus 2025-02-13 701
a88927b534ba18 Tudor Ambarus 2025-02-13 702 return &acpm->handle;
a88927b534ba18 Tudor Ambarus 2025-02-13 703 }
a88927b534ba18 Tudor Ambarus 2025-02-13 704
:::::: The code at line 672 was first introduced by commit
:::::: a88927b534ba18019b0440cf3d7f068407b5250c firmware: add Exynos ACPM protocol driver
:::::: TO: Tudor Ambarus <tudor.ambarus@linaro.org>
:::::: CC: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-04-22 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:52 kernel test robot [this message]
2025-04-24 20:37 ` [krzk:next/drivers 7/7] drivers/firmware/samsung/exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node' Krzysztof Kozlowski
2025-04-28 10:54 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504222051.7TqaSQ48-lkp@intel.com \
--to=lkp@intel.com \
--cc=andre.draszik@linaro.org \
--cc=krzk@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox