From: Ian Rogers <irogers@google.com>
To: Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jakub Kicinski <kuba@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Leo Yan <leo.yan@arm.com>
Subject: [PATCH v2 0/5] Silence some clang -Wshorten-64-to-32 warnings
Date: Wed, 30 Apr 2025 10:15:29 -0700 [thread overview]
Message-ID: <20250430171534.132774-1-irogers@google.com> (raw)
Clang's shorten-64-to-32 can be useful to spot certain kinds of bugs
that can be more prevalent in C code due to implicit 64 to 32-bit
casting. Add some explicit casts to header files so as to avoid the
warning when these headers are used.
This patch started out as a single patch in a series for the perf tool
where a bug could have been identified were -Wshorten-64-to-32
enabled:
https://lore.kernel.org/lkml/20250401182347.3422199-3-irogers@google.com/
v2: Rebase and try to address Arnd Bergmann's comments wrt the commit
message. Arnd also mentioned doing larger refactors, changing
return types and adding helper functions. I've held off doing this
given concerns over breaking printf flags.
Ian Rogers (5):
bitfield: Silence a clang -Wshorten-64-to-32 warning
bitmap: Silence a clang -Wshorten-64-to-32 warning
bitops: Silence a clang -Wshorten-64-to-32 warning
math64: Silence a clang -Wshorten-64-to-32 warning
hash.h: Silence a clang -Wshorten-64-to-32 warning
include/asm-generic/bitops/fls64.h | 2 +-
include/linux/bitfield.h | 2 +-
include/linux/bitmap.h | 2 +-
include/linux/hash.h | 2 +-
include/linux/math64.h | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
--
2.49.0.906.g1f30a19c02-goog
next reply other threads:[~2025-04-30 17:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 17:15 Ian Rogers [this message]
2025-04-30 17:15 ` [PATCH v2 1/5] bitfield: Silence a clang -Wshorten-64-to-32 warning Ian Rogers
2025-05-03 10:33 ` David Laight
2025-05-07 8:38 ` kernel test robot
2025-04-30 17:15 ` [PATCH v2 2/5] bitmap: " Ian Rogers
2025-05-02 16:03 ` Yury Norov
2025-05-02 16:43 ` Ian Rogers
2025-05-02 16:55 ` Yury Norov
2025-05-02 17:13 ` Ian Rogers
2025-04-30 17:15 ` [PATCH v2 3/5] bitops: " Ian Rogers
2025-04-30 17:15 ` [PATCH v2 4/5] math64: " Ian Rogers
2025-05-01 20:07 ` David Laight
2025-05-01 20:15 ` Ian Rogers
2025-05-01 20:26 ` David Laight
2025-05-01 21:11 ` Ian Rogers
2025-05-02 12:17 ` David Laight
2025-04-30 17:15 ` [PATCH v2 5/5] hash.h: " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430171534.132774-1-irogers@google.com \
--to=irogers@google.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=jacob.e.keller@intel.com \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox