From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE942882BF for ; Wed, 30 Apr 2025 17:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035499; cv=none; b=oKdi0TsHRH1MztJb+3TCmASnRZE7g103aXf4R8ajic3WkAPfNRFHgK59MAh/K0AapJUYzZFKYO2X4/6ImuJFiWgJSNegNcz0U73rLQC1Mry8f19UI66oELms0BnOspBAezqpcEFB9a8JkubnVp/+OQRACD+b9RHmzr4G6AMGpOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035499; c=relaxed/simple; bh=sCPbQWpl2KULh3E4LCAV0bh/JHaMSP/NP3ql5s1b1Do=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uTdtF/G35vRCe2c0nmWlj/6Tom4V+gnc1DqhmPWb08MIRme3KRvSTGE5gukfxxchGrGmFUNCdelGhpjasp+klFLWR/CFu5QHj0o7MdwxyV5RaZJ6jN1BKTPqX5yjt+Bx2qdhWMWtReXmr6kvdskyLDm5wEVGq5+ibWDRknfn+1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=scLc0E7o; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="scLc0E7o" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-73c09e99069so191373b3a.0 for ; Wed, 30 Apr 2025 10:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746035497; x=1746640297; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=l9+mjbfIpVuolnm3GMooUNSg/0jE5LZYACjxU5MzkWs=; b=scLc0E7oSZZJzasMUGhWgl7G0U5MiuW8/u9Dp1yPFh29HYVucwiIJaDlhC650seW7t Gpd1bOTrqgqfRWxi69DqzBNi5pQyffXiCSO/izrrz0hX9LU2bMb3JbkYxyL+2En9Cn35 IcMOxERwcwIrKxlkgmu8OxehQQ8bhBOUUhdf9lFSVyr2JXnYOElEXsr2Q06blarMhc0x Xl2znzo14AHDtpgsdN4P6ntOSk36q5b590m8jPbQ15bY8DPfJrSMXz+mqqlQC6NhnT+x eh4bxpaGsSotI409FLTrF8vMZzPuNjJLnegIMwpxjF5XvHyvK+MbRgBvVK4F3yN+5Ifj Ta0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746035497; x=1746640297; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l9+mjbfIpVuolnm3GMooUNSg/0jE5LZYACjxU5MzkWs=; b=XTTtv8/RRZPqVrGf5d8Vo3X5C9/Aj8uIpz08WvHf/V/Xo7Vs9anTbh1qCV6tfxWf4V qXNZHxBxuGL+S02zuVmVPdFkgTUXY7fRRV9NhhFMCL7zNlmPwaTM5sAIqioNATRVqhN8 dKAkxlVMvHpkPuTwhuRy4qJYLJtwum4Pk/4QduVfZi+zpTOOtSh/gjCdN87yJwQLn6Qa wHaInP73dlKYVYClPYZ6uf50Se1b4TX6YuxKdMp3RWjnzCg564pHF+M6Dh5okHQR6cqd ro0x7RzfYluUNDTCc81wTaYggYX7SY4gDw0qGhzuuvbA56GyLYLWLeAN0r8mZ69+tl22 hNsg== X-Forwarded-Encrypted: i=1; AJvYcCUhELMqIFtTejXH9UoEl8vo44vJTcGTa91sZM9vJtKOAtdEtnLF9hf0+Bdr053nyrvkSG3T@lists.linux.dev X-Gm-Message-State: AOJu0Yzseuf/cIvX/TzjhH8KTxiNuVInf4t2EwRpFdpGNGHTIOMEt/7q LuZNC1sQOfHOKK2Mmeh3YIdmpnagPerwlcm7BOmlREz1kCGb8mmVCQKjBKgFj5rcqhZSO7NeESw 0E7fbqg== X-Google-Smtp-Source: AGHT+IHpf31xgCUhp/bSgmJMIP3K05vEfqw1PLaxr//TR346O2GAWFitRRWNuL9GJdbLUJ5lR6UpoSDbOexs X-Received: from pfbhc7.prod.google.com ([2002:a05:6a00:6507:b0:736:5012:3564]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:14d1:b0:736:562b:9a9c with SMTP id d2e1a72fcca58-74038a9295fmr5722381b3a.18.1746035497149; Wed, 30 Apr 2025 10:51:37 -0700 (PDT) Date: Wed, 30 Apr 2025 10:50:08 -0700 In-Reply-To: <20250430175036.184610-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430175036.184610-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250430175036.184610-21-irogers@google.com> Subject: [PATCH v2 20/47] perf dlfilter: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Yury Norov , Rasmus Villemoes , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/dlfilters/dlfilter-test-api-v0.c | 4 ++-- tools/perf/util/dlfilter.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c index 4ca2d7b2ea6c..bf2a1a7b3c71 100644 --- a/tools/perf/dlfilters/dlfilter-test-api-v0.c +++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c @@ -166,10 +166,10 @@ int start(void **data, void *ctx) CHECK(dlargc == 6); CHECK(!strcmp(dlargv[0], "first")); - verbose = strtol(dlargv[1], NULL, 0); + verbose = (int)strtol(dlargv[1], NULL, 0); d->ip = strtoull(dlargv[2], NULL, 0); d->addr = strtoull(dlargv[3], NULL, 0); - d->do_early = strtol(dlargv[4], NULL, 0); + d->do_early = (int)strtol(dlargv[4], NULL, 0); CHECK(!strcmp(dlargv[5], "last")); pr_debug("%s API\n", __func__); diff --git a/tools/perf/util/dlfilter.c b/tools/perf/util/dlfilter.c index ddacef881af2..0e513ac7feae 100644 --- a/tools/perf/util/dlfilter.c +++ b/tools/perf/util/dlfilter.c @@ -38,7 +38,7 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) else d_al->dso = dso__name(dso); d_al->is_64_bit = dso__is_64_bit(dso); - d_al->buildid_size = dso__bid(dso)->size; + d_al->buildid_size = (__u32)dso__bid(dso)->size; d_al->buildid = dso__bid(dso)->data; } else { d_al->dso = NULL; @@ -51,9 +51,9 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) d_al->sym_start = sym->start; d_al->sym_end = sym->end; if (al->addr < sym->end) - d_al->symoff = al->addr - sym->start; + d_al->symoff = (__u32)(al->addr - sym->start); else if (al->map) - d_al->symoff = al->addr - map__start(al->map) - sym->start; + d_al->symoff = (__u32)(al->addr - map__start(al->map) - sym->start); else d_al->symoff = 0; d_al->sym_binding = sym->binding; @@ -290,9 +290,9 @@ static __s32 code_read(__u64 ip, struct map *map, struct machine *machine, void u64 offset = map__map_ip(map, ip); if (ip + len >= map__end(map)) - len = map__end(map) - ip; + len = (__u32)(map__end(map) - ip); - return dso__data_read_offset(map__dso(map), machine, offset, buf, len); + return (__s32)dso__data_read_offset(map__dso(map), machine, offset, buf, len); } static __s32 dlfilter__object_code(void *ctx, __u64 ip, void *buf, __u32 len) -- 2.49.0.906.g1f30a19c02-goog