From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA8B027990D for ; Wed, 30 Apr 2025 17:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035474; cv=none; b=lHGCUZ3fhNYABzxqEBtMtF/G7irkz/LNlmm9q52gSw82mkGf51/KUydlzA596kpFX/7s8idAm16DEitoqapWPDLPBtrW3GgmHa4wdknsEWMhenZyZ44KGPuZ1/NE8treB9YveHtNTPgXqQiE6WfhfQKdw/wR3SWNiG765pAhgzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035474; c=relaxed/simple; bh=VzQZhE0elrXS34SExt1i/beojdWdOOg7H1NOF7AFJ24=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NUSNL14hcN2yeoFH+Rj/nQDc44jP9sUQwGH8aLS3dnwzH8AbO31jG9vFbR/MppLtZiPelK837hKFtbF7wOD0NNemCCic1gKBnJ8OW3djPMjCqpLY2l5dXpsP5XzxKwrKi9Y2J90898pC6/M2RRrkNQEWqJXTOxRXlCj6DqPfpWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lWlhBgQo; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lWlhBgQo" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7375e2642b4so105968b3a.2 for ; Wed, 30 Apr 2025 10:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746035472; x=1746640272; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=l37BKjYgmTS4La7ggY9yiyQcQdvs2tGcaNKDcUTY85o=; b=lWlhBgQouU9h9VIh9behmHfChFipEgl7h7CuWIZ40+yAt/UcWaRd9c+Z+FCW9hcfEW 4qlWMtScLw1jBSkrxWTnkZU5bapidTdAeCC658g3qTxb1PvyMQtdQEpk4aDY7eN7nDP2 a6XYIo2driSjMaljfzq51gyQT7btrby+BJiGmqfInyDYurtomczJVt4CxzmRHQuVxcFV RfhlMbgruOzhnFjAsRwxFUbHGOWfM2thtdpRTPHqtHzl2gSPJgDA4GJ8fMcn05dG/ABL 308hucsvkroxST7WRWie9DWBlWQn5LRv+BS/vDWCuUTn7OpjHb4P38BnTIDvyS5pEIzz LBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746035472; x=1746640272; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l37BKjYgmTS4La7ggY9yiyQcQdvs2tGcaNKDcUTY85o=; b=fTgLrnDvkVb5ocj5TtGDIw427jJn8YViSJbhFIzc/aLKM68RExQP5JwOMtgpliX1bs jO0Bp4r54bpG8UW3mugPJl7yNHNAodc3h1JiaEwaCDo3fxVyLcrgoJIfljBzJfgaQOWx U/v5/y079txGJhuNSVbx68/vhIDGVf3HXK8fQ1bPG3qtQVlsvGBiMunFnsEDg9LrtURG YkIy1a3NfxEaUzcD95pex4dzj7FZtBtL+GpMVrKqDDnJllu9TTj9kuO48j33fuTWd3ss pOp0y2ubkKts8O0e6Cilpu0GnGJPbUOXrrzAWD9a3XfBXiEKTK2Mv0D7zkrhME3VvBXP 8+xg== X-Forwarded-Encrypted: i=1; AJvYcCWD4T1HfxqPd0ABnprELZ3Qxtwy8A2iOSCWUU/3O7e2zK2Vq0KaUNmBcddIiAodr/018/1J@lists.linux.dev X-Gm-Message-State: AOJu0YwoU442a2gri2TE1oAoyCeL4XLQL/qelvX0Fk4vGaCEN2ivd+Pb yz6XCuXaedtoHCHNdged/X1pSXAUKmpjypok3qptoI/OGmR1l4EGZVilzv5dW4+SeQY+Bc1P3pX RVcUyTA== X-Google-Smtp-Source: AGHT+IEhkBU03JFJxZaZHJ3QPl/LFRcRXHgfBy5CcgazJaWzCjMkfX2AXQNHrPAAKAmwy/2QTqQCF6e/woC0 X-Received: from pfbfa19.prod.google.com ([2002:a05:6a00:2d13:b0:737:30c9:fe46]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:78e:b0:1f3:26e5:55bc with SMTP id adf61e73a8af0-20a89afb7c7mr5297458637.42.1746035471854; Wed, 30 Apr 2025 10:51:11 -0700 (PDT) Date: Wed, 30 Apr 2025 10:49:55 -0700 In-Reply-To: <20250430175036.184610-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430175036.184610-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250430175036.184610-8-irogers@google.com> Subject: [PATCH v2 07/47] tools lib: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Yury Norov , Rasmus Villemoes , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/lib/api/fs/fs.c | 4 ++-- tools/lib/bitmap.c | 2 +- tools/lib/string.c | 6 +++--- tools/lib/vsprintf.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index edec23406dbc..2c4677901de9 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -349,7 +349,7 @@ int filename__read_str(const char *filename, char **buf, size_t *sizep) { struct io io; char bf[128]; - int err; + ssize_t err; io.fd = open(filename, O_RDONLY); if (io.fd < 0) @@ -363,7 +363,7 @@ int filename__read_str(const char *filename, char **buf, size_t *sizep) } else err = 0; close(io.fd); - return err; + return (int)err; } int filename__write_int(const char *filename, int value) diff --git a/tools/lib/bitmap.c b/tools/lib/bitmap.c index 51255c69754d..7491bf174e92 100644 --- a/tools/lib/bitmap.c +++ b/tools/lib/bitmap.c @@ -32,7 +32,7 @@ size_t bitmap_scnprintf(unsigned long *bitmap, unsigned int nbits, char *buf, size_t size) { /* current bit is 'cur', most recently seen range is [rbot, rtop] */ - unsigned int cur, rbot, rtop; + size_t cur, rbot, rtop; bool first = true; size_t ret = 0; diff --git a/tools/lib/string.c b/tools/lib/string.c index 3126d2cff716..638e75b63538 100644 --- a/tools/lib/string.c +++ b/tools/lib/string.c @@ -182,7 +182,7 @@ char *strreplace(char *s, char old, char new) return s; } -static void *check_bytes8(const u8 *start, u8 value, unsigned int bytes) +static void *check_bytes8(const u8 *start, u8 value, size_t bytes) { while (bytes) { if (*start != value) @@ -206,7 +206,7 @@ void *memchr_inv(const void *start, int c, size_t bytes) { u8 value = c; u64 value64; - unsigned int words, prefix; + size_t words, prefix; if (bytes <= 16) return check_bytes8(start, value, bytes); @@ -216,7 +216,7 @@ void *memchr_inv(const void *start, int c, size_t bytes) value64 |= value64 << 16; value64 |= value64 << 32; - prefix = (unsigned long)start % 8; + prefix = (size_t)start % 8; if (prefix) { u8 *r; diff --git a/tools/lib/vsprintf.c b/tools/lib/vsprintf.c index 8780b4cdab21..62028a5eea7e 100644 --- a/tools/lib/vsprintf.c +++ b/tools/lib/vsprintf.c @@ -8,7 +8,7 @@ int vscnprintf(char *buf, size_t size, const char *fmt, va_list args) int i = vsnprintf(buf, size, fmt, args); ssize_t ssize = size; - return (i >= ssize) ? (ssize - 1) : i; + return (i >= ssize) ? (int)(ssize - 1) : i; } int scnprintf(char * buf, size_t size, const char * fmt, ...) @@ -21,7 +21,7 @@ int scnprintf(char * buf, size_t size, const char * fmt, ...) i = vsnprintf(buf, size, fmt, args); va_end(args); - return (i >= ssize) ? (ssize - 1) : i; + return (i >= ssize) ? (int)(ssize - 1) : i; } int scnprintf_pad(char * buf, size_t size, const char * fmt, ...) @@ -40,5 +40,5 @@ int scnprintf_pad(char * buf, size_t size, const char * fmt, ...) buf[i] = 0x0; } - return (i >= ssize) ? (ssize - 1) : i; + return (i >= ssize) ? (int)(ssize - 1) : i; } -- 2.49.0.906.g1f30a19c02-goog