From: kernel test robot <lkp@intel.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Palmer Dabbelt <palmer@rivosinc.com>,
Cyril Bur <cyrilbur@tenstorrent.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [palmer:for-next 10/25] include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension
Date: Fri, 9 May 2025 15:59:18 +0800 [thread overview]
Message-ID: <202505091520.cze8wv81-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
head: 1a3f6980889df3fc90ad3e4a525061d2c138adba
commit: f6bff7827a48e59cff1ef98aae72452d65174e0c [10/25] riscv: uaccess: use 'asm_goto_output' for get_user()
config: riscv-randconfig-002-20250509 (https://download.01.org/0day-ci/archive/20250509/202505091520.cze8wv81-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505091520.cze8wv81-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505091520.cze8wv81-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:1221:
In file included from include/linux/huge_mm.h:7:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
1 warning generated.
--
In file included from fs/ioctl.c:8:
In file included from include/linux/syscalls.h:83:
In file included from include/uapi/linux/aio_abi.h:31:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
>> fs/ioctl.c:69:10: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
69 | error = get_user(ur_block, p);
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/ioctl.c:346:10: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
346 | error = get_user(on, argp);
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/ioctl.c:370:10: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
370 | error = get_user(on, argp);
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/ioctl.c:424:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
424 | if (get_user(count, &argp->dest_count)) {
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/ioctl.c:723:8: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
723 | err = get_user(flags, argp);
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
6 warnings generated.
--
In file included from fs/namespace.c:11:
In file included from include/linux/syscalls.h:83:
In file included from include/uapi/linux/aio_abi.h:31:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
>> fs/namespace.c:4097:7: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
4097 | if (get_user(c, (const char __user *)data + offset))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/namespace.c:5942:8: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
5942 | ret = get_user(usize, &req->size);
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
3 warnings generated.
--
In file included from fs/read_write.c:14:
In file included from include/linux/fsnotify.h:15:
In file included from include/linux/fsnotify_backend.h:14:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
>> fs/read_write.c:1403:16: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
1403 | if (unlikely(get_user(off, offset)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
2 warnings generated.
--
In file included from fs/select.c:18:
In file included from include/linux/compat.h:17:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
>> fs/select.c:783:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
783 | unsafe_get_user(to->p, &from->p, Efault);
| ^
arch/riscv/include/asm/uaccess.h:449:2: note: expanded from macro 'unsafe_get_user'
449 | __get_user_nocheck(__gu_val, (ptr), label); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
fs/select.c:784:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
784 | unsafe_get_user(to->size, &from->size, Efault);
| ^
arch/riscv/include/asm/uaccess.h:449:2: note: expanded from macro 'unsafe_get_user'
449 | __get_user_nocheck(__gu_val, (ptr), label); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
3 warnings generated.
--
In file included from fs/namei.c:22:
>> include/linux/fs.h:3921:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
3921 | if (unlikely(get_user(c, path)))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
>> fs/namei.c:231:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
231 | if (get_user(c, pathname))
| ^
arch/riscv/include/asm/uaccess.h:263:3: note: expanded from macro 'get_user'
263 | __get_user((x), __p) : \
| ^
arch/riscv/include/asm/uaccess.h:233:2: note: expanded from macro '__get_user'
233 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \
| ^
arch/riscv/include/asm/uaccess.h:196:2: note: expanded from macro '__get_user_error'
196 | __get_user_nocheck(x, ptr, __gu_failed); \
| ^
arch/riscv/include/asm/uaccess.h:185:3: note: expanded from macro '__get_user_nocheck'
185 | __get_user_8((x), __gu_ptr, label); \
| ^
arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8'
130 | u32 __user *__ptr = (u32 __user *)(ptr); \
| ^
2 warnings generated.
..
vim +3921 include/linux/fs.h
90f8572b0f021fd Eric W. Biederman 2015-06-29 3903
45cd0faae3715e3 Amir Goldstein 2018-08-27 3904 /* mm/fadvise.c */
45cd0faae3715e3 Amir Goldstein 2018-08-27 3905 extern int vfs_fadvise(struct file *file, loff_t offset, loff_t len,
45cd0faae3715e3 Amir Goldstein 2018-08-27 3906 int advice);
cf1ea0592dbf109 Jan Kara 2019-08-29 3907 extern int generic_fadvise(struct file *file, loff_t offset, loff_t len,
cf1ea0592dbf109 Jan Kara 2019-08-29 3908 int advice);
45cd0faae3715e3 Amir Goldstein 2018-08-27 3909
1bc6d4452d5c91b Christian Brauner 2024-04-30 3910 static inline bool vfs_empty_path(int dfd, const char __user *path)
1bc6d4452d5c91b Christian Brauner 2024-04-30 3911 {
1bc6d4452d5c91b Christian Brauner 2024-04-30 3912 char c;
1bc6d4452d5c91b Christian Brauner 2024-04-30 3913
1bc6d4452d5c91b Christian Brauner 2024-04-30 3914 if (dfd < 0)
1bc6d4452d5c91b Christian Brauner 2024-04-30 3915 return false;
1bc6d4452d5c91b Christian Brauner 2024-04-30 3916
1bc6d4452d5c91b Christian Brauner 2024-04-30 3917 /* We now allow NULL to be used for empty path. */
1bc6d4452d5c91b Christian Brauner 2024-04-30 3918 if (!path)
1bc6d4452d5c91b Christian Brauner 2024-04-30 3919 return true;
1bc6d4452d5c91b Christian Brauner 2024-04-30 3920
1bc6d4452d5c91b Christian Brauner 2024-04-30 @3921 if (unlikely(get_user(c, path)))
1bc6d4452d5c91b Christian Brauner 2024-04-30 3922 return false;
1bc6d4452d5c91b Christian Brauner 2024-04-30 3923
1bc6d4452d5c91b Christian Brauner 2024-04-30 3924 return !c;
1bc6d4452d5c91b Christian Brauner 2024-04-30 3925 }
1bc6d4452d5c91b Christian Brauner 2024-04-30 3926
:::::: The code at line 3921 was first introduced by commit
:::::: 1bc6d4452d5c91beb09e37a98a590808e1997b79 fs: new helper vfs_empty_path()
:::::: TO: Christian Brauner <brauner@kernel.org>
:::::: CC: Christian Brauner <brauner@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-05-09 7:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505091520.cze8wv81-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexghiti@rivosinc.com \
--cc=cyrilbur@tenstorrent.com \
--cc=jszhang@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox