From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Kent Overstreet <kent.overstreet@linux.dev>
Subject: [bcachefs:bcachefs-testing 331/338] fs/dcache.c:3223: warning: Function parameter or struct member 'dentry' not described in 'd_casefold_disabled_put'
Date: Mon, 2 Jun 2025 04:31:44 +0800 [thread overview]
Message-ID: <202506020428.aKtBuNbS-lkp@intel.com> (raw)
tree: https://evilpiepirate.org/git/bcachefs.git bcachefs-testing
head: ac9cb68e998c4a17159a05fb750fc7e9f3850c41
commit: 520ad9104545fd112f172076b4ed10797c1cc8da [331/338] fs: dcache exlusion between overlayfs, casefolding
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250602/202506020428.aKtBuNbS-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250602/202506020428.aKtBuNbS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506020428.aKtBuNbS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/dcache.c:3223: warning: Function parameter or struct member 'dentry' not described in 'd_casefold_disabled_put'
>> fs/dcache.c:3247: warning: Function parameter or struct member 'dentry' not described in 'd_casefold_disabled_get'
vim +3223 fs/dcache.c
3216
3217 /**
3218 * d_casefold_disabled_put - drop a "casefold disabled" ref
3219 *
3220 * Only for overlayfs.
3221 */
3222 void d_casefold_disabled_put(struct dentry *dentry)
> 3223 {
3224 struct super_block *sb = dentry->d_sb;
3225
3226 if (!(sb->s_flags & SB_CASEFOLD))
3227 return;
3228
3229 guard(mutex)(&sb->s_casefold_enable_lock);
3230 no_casefold_dentry_put(dentry, ref_casefold_disable);
3231 }
3232 EXPORT_SYMBOL_GPL(d_casefold_disabled_put);
3233
3234 /**
3235 * d_casefold_disabled_get - attempt to disable casefold on a tree
3236 *
3237 * Only for overlayfs.
3238 *
3239 * Returns -EINVAL if casefolding is in use on any subdirectory; this must be
3240 * tracked by the filesystem.
3241 *
3242 * On success, returns with a reference held that must be released by
3243 * d_casefold_disabled_put(); this ref blocks casefold from being enabled
3244 * by d_casefold_enable().
3245 */
3246 int d_casefold_disabled_get(struct dentry *dentry)
> 3247 {
3248 struct super_block *sb = dentry->d_sb;
3249
3250 if (!(sb->s_flags & SB_CASEFOLD))
3251 return 0;
3252
3253 guard(mutex)(&sb->s_casefold_enable_lock);
3254
3255 if (!(dentry->d_inode->i_flags & S_NO_CASEFOLD))
3256 return -EINVAL;
3257
3258 return no_casefold_dentry_get(dentry, ref_casefold_disable);
3259 }
3260 EXPORT_SYMBOL_GPL(d_casefold_disabled_get);
3261
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-06-01 20:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506020428.aKtBuNbS-lkp@intel.com \
--to=lkp@intel.com \
--cc=kent.overstreet@linux.dev \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox