[jgg-iommufd:for-next 25/43] Warning: drivers/iommu/iommufd/pages.c:2114 function parameter 'lock_area' not described in 'iopt_area_add_access'

[jgg-iommufd:for-next 25/43] Warning: drivers/iommu/iommufd/pages.c:2114 function parameter 'lock_area' not described in 'iopt_area_add_access'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git for-next
head:   7de5cc04caf979c6a1978b283eb8ad8fe5167e24
commit: 940d0dd200c80a77133156bb3e1aaed47e2a9c23 [25/43] iommufd/access: Bypass access->ops->unmap for internal use
config: i386-buildonly-randconfig-006-20250711 (https://download.01.org/0day-ci/archive/20250711/202507111555.VxJIWo2k-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250711/202507111555.VxJIWo2k-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507111555.VxJIWo2k-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> Warning: drivers/iommu/iommufd/pages.c:2114 function parameter 'lock_area' not described in 'iopt_area_add_access'
>> Warning: drivers/iommu/iommufd/pages.c:2173 function parameter 'unlock_area' not described in 'iopt_area_remove_access'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [jgg-iommufd:for-next 25/43] Warning: drivers/iommu/iommufd/pages.c:2114 function parameter 'lock_area' not described in 'iopt_area_add_access'

[Jason Gunthorpe]

On Fri, Jul 11, 2025 at 03:35:12PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git for-next
> head:   7de5cc04caf979c6a1978b283eb8ad8fe5167e24
> commit: 940d0dd200c80a77133156bb3e1aaed47e2a9c23 [25/43] iommufd/access: Bypass access->ops->unmap for internal use
> config: i386-buildonly-randconfig-006-20250711 (https://download.01.org/0day-ci/archive/20250711/202507111555.VxJIWo2k-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250711/202507111555.VxJIWo2k-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202507111555.VxJIWo2k-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> Warning: drivers/iommu/iommufd/pages.c:2114 function parameter 'lock_area' not described in 'iopt_area_add_access'
> >> Warning: drivers/iommu/iommufd/pages.c:2173 function parameter 'unlock_area' not described in 'iopt_area_remove_access'

I fixed this with:

--- a/drivers/iommu/iommufd/pages.c
+++ b/drivers/iommu/iommufd/pages.c
@@ -2103,6 +2103,7 @@ iopt_pages_get_exact_access(struct iopt_pages *pages, unsigned long index,
  * @last_index: Inclusive last page index
  * @out_pages: Output list of struct page's representing the PFNs
  * @flags: IOMMUFD_ACCESS_RW_* flags
+ * @lock_area: Fail userspace munmap on this area
  *
  * Record that an in-kernel access will be accessing the pages, ensure they are
  * pinned, and return the PFNs as a simple list of 'struct page *'.
@@ -2165,6 +2166,7 @@ int iopt_area_add_access(struct iopt_area *area, unsigned long start_index,
  * @area: The source of PFNs
  * @start_index: First page index
  * @last_index: Inclusive last page index
+ * @unlock_area: Must match the matching iopt_area_add_access()'s lock_area
  *
  * Undo iopt_area_add_access() and unpin the pages if necessary. The caller
  * must stop using the PFNs before calling this.