* [bcachefs:bcachefs-testing 92/119] fs/bcachefs/super.c:2269:3: error: cannot jump from this goto statement to its label
@ 2025-07-14 20:34 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-07-14 20:34 UTC (permalink / raw)
To: Kent Overstreet; +Cc: llvm, oe-kbuild-all, Kent Overstreet
tree: https://evilpiepirate.org/git/bcachefs.git bcachefs-testing
head: 482cb3b5cb54b04f17d439174a6a8d1298da5b9e
commit: f8492388d02294b021e0f85cf14784d2a26e3785 [92/119] bcachefs: convert super.c to CLASS/guards
config: arm-randconfig-001-20250715 (https://download.01.org/0day-ci/archive/20250715/202507150440.yJNwET08-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 16534d19bf50bde879a83f0ae62875e2c5120e64)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250715/202507150440.yJNwET08-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507150440.yJNwET08-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/bcachefs/super.c:2269:3: error: cannot jump from this goto statement to its label
2269 | goto unlock;
| ^
fs/bcachefs/super.c:2282:18: note: jump bypasses initialization of variable with __attribute__((cleanup))
2282 | CLASS(printbuf, buf)();
| ^
1 error generated.
vim +2269 fs/bcachefs/super.c
d5308203a85e01 Kent Overstreet 2025-02-25 2248
d5308203a85e01 Kent Overstreet 2025-02-25 2249 static void bch2_fs_bdev_mark_dead(struct block_device *bdev, bool surprise)
d5308203a85e01 Kent Overstreet 2025-02-25 2250 {
f8492388d02294 Kent Overstreet 2025-07-14 2251 CLASS(bdev_get_fs, c)(bdev);
d5308203a85e01 Kent Overstreet 2025-02-25 2252 if (!c)
d5308203a85e01 Kent Overstreet 2025-02-25 2253 return;
d5308203a85e01 Kent Overstreet 2025-02-25 2254
d5308203a85e01 Kent Overstreet 2025-02-25 2255 struct super_block *sb = c->vfs_sb;
d5308203a85e01 Kent Overstreet 2025-02-25 2256 if (sb) {
d5308203a85e01 Kent Overstreet 2025-02-25 2257 /*
d5308203a85e01 Kent Overstreet 2025-02-25 2258 * Not necessary, c->ro_ref guards against the filesystem being
d5308203a85e01 Kent Overstreet 2025-02-25 2259 * unmounted - we only take this to avoid a warning in
d5308203a85e01 Kent Overstreet 2025-02-25 2260 * sync_filesystem:
d5308203a85e01 Kent Overstreet 2025-02-25 2261 */
d5308203a85e01 Kent Overstreet 2025-02-25 2262 down_read(&sb->s_umount);
d5308203a85e01 Kent Overstreet 2025-02-25 2263 }
d5308203a85e01 Kent Overstreet 2025-02-25 2264
f8492388d02294 Kent Overstreet 2025-07-14 2265 guard(rwsem_write)(&c->state_lock);
f8492388d02294 Kent Overstreet 2025-07-14 2266
d5308203a85e01 Kent Overstreet 2025-02-25 2267 struct bch_dev *ca = bdev_to_bch_dev(c, bdev);
d5308203a85e01 Kent Overstreet 2025-02-25 2268 if (!ca)
d5308203a85e01 Kent Overstreet 2025-02-25 @2269 goto unlock;
d5308203a85e01 Kent Overstreet 2025-02-25 2270
b42fac043f9551 Kent Overstreet 2025-05-13 2271 bool dev = bch2_dev_state_allowed(c, ca,
b42fac043f9551 Kent Overstreet 2025-05-13 2272 BCH_MEMBER_STATE_failed,
b42fac043f9551 Kent Overstreet 2025-05-13 2273 BCH_FORCE_IF_DEGRADED);
b42fac043f9551 Kent Overstreet 2025-05-13 2274
b42fac043f9551 Kent Overstreet 2025-05-13 2275 if (!dev && sb) {
d5308203a85e01 Kent Overstreet 2025-02-25 2276 if (!surprise)
d5308203a85e01 Kent Overstreet 2025-02-25 2277 sync_filesystem(sb);
d5308203a85e01 Kent Overstreet 2025-02-25 2278 shrink_dcache_sb(sb);
d5308203a85e01 Kent Overstreet 2025-02-25 2279 evict_inodes(sb);
d5308203a85e01 Kent Overstreet 2025-02-25 2280 }
d5308203a85e01 Kent Overstreet 2025-02-25 2281
f8492388d02294 Kent Overstreet 2025-07-14 2282 CLASS(printbuf, buf)();
b42fac043f9551 Kent Overstreet 2025-05-13 2283 __bch2_log_msg_start(ca->name, &buf);
b42fac043f9551 Kent Overstreet 2025-05-13 2284
b42fac043f9551 Kent Overstreet 2025-05-13 2285 prt_printf(&buf, "offline from block layer");
b42fac043f9551 Kent Overstreet 2025-05-13 2286
b42fac043f9551 Kent Overstreet 2025-05-13 2287 if (dev) {
b42fac043f9551 Kent Overstreet 2025-05-13 2288 __bch2_dev_offline(c, ca);
b42fac043f9551 Kent Overstreet 2025-05-13 2289 } else {
d5308203a85e01 Kent Overstreet 2025-02-25 2290 bch2_journal_flush(&c->journal);
b42fac043f9551 Kent Overstreet 2025-05-13 2291 bch2_fs_emergency_read_only2(c, &buf);
d5308203a85e01 Kent Overstreet 2025-02-25 2292 }
d5308203a85e01 Kent Overstreet 2025-02-25 2293
b42fac043f9551 Kent Overstreet 2025-05-13 2294 bch2_print_str(c, KERN_ERR, buf.buf);
b42fac043f9551 Kent Overstreet 2025-05-13 2295
d5308203a85e01 Kent Overstreet 2025-02-25 2296 bch2_dev_put(ca);
d5308203a85e01 Kent Overstreet 2025-02-25 2297 unlock:
d5308203a85e01 Kent Overstreet 2025-02-25 2298 if (sb)
d5308203a85e01 Kent Overstreet 2025-02-25 2299 up_read(&sb->s_umount);
d5308203a85e01 Kent Overstreet 2025-02-25 2300 }
d5308203a85e01 Kent Overstreet 2025-02-25 2301
:::::: The code at line 2269 was first introduced by commit
:::::: d5308203a85e016e9ceb3e38742a1634c77a7706 bcachefs: Implement blk_holder_ops
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-14 20:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 20:34 [bcachefs:bcachefs-testing 92/119] fs/bcachefs/super.c:2269:3: error: cannot jump from this goto statement to its label kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).