llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [sean-jc:vmx/tdx_post_populate 2/2] arch/x86/kvm/../../../virt/kvm/guest_memfd.c:672:53: error: too few arguments to function call, expected 6, have 5
@ 2025-08-02  4:11 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-08-02  4:11 UTC (permalink / raw)
  To: Sean Christopherson; +Cc: llvm, oe-kbuild-all

tree:   https://github.com/sean-jc/linux vmx/tdx_post_populate
head:   6ae5e841f16df438a7723a1def7656c100700a8e
commit: 6ae5e841f16df438a7723a1def7656c100700a8e [2/2] tmp
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250802/202508020606.1JpNEvUC-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508020606.1JpNEvUC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508020606.1JpNEvUC-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/kvm/../../../virt/kvm/guest_memfd.c:672:53: error: too few arguments to function call, expected 6, have 5
     672 |         ret = post_populate(kvm, gfn, pfn, src_page, opaque);
         |               ~~~~~~~~~~~~~                                ^
   1 error generated.


vim +672 arch/x86/kvm/../../../virt/kvm/guest_memfd.c

   629	
   630	#ifdef CONFIG_KVM_GENERIC_PRIVATE_MEM
   631	static long __kvm_gmem_populate(struct kvm *kvm, struct kvm_memory_slot *slot,
   632					struct file *file, gfn_t gfn, void __user *src,
   633					kvm_gmem_populate_cb post_populate, void *opaque)
   634	{
   635		pgoff_t index = kvm_gmem_get_index(slot, gfn);
   636		struct page *src_page = NULL;
   637		bool is_prepared = false;
   638		struct folio *folio;
   639		int ret, max_order;
   640		kvm_pfn_t pfn;
   641	
   642		if (src) {
   643			ret = get_user_pages((unsigned long)src, 1, 0, &src_page);
   644			if (ret < 0)
   645				return ret;
   646			if (ret != 1)
   647				return -ENOMEM;
   648		}
   649	
   650		filemap_invalidate_lock(file->f_mapping);
   651	
   652		if (!kvm_range_has_memory_attributes(kvm, gfn, gfn + 1,
   653						     KVM_MEMORY_ATTRIBUTE_PRIVATE,
   654						     KVM_MEMORY_ATTRIBUTE_PRIVATE)) {
   655			ret = -EINVAL;
   656			goto out_unlock;
   657		}
   658	
   659		folio = __kvm_gmem_get_pfn(file, slot, index, &pfn, &is_prepared, &max_order);
   660		if (IS_ERR(folio)) {
   661			ret = PTR_ERR(folio);
   662			goto out_unlock;
   663		}
   664	
   665		folio_unlock(folio);
   666	
   667		if (is_prepared) {
   668			ret = -EEXIST;
   669			goto out_put_folio;
   670		}
   671	
 > 672		ret = post_populate(kvm, gfn, pfn, src_page, opaque);
   673		if (!ret)
   674			kvm_gmem_mark_prepared(folio);
   675	
   676	out_put_folio:
   677		folio_put(folio);
   678	out_unlock:
   679		filemap_invalidate_unlock(file->f_mapping);
   680	
   681		if (src_page)
   682			put_page(src_page);
   683		return ret;
   684	}
   685	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [sean-jc:vmx/tdx_post_populate 2/2] arch/x86/kvm/../../../virt/kvm/guest_memfd.c:672:53: error: too few arguments to function call, expected 6, have 5
@ 2025-08-02 16:08 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-08-02 16:08 UTC (permalink / raw)
  To: Sean Christopherson; +Cc: llvm, oe-kbuild-all

tree:   https://github.com/sean-jc/linux vmx/tdx_post_populate
head:   6ae5e841f16df438a7723a1def7656c100700a8e
commit: 6ae5e841f16df438a7723a1def7656c100700a8e [2/2] tmp
config: x86_64-buildonly-randconfig-004-20250802 (https://download.01.org/0day-ci/archive/20250802/202508022300.8y4vzVXi-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508022300.8y4vzVXi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508022300.8y4vzVXi-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/kvm/../../../virt/kvm/guest_memfd.c:672:53: error: too few arguments to function call, expected 6, have 5
     672 |         ret = post_populate(kvm, gfn, pfn, src_page, opaque);
         |               ~~~~~~~~~~~~~                                ^
   1 error generated.


vim +672 arch/x86/kvm/../../../virt/kvm/guest_memfd.c

   629	
   630	#ifdef CONFIG_KVM_GENERIC_PRIVATE_MEM
   631	static long __kvm_gmem_populate(struct kvm *kvm, struct kvm_memory_slot *slot,
   632					struct file *file, gfn_t gfn, void __user *src,
   633					kvm_gmem_populate_cb post_populate, void *opaque)
   634	{
   635		pgoff_t index = kvm_gmem_get_index(slot, gfn);
   636		struct page *src_page = NULL;
   637		bool is_prepared = false;
   638		struct folio *folio;
   639		int ret, max_order;
   640		kvm_pfn_t pfn;
   641	
   642		if (src) {
   643			ret = get_user_pages((unsigned long)src, 1, 0, &src_page);
   644			if (ret < 0)
   645				return ret;
   646			if (ret != 1)
   647				return -ENOMEM;
   648		}
   649	
   650		filemap_invalidate_lock(file->f_mapping);
   651	
   652		if (!kvm_range_has_memory_attributes(kvm, gfn, gfn + 1,
   653						     KVM_MEMORY_ATTRIBUTE_PRIVATE,
   654						     KVM_MEMORY_ATTRIBUTE_PRIVATE)) {
   655			ret = -EINVAL;
   656			goto out_unlock;
   657		}
   658	
   659		folio = __kvm_gmem_get_pfn(file, slot, index, &pfn, &is_prepared, &max_order);
   660		if (IS_ERR(folio)) {
   661			ret = PTR_ERR(folio);
   662			goto out_unlock;
   663		}
   664	
   665		folio_unlock(folio);
   666	
   667		if (is_prepared) {
   668			ret = -EEXIST;
   669			goto out_put_folio;
   670		}
   671	
 > 672		ret = post_populate(kvm, gfn, pfn, src_page, opaque);
   673		if (!ret)
   674			kvm_gmem_mark_prepared(folio);
   675	
   676	out_put_folio:
   677		folio_put(folio);
   678	out_unlock:
   679		filemap_invalidate_unlock(file->f_mapping);
   680	
   681		if (src_page)
   682			put_page(src_page);
   683		return ret;
   684	}
   685	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-02 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-02 16:08 [sean-jc:vmx/tdx_post_populate 2/2] arch/x86/kvm/../../../virt/kvm/guest_memfd.c:672:53: error: too few arguments to function call, expected 6, have 5 kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2025-08-02  4:11 kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).