Re: [PATCH 7/9] powerpc/pseries: Enable HVPIPE event message interrupt

Re: [PATCH 7/9] powerpc/pseries: Enable HVPIPE event message interrupt

[kernel test robot]

Hi Haren,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes v6.16]
[cannot apply to linus/master next-20250801]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haren-Myneni/powerpc-pseries-Define-papr-hvpipe-ioctl/20250802-104715
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20250802024121.955274-8-haren%40linux.ibm.com
patch subject: [PATCH 7/9] powerpc/pseries: Enable HVPIPE event message interrupt
config: powerpc64-randconfig-001-20250803 (https://download.01.org/0day-ci/archive/20250803/202508030428.qmzSb9kN-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250803/202508030428.qmzSb9kN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508030428.qmzSb9kN-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/powerpc/platforms/pseries/papr-hvpipe.c:698:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
     698 |         if (!enable_hvpipe_IRQ()) {
         |             ^~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:710:9: note: uninitialized use occurs here
     710 |         return ret;
         |                ^~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:698:2: note: remove the 'if' if its condition is always true
     698 |         if (!enable_hvpipe_IRQ()) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:676:9: note: initialize the variable 'ret' to silence this warning
     676 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +698 arch/powerpc/platforms/pseries/papr-hvpipe.c

   673	
   674	static int __init papr_hvpipe_init(void)
   675	{
   676		int ret;
   677	
   678		if (!of_find_property(rtas.dev, "ibm,hypervisor-pipe-capable",
   679			NULL))
   680			return -ENODEV;
   681	
   682		if (!rtas_function_implemented(RTAS_FN_IBM_SEND_HVPIPE_MSG) ||
   683			!rtas_function_implemented(RTAS_FN_IBM_RECEIVE_HVPIPE_MSG))
   684			return -ENODEV;
   685	
   686		papr_hvpipe_work = kzalloc(sizeof(struct work_struct), GFP_ATOMIC);
   687		if (!papr_hvpipe_work)
   688			return -ENOMEM;
   689	
   690		INIT_WORK(papr_hvpipe_work, papr_hvpipe_work_fn);
   691	
   692		papr_hvpipe_wq = alloc_ordered_workqueue("papr hvpipe workqueue", 0);
   693		if (!papr_hvpipe_wq) {
   694			ret = -ENOMEM;
   695			goto out;
   696		}
   697	
 > 698		if (!enable_hvpipe_IRQ()) {

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki