Re: [PATCH 8/9] powerpc/pseries: Enable hvpipe with ibm,set-system-parameter RTAS

Re: [PATCH 8/9] powerpc/pseries: Enable hvpipe with ibm,set-system-parameter RTAS

[kernel test robot]

Hi Haren,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes v6.16]
[cannot apply to linus/master next-20250801]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haren-Myneni/powerpc-pseries-Define-papr-hvpipe-ioctl/20250802-104715
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20250802024121.955274-9-haren%40linux.ibm.com
patch subject: [PATCH 8/9] powerpc/pseries: Enable hvpipe with ibm,set-system-parameter RTAS
config: powerpc64-randconfig-001-20250803 (https://download.01.org/0day-ci/archive/20250803/202508030602.TrsVGpjD-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250803/202508030602.TrsVGpjD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508030602.TrsVGpjD-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/powerpc/platforms/pseries/papr-hvpipe.c:725:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
     725 |         if (!enable_hvpipe_IRQ() && !set_hvpipe_sys_param(1)) {
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:737:9: note: uninitialized use occurs here
     737 |         return ret;
         |                ^~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:725:2: note: remove the 'if' if its condition is always true
     725 |         if (!enable_hvpipe_IRQ() && !set_hvpipe_sys_param(1)) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/powerpc/platforms/pseries/papr-hvpipe.c:725:6: warning: variable 'ret' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
     725 |         if (!enable_hvpipe_IRQ() && !set_hvpipe_sys_param(1)) {
         |             ^~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:737:9: note: uninitialized use occurs here
     737 |         return ret;
         |                ^~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:725:6: note: remove the '&&' if its condition is always true
     725 |         if (!enable_hvpipe_IRQ() && !set_hvpipe_sys_param(1)) {
         |             ^~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/platforms/pseries/papr-hvpipe.c:703:9: note: initialize the variable 'ret' to silence this warning
     703 |         int ret;
         |                ^
         |                 = 0
   2 warnings generated.


vim +725 arch/powerpc/platforms/pseries/papr-hvpipe.c

   700	
   701	static int __init papr_hvpipe_init(void)
   702	{
   703		int ret;
   704	
   705		if (!of_find_property(rtas.dev, "ibm,hypervisor-pipe-capable",
   706			NULL))
   707			return -ENODEV;
   708	
   709		if (!rtas_function_implemented(RTAS_FN_IBM_SEND_HVPIPE_MSG) ||
   710			!rtas_function_implemented(RTAS_FN_IBM_RECEIVE_HVPIPE_MSG))
   711			return -ENODEV;
   712	
   713		papr_hvpipe_work = kzalloc(sizeof(struct work_struct), GFP_ATOMIC);
   714		if (!papr_hvpipe_work)
   715			return -ENOMEM;
   716	
   717		INIT_WORK(papr_hvpipe_work, papr_hvpipe_work_fn);
   718	
   719		papr_hvpipe_wq = alloc_ordered_workqueue("papr hvpipe workqueue", 0);
   720		if (!papr_hvpipe_wq) {
   721			ret = -ENOMEM;
   722			goto out;
   723		}
   724	
 > 725		if (!enable_hvpipe_IRQ() && !set_hvpipe_sys_param(1)) {

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki