From: Nathan Chancellor <nathan@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>, Alexandre Ghiti <alex@ghiti.fr>
Cc: Conor Dooley <conor@kernel.org>,
linux-riscv@lists.infradead.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: Only allow LTO with CMODEL_MEDANY
Date: Fri, 8 Aug 2025 14:53:03 -0700 [thread overview]
Message-ID: <20250808215303.GA3695089@ax162> (raw)
In-Reply-To: <20250710-riscv-restrict-lto-to-medany-v1-1-b1dac9871ecf@kernel.org>
Ping? This is still getting hit.
On Thu, Jul 10, 2025 at 01:25:26PM -0700, Nathan Chancellor wrote:
> When building with CONFIG_CMODEL_MEDLOW and CONFIG_LTO_CLANG, there is a
> series of errors due to some files being unconditionally compiled with
> '-mcmodel=medany', mismatching with the rest of the kernel built with
> '-mcmodel=medlow':
>
> ld.lld: error: Function Import: link error: linking module flags 'Code Model': IDs have conflicting values: 'i32 3' from vmlinux.a(init.o at 899908), and 'i32 1' from vmlinux.a(net-traces.o at 1014628)
>
> Only allow LTO to be performed when CONFIG_CMODEL_MEDANY is enabled to
> ensure there will be no code model mismatch errors. An alternative
> solution would be disabling LTO for the files with a different code
> model than the main kernel like some specialized areas of the kernel do
> but doing that for individual files is not as sustainable than
> forbidding the combination altogether.
>
> Cc: stable@vger.kernel.org
> Fixes: 021d23428bdb ("RISC-V: build: Allow LTO to be selected")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506290255.KBVM83vZ-lkp@intel.com/
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/riscv/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 36061f4732b7..4eee737a050f 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -68,7 +68,7 @@ config RISCV
> select ARCH_SUPPORTS_HUGE_PFNMAP if TRANSPARENT_HUGEPAGE
> select ARCH_SUPPORTS_HUGETLBFS if MMU
> # LLD >= 14: https://github.com/llvm/llvm-project/issues/50505
> - select ARCH_SUPPORTS_LTO_CLANG if LLD_VERSION >= 140000
> + select ARCH_SUPPORTS_LTO_CLANG if LLD_VERSION >= 140000 && CMODEL_MEDANY
> select ARCH_SUPPORTS_LTO_CLANG_THIN if LLD_VERSION >= 140000
> select ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS if 64BIT && MMU
> select ARCH_SUPPORTS_PAGE_TABLE_CHECK if MMU
>
> ---
> base-commit: fda589c286040d9ba2d72a0eaf0a13945fc48026
> change-id: 20250710-riscv-restrict-lto-to-medany-f1b7dd5c9bba
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
next prev parent reply other threads:[~2025-08-08 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 20:25 [PATCH] riscv: Only allow LTO with CMODEL_MEDANY Nathan Chancellor
2025-08-08 21:53 ` Nathan Chancellor [this message]
2025-08-09 10:45 ` Alexandre Ghiti
2025-08-10 0:24 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808215303.GA3695089@ax162 \
--to=nathan@kernel.org \
--cc=alex@ghiti.fr \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).