* Re: [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report
[not found] <20250807155924.2272507-1-vadfed@meta.com>
@ 2025-08-08 19:57 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-08-08 19:57 UTC (permalink / raw)
To: Vadim Fedorenko; +Cc: llvm, oe-kbuild-all
Hi Vadim,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on tnguy-next-queue/dev-queue]
[also build test ERROR on tnguy-net-queue/dev-queue net/main net-next/main linus/master v6.16 next-20250808]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/ethtool-add-FEC-bins-histogramm-report/20250808-000418
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link: https://lore.kernel.org/r/20250807155924.2272507-1-vadfed%40meta.com
patch subject: [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20250809/202508090307.VECVHHAP-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250809/202508090307.VECVHHAP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508090307.VECVHHAP-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:8:
In file included from include/linux/pci.h:38:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:12:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:1175:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
1175 | return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
| ~~~~~~~~~~ ^
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:1287:18: warning: declaration of 'struct ethtool_fec_histe' will not be visible outside of this function [-Wvisibility]
1287 | struct ethtool_fec_histe *hist)
| ^
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:1353:20: error: incompatible function pointer types initializing 'void (*)(struct net_device *, struct ethtool_fec_stats *, struct ethtool_fec_hist *)' with an expression of type 'void (struct net_device *, struct ethtool_fec_stats *, struct ethtool_fec_histe *)' [-Wincompatible-function-pointer-types]
1353 | .get_fec_stats = otx2_get_fec_stats,
| ^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
vim +1353 drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
cff713ce6c1307 Christina Jacob 2021-02-09 1284
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1285 static void otx2_get_fec_stats(struct net_device *netdev,
3d498d3cb4dd5c Vadim Fedorenko 2025-08-07 1286 struct ethtool_fec_stats *fec_stats,
3d498d3cb4dd5c Vadim Fedorenko 2025-08-07 @1287 struct ethtool_fec_histe *hist)
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1288 {
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1289 struct otx2_nic *pfvf = netdev_priv(netdev);
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1290 struct cgx_fw_data *rsp;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1291
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1292 otx2_update_lmac_fec_stats(pfvf);
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1293
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1294 /* Report MAC FEC stats */
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1295 fec_stats->corrected_blocks.total = pfvf->hw.cgx_fec_corr_blks;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1296 fec_stats->uncorrectable_blocks.total = pfvf->hw.cgx_fec_uncorr_blks;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1297
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1298 rsp = otx2_get_fwdata(pfvf);
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1299 if (!IS_ERR(rsp) && rsp->fwdata.phy.misc.has_fec_stats &&
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1300 !otx2_get_phy_fec_stats(pfvf)) {
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1301 /* Fetch fwdata again because it's been recently populated with
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1302 * latest PHY FEC stats.
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1303 */
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1304 rsp = otx2_get_fwdata(pfvf);
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1305 if (!IS_ERR(rsp)) {
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1306 struct fec_stats_s *p = &rsp->fwdata.phy.fec_stats;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1307
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1308 if (pfvf->linfo.fec == OTX2_FEC_BASER) {
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1309 fec_stats->corrected_blocks.total = p->brfec_corr_blks;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1310 fec_stats->uncorrectable_blocks.total = p->brfec_uncorr_blks;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1311 } else {
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1312 fec_stats->corrected_blocks.total = p->rsfec_corr_cws;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1313 fec_stats->uncorrectable_blocks.total = p->rsfec_uncorr_cws;
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1314 }
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1315 }
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1316 }
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1317 }
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 1318
d45d8979840d9c Christina Jacob 2020-01-27 1319 static const struct ethtool_ops otx2_ethtool_ops = {
af7fcbbd2229cc Jakub Kicinski 2020-03-12 1320 .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
6e144b47f560ed Suman Ghosh 2022-05-17 1321 ETHTOOL_COALESCE_MAX_FRAMES |
6e144b47f560ed Suman Ghosh 2022-05-17 1322 ETHTOOL_COALESCE_USE_ADAPTIVE,
68258596cbc9a6 Subbaraya Sundeep 2022-02-23 1323 .supported_ring_params = ETHTOOL_RING_USE_RX_BUF_LEN |
68258596cbc9a6 Subbaraya Sundeep 2022-02-23 1324 ETHTOOL_RING_USE_CQE_SIZE,
62e01d8c4170f3 Jakub Kicinski 2025-07-07 1325 .rxfh_max_num_contexts = MAX_RSS_GROUPS,
6e92d71bf88208 Sunil Goutham 2020-01-27 1326 .get_link = otx2_get_link,
d45d8979840d9c Christina Jacob 2020-01-27 1327 .get_drvinfo = otx2_get_drvinfo,
d45d8979840d9c Christina Jacob 2020-01-27 1328 .get_strings = otx2_get_strings,
d45d8979840d9c Christina Jacob 2020-01-27 1329 .get_ethtool_stats = otx2_get_ethtool_stats,
d45d8979840d9c Christina Jacob 2020-01-27 1330 .get_sset_count = otx2_get_sset_count,
d45d8979840d9c Christina Jacob 2020-01-27 1331 .set_channels = otx2_set_channels,
d45d8979840d9c Christina Jacob 2020-01-27 1332 .get_channels = otx2_get_channels,
d45d8979840d9c Christina Jacob 2020-01-27 1333 .get_ringparam = otx2_get_ringparam,
d45d8979840d9c Christina Jacob 2020-01-27 1334 .set_ringparam = otx2_set_ringparam,
d45d8979840d9c Christina Jacob 2020-01-27 1335 .get_coalesce = otx2_get_coalesce,
d45d8979840d9c Christina Jacob 2020-01-27 1336 .set_coalesce = otx2_set_coalesce,
6e92d71bf88208 Sunil Goutham 2020-01-27 1337 .get_rxnfc = otx2_get_rxnfc,
6e92d71bf88208 Sunil Goutham 2020-01-27 1338 .set_rxnfc = otx2_set_rxnfc,
6e92d71bf88208 Sunil Goutham 2020-01-27 1339 .get_rxfh_key_size = otx2_get_rxfh_key_size,
6e92d71bf88208 Sunil Goutham 2020-01-27 1340 .get_rxfh_indir_size = otx2_get_rxfh_indir_size,
6e92d71bf88208 Sunil Goutham 2020-01-27 1341 .get_rxfh = otx2_get_rxfh,
6e92d71bf88208 Sunil Goutham 2020-01-27 1342 .set_rxfh = otx2_set_rxfh,
f99ff3c2a3285b Jakub Kicinski 2025-06-16 1343 .get_rxfh_fields = otx2_get_rss_hash_opts,
f99ff3c2a3285b Jakub Kicinski 2025-06-16 1344 .set_rxfh_fields = otx2_set_rss_hash_opts,
62e01d8c4170f3 Jakub Kicinski 2025-07-07 1345 .create_rxfh_context = otx2_create_rxfh,
62e01d8c4170f3 Jakub Kicinski 2025-07-07 1346 .modify_rxfh_context = otx2_modify_rxfh,
62e01d8c4170f3 Jakub Kicinski 2025-07-07 1347 .remove_rxfh_context = otx2_remove_rxfh,
6e92d71bf88208 Sunil Goutham 2020-01-27 1348 .get_msglevel = otx2_get_msglevel,
6e92d71bf88208 Sunil Goutham 2020-01-27 1349 .set_msglevel = otx2_set_msglevel,
75f36270990c78 Geetha sowjanya 2020-03-02 1350 .get_pauseparam = otx2_get_pauseparam,
75f36270990c78 Geetha sowjanya 2020-03-02 1351 .set_pauseparam = otx2_set_pauseparam,
c9c12d339d9336 Aleksey Makarov 2020-08-24 1352 .get_ts_info = otx2_get_ts_info,
b441c4ac5ea372 Hariprasad Kelam 2022-12-05 @1353 .get_fec_stats = otx2_get_fec_stats,
d0cf9503e908ee Christina Jacob 2021-02-09 1354 .get_fecparam = otx2_get_fecparam,
d0cf9503e908ee Christina Jacob 2021-02-09 1355 .set_fecparam = otx2_set_fecparam,
1a50280c25ecfb Christina Jacob 2021-02-09 1356 .get_link_ksettings = otx2_get_link_ksettings,
cff713ce6c1307 Christina Jacob 2021-02-09 1357 .set_link_ksettings = otx2_set_link_ksettings,
d45d8979840d9c Christina Jacob 2020-01-27 1358 };
d45d8979840d9c Christina Jacob 2020-01-27 1359
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-08-08 19:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250807155924.2272507-1-vadfed@meta.com>
2025-08-08 19:57 ` [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).