llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [thomas-weissschuh:b4/umh-h 9/10] drivers/block/drbd/drbd_nl.c:383:8: error: call to undeclared function 'call_usermodehelper'; ISO C99 and later do not support implicit function declarations
@ 2025-08-12  1:57 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-08-12  1:57 UTC (permalink / raw)
  To: Thomas Weißschuh; +Cc: llvm, oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thomas.weissschuh/linux.git b4/umh-h
head:   a1a2ca5277223b8a92db92f3f53fdafe0c462675
commit: d2f44a17dab4dab7e29a9fbde3594789beb8fcd8 [9/10] modules/kmod: remove transitive include of umh.h
config: i386-buildonly-randconfig-2003-20250812 (https://download.01.org/0day-ci/archive/20250812/202508120340.IMBXzPpp-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250812/202508120340.IMBXzPpp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508120340.IMBXzPpp-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/block/drbd/drbd_nl.c:383:8: error: call to undeclared function 'call_usermodehelper'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     383 |         ret = call_usermodehelper(drbd_usermode_helper, argv, envp, UMH_WAIT_PROC);
         |               ^
>> drivers/block/drbd/drbd_nl.c:383:62: error: use of undeclared identifier 'UMH_WAIT_PROC'
     383 |         ret = call_usermodehelper(drbd_usermode_helper, argv, envp, UMH_WAIT_PROC);
         |                                                                     ^
   drivers/block/drbd/drbd_nl.c:425:8: error: call to undeclared function 'call_usermodehelper'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     425 |         ret = call_usermodehelper(drbd_usermode_helper, argv, envp, UMH_WAIT_PROC);
         |               ^
   drivers/block/drbd/drbd_nl.c:425:62: error: use of undeclared identifier 'UMH_WAIT_PROC'
     425 |         ret = call_usermodehelper(drbd_usermode_helper, argv, envp, UMH_WAIT_PROC);
         |                                                                     ^
   4 errors generated.


vim +/call_usermodehelper +383 drivers/block/drbd/drbd_nl.c

b411b3637fa71f Philipp Reisner     2009-09-25  353  
b30ab7913b0a7b Andreas Gruenbacher 2011-07-03  354  int drbd_khelper(struct drbd_device *device, char *cmd)
6b75dced005c7f Philipp Reisner     2011-03-16  355  {
6b75dced005c7f Philipp Reisner     2011-03-16  356  	char *envp[] = { "HOME=/",
6b75dced005c7f Philipp Reisner     2011-03-16  357  			"TERM=linux",
6b75dced005c7f Philipp Reisner     2011-03-16  358  			"PATH=/sbin:/usr/sbin:/bin:/usr/bin",
6b75dced005c7f Philipp Reisner     2011-03-16  359  			 (char[20]) { }, /* address family */
6b75dced005c7f Philipp Reisner     2011-03-16  360  			 (char[60]) { }, /* address */
6b75dced005c7f Philipp Reisner     2011-03-16  361  			NULL };
0982368bfd5964 Lars Ellenberg      2016-06-14  362  	char mb[14];
8ab761e17efa75 Greg Kroah-Hartman  2017-08-29  363  	char *argv[] = {drbd_usermode_helper, cmd, mb, NULL };
a6b32bc3cebd3f Andreas Gruenbacher 2011-05-31  364  	struct drbd_connection *connection = first_peer_device(device)->connection;
6b75dced005c7f Philipp Reisner     2011-03-16  365  	struct sib_info sib;
6b75dced005c7f Philipp Reisner     2011-03-16  366  	int ret;
6b75dced005c7f Philipp Reisner     2011-03-16  367  
bde89a9e151b48 Andreas Gruenbacher 2011-05-30  368  	if (current == connection->worker.task)
bde89a9e151b48 Andreas Gruenbacher 2011-05-30  369  		set_bit(CALLBACK_PENDING, &connection->flags);
6f3465ed82b109 Lars Ellenberg      2012-07-30  370  
0982368bfd5964 Lars Ellenberg      2016-06-14  371  	snprintf(mb, 14, "minor-%d", device_to_minor(device));
bde89a9e151b48 Andreas Gruenbacher 2011-05-30  372  	setup_khelper_env(connection, envp);
6b75dced005c7f Philipp Reisner     2011-03-16  373  
1090c056c5eb6d Lars Ellenberg      2010-07-19  374  	/* The helper may take some time.
1090c056c5eb6d Lars Ellenberg      2010-07-19  375  	 * write out any unsynced meta data changes now */
b30ab7913b0a7b Andreas Gruenbacher 2011-07-03  376  	drbd_md_sync(device);
1090c056c5eb6d Lars Ellenberg      2010-07-19  377  
8ab761e17efa75 Greg Kroah-Hartman  2017-08-29  378  	drbd_info(device, "helper command: %s %s %s\n", drbd_usermode_helper, cmd, mb);
3b98c0c2093d1f Lars Ellenberg      2011-03-07  379  	sib.sib_reason = SIB_HELPER_PRE;
3b98c0c2093d1f Lars Ellenberg      2011-03-07  380  	sib.helper_name = cmd;
b30ab7913b0a7b Andreas Gruenbacher 2011-07-03  381  	drbd_bcast_event(device, &sib);
a29728463b254c Andreas Gruenbacher 2014-07-31  382  	notify_helper(NOTIFY_CALL, device, connection, cmd, 0);
8ab761e17efa75 Greg Kroah-Hartman  2017-08-29 @383  	ret = call_usermodehelper(drbd_usermode_helper, argv, envp, UMH_WAIT_PROC);
b411b3637fa71f Philipp Reisner     2009-09-25  384  	if (ret)
d01801710265cf Andreas Gruenbacher 2011-07-03  385  		drbd_warn(device, "helper command: %s %s %s exit code %u (0x%x)\n",
8ab761e17efa75 Greg Kroah-Hartman  2017-08-29  386  				drbd_usermode_helper, cmd, mb,
b411b3637fa71f Philipp Reisner     2009-09-25  387  				(ret >> 8) & 0xff, ret);
b411b3637fa71f Philipp Reisner     2009-09-25  388  	else
d01801710265cf Andreas Gruenbacher 2011-07-03  389  		drbd_info(device, "helper command: %s %s %s exit code %u (0x%x)\n",
8ab761e17efa75 Greg Kroah-Hartman  2017-08-29  390  				drbd_usermode_helper, cmd, mb,
b411b3637fa71f Philipp Reisner     2009-09-25  391  				(ret >> 8) & 0xff, ret);
3b98c0c2093d1f Lars Ellenberg      2011-03-07  392  	sib.sib_reason = SIB_HELPER_POST;
3b98c0c2093d1f Lars Ellenberg      2011-03-07  393  	sib.helper_exit_code = ret;
b30ab7913b0a7b Andreas Gruenbacher 2011-07-03  394  	drbd_bcast_event(device, &sib);
a29728463b254c Andreas Gruenbacher 2014-07-31  395  	notify_helper(NOTIFY_RESPONSE, device, connection, cmd, ret);
b411b3637fa71f Philipp Reisner     2009-09-25  396  
bde89a9e151b48 Andreas Gruenbacher 2011-05-30  397  	if (current == connection->worker.task)
bde89a9e151b48 Andreas Gruenbacher 2011-05-30  398  		clear_bit(CALLBACK_PENDING, &connection->flags);
c2ba686f353972 Lars Ellenberg      2012-06-14  399  
b411b3637fa71f Philipp Reisner     2009-09-25  400  	if (ret < 0) /* Ignore any ERRNOs we got. */
b411b3637fa71f Philipp Reisner     2009-09-25  401  		ret = 0;
b411b3637fa71f Philipp Reisner     2009-09-25  402  
b411b3637fa71f Philipp Reisner     2009-09-25  403  	return ret;
b411b3637fa71f Philipp Reisner     2009-09-25  404  }
b411b3637fa71f Philipp Reisner     2009-09-25  405  

:::::: The code at line 383 was first introduced by commit
:::::: 8ab761e17efa75449db2d71dc6fabf96d110588c drbd: rename "usermode_helper" to "drbd_usermode_helper"

:::::: TO: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-12  1:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12  1:57 [thomas-weissschuh:b4/umh-h 9/10] drivers/block/drbd/drbd_nl.c:383:8: error: call to undeclared function 'call_usermodehelper'; ISO C99 and later do not support implicit function declarations kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).