Re: [PATCH nf-next] netfilter: ctnetlink: remove refcounting in dying list dumping

Re: [PATCH nf-next] netfilter: ctnetlink: remove refcounting in dying list dumping

[kernel test robot]

Hi Florian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on netfilter-nf/main]
[also build test WARNING on linus/master v6.17-rc1 next-20250814]
[cannot apply to nf-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-ctnetlink-remove-refcounting-in-dying-list-dumping/20250815-003116
base:   https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link:    https://lore.kernel.org/r/20250814162307.26029-1-fw%40strlen.de
patch subject: [PATCH nf-next] netfilter: ctnetlink: remove refcounting in dying list dumping
config: hexagon-randconfig-001-20250815 (https://download.01.org/0day-ci/archive/20250815/202508151104.eDVcRAdD-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 3769ce013be2879bf0b329c14a16f5cb766f26ce)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250815/202508151104.eDVcRAdD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508151104.eDVcRAdD-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_netlink.c:1785:16: warning: unused variable 'last_id' [-Wunused-variable]
    1785 |         unsigned long last_id = ctx->last_id;
         |                       ^~~~~~~
   1 warning generated.


vim +/last_id +1785 net/netfilter/nf_conntrack_netlink.c

  1780	
  1781	static int
  1782	ctnetlink_dump_dying(struct sk_buff *skb, struct netlink_callback *cb)
  1783	{
  1784		struct ctnetlink_list_dump_ctx *ctx = (void *)cb->ctx;
> 1785		unsigned long last_id = ctx->last_id;
  1786	#ifdef CONFIG_NF_CONNTRACK_EVENTS
  1787		const struct net *net = sock_net(skb->sk);
  1788		struct nf_conntrack_net_ecache *ecache_net;
  1789		struct nf_conntrack_tuple_hash *h;
  1790		struct hlist_nulls_node *n;
  1791	#endif
  1792	
  1793		if (ctx->done)
  1794			return 0;
  1795	
  1796		ctx->last_id = 0;
  1797	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki