Re: [PATCH 4/6] hwmon: ltc4283-hwmon: Add support for the LTC4283 Swap Controller

Re: [PATCH 4/6] hwmon: ltc4283-hwmon: Add support for the LTC4283 Swap Controller

[kernel test robot]

Hi Nuno,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9703c672af8dd3573c76ce509dfff26bf6c4768d]

url:    https://github.com/intel-lab-lkp/linux/commits/Nuno-S-via-B4-Relay/dt-binbings-mfd-Add-bindings-for-the-LTC4283-Swap-Controller/20250814-190311
base:   9703c672af8dd3573c76ce509dfff26bf6c4768d
patch link:    https://lore.kernel.org/r/20250814-ltc4283-support-v1-4-88b2cef773f2%40analog.com
patch subject: [PATCH 4/6] hwmon: ltc4283-hwmon: Add support for the LTC4283 Swap Controller
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250816/202508160822.04pfkosr-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250816/202508160822.04pfkosr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508160822.04pfkosr-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hwmon/ltc4283-hwmon.c:579:10: warning: result of comparison of constant 65536 with expression of type 'u16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]
     579 |         if (tmp == BIT(16))
         |             ~~~ ^  ~~~~~~~
   1 warning generated.


vim +579 drivers/hwmon/ltc4283-hwmon.c

   570	
   571	static int __ltc4283_hwmon_write_in_history(struct ltc4283_hwmon *st,
   572						    u32 reg, long lowest, u32 fs)
   573	{
   574		__be16 __raw;
   575		u16 tmp;
   576		int ret;
   577	
   578		tmp = DIV_ROUND_CLOSEST(BIT(16) * lowest, fs);
 > 579		if (tmp == BIT(16))
   580			tmp = U16_MAX;
   581	
   582		__raw = cpu_to_be16(tmp);
   583	
   584		ret = regmap_bulk_write(st->map, reg, &__raw, sizeof(__raw));
   585		if (ret)
   586			return ret;
   587	
   588		tmp = 0;
   589		return regmap_bulk_write(st->map, reg + 1,  &tmp, sizeof(tmp));
   590	}
   591	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki