* [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
@ 2025-08-22 21:30 kernel test robot
2025-08-22 22:09 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-08-22 21:30 UTC (permalink / raw)
To: Rohan McLure
Cc: llvm, oe-kbuild-all, Andrew Morton, Linux Memory Management List,
Andrew Donnellan, Pasha Tatashin
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
head: a8af4c2fd982fd94fffde3c5b6b764fd20af68fe
commit: e009b0f3187482a5756ff3b015cf30277cc1cfd9 [216/233] mm/page_table_check: reinstate address parameter in [__]page_table_check_pud_clear()
config: riscv-randconfig-001-20250823 (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d26ea02060b1c9db751d188b2edb0059a9eb273d)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508230551.qiEQu04P-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:31:
In file included from include/linux/pgtable.h:6:
>> arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
951 | page_table_check_pud_clear(mm, pud);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
include/linux/page_table_check.h:128:20: note: 'page_table_check_pud_clear' declared here
128 | static inline void page_table_check_pud_clear(struct mm_struct *mm,
| ^ ~~~~~~~~~~~~~~~~~~~~~
129 | unsigned long addr, pud_t pud)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:98:11: warning: array index 3 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
98 | return (set->sig[3] | set->sig[2] |
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:98:25: warning: array index 2 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
98 | return (set->sig[3] | set->sig[2] |
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:99:4: warning: array index 1 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
99 | set->sig[1] | set->sig[0]) == 0;
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:101:11: warning: array index 1 is past the end of the array (that has type 'unsigned long[1]') [-Warray-bounds]
101 | return (set->sig[1] | set->sig[0]) == 0;
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:114:11: warning: array index 3 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
114 | return (set1->sig[3] == set2->sig[3]) &&
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:114:27: warning: array index 3 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
114 | return (set1->sig[3] == set2->sig[3]) &&
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:115:5: warning: array index 2 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
115 | (set1->sig[2] == set2->sig[2]) &&
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:115:21: warning: array index 2 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
115 | (set1->sig[2] == set2->sig[2]) &&
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
In file included from include/linux/sched/signal.h:6:
include/linux/signal.h:116:5: warning: array index 1 is past the end of the array (that has type 'const unsigned long[1]') [-Warray-bounds]
116 | (set1->sig[1] == set2->sig[1]) &&
| ^ ~
include/uapi/asm-generic/signal.h:62:2: note: array 'sig' declared here
62 | unsigned long sig[_NSIG_WORDS];
| ^
In file included from arch/riscv/kernel/asm-offsets.c:8:
In file included from include/linux/mm.h:36:
In file included from include/linux/rcuwait.h:6:
vim +951 arch/riscv/include/asm/pgtable.h
c3cc2a4a3a23faf Alexandre Ghiti 2025-03-21 944
f2716df5ec97bde Alexandre Ghiti 2025-08-14 945 #define __HAVE_ARCH_PUDP_HUGE_GET_AND_CLEAR
f2716df5ec97bde Alexandre Ghiti 2025-08-14 946 static inline pud_t pudp_huge_get_and_clear(struct mm_struct *mm,
f2716df5ec97bde Alexandre Ghiti 2025-08-14 947 unsigned long address, pud_t *pudp)
f2716df5ec97bde Alexandre Ghiti 2025-08-14 948 {
f2716df5ec97bde Alexandre Ghiti 2025-08-14 949 pud_t pud = __pud(atomic_long_xchg((atomic_long_t *)pudp, 0));
f2716df5ec97bde Alexandre Ghiti 2025-08-14 950
f2716df5ec97bde Alexandre Ghiti 2025-08-14 @951 page_table_check_pud_clear(mm, pud);
f2716df5ec97bde Alexandre Ghiti 2025-08-14 952
f2716df5ec97bde Alexandre Ghiti 2025-08-14 953 return pud;
f2716df5ec97bde Alexandre Ghiti 2025-08-14 954 }
f2716df5ec97bde Alexandre Ghiti 2025-08-14 955
:::::: The code at line 951 was first introduced by commit
:::::: f2716df5ec97bde2827d917452dc4de45a6c737c riscv: use an atomic xchg in pudp_huge_get_and_clear()
:::::: TO: Alexandre Ghiti <alexghiti@rivosinc.com>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
2025-08-22 21:30 [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2 kernel test robot
@ 2025-08-22 22:09 ` Andrew Morton
2025-08-25 20:07 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2025-08-22 22:09 UTC (permalink / raw)
To: kernel test robot
Cc: Rohan McLure, llvm, oe-kbuild-all, Linux Memory Management List,
Andrew Donnellan, Pasha Tatashin
On Sat, 23 Aug 2025 05:30:45 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head: a8af4c2fd982fd94fffde3c5b6b764fd20af68fe
> commit: e009b0f3187482a5756ff3b015cf30277cc1cfd9 [216/233] mm/page_table_check: reinstate address parameter in [__]page_table_check_pud_clear()
> config: riscv-randconfig-001-20250823 (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d26ea02060b1c9db751d188b2edb0059a9eb273d)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508230551.qiEQu04P-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/riscv/kernel/asm-offsets.c:8:
> In file included from include/linux/mm.h:31:
> In file included from include/linux/pgtable.h:6:
> >> arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
> 951 | page_table_check_pud_clear(mm, pud);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Thanks, I added this:
--- a/arch/riscv/include/asm/pgtable.h~mm-page_table_check-reinstate-address-parameter-in-page_table_check_pud_set-fix
+++ a/arch/riscv/include/asm/pgtable.h
@@ -948,7 +948,7 @@ static inline pud_t pudp_huge_get_and_cl
{
pud_t pud = __pud(atomic_long_xchg((atomic_long_t *)pudp, 0));
- page_table_check_pud_clear(mm, pud);
+ page_table_check_pud_clear(mm, address, pud);
return pud;
}
_
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
2025-08-22 22:09 ` Andrew Morton
@ 2025-08-25 20:07 ` Nathan Chancellor
2025-08-25 22:38 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2025-08-25 20:07 UTC (permalink / raw)
To: Andrew Morton
Cc: kernel test robot, Rohan McLure, llvm, oe-kbuild-all,
Linux Memory Management List, Andrew Donnellan, Pasha Tatashin
On Fri, Aug 22, 2025 at 03:09:06PM -0700, Andrew Morton wrote:
> On Sat, 23 Aug 2025 05:30:45 +0800 kernel test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> > head: a8af4c2fd982fd94fffde3c5b6b764fd20af68fe
> > commit: e009b0f3187482a5756ff3b015cf30277cc1cfd9 [216/233] mm/page_table_check: reinstate address parameter in [__]page_table_check_pud_clear()
>
> > config: riscv-randconfig-001-20250823 (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d26ea02060b1c9db751d188b2edb0059a9eb273d)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230551.qiEQu04P-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202508230551.qiEQu04P-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from arch/riscv/kernel/asm-offsets.c:8:
> > In file included from include/linux/mm.h:31:
> > In file included from include/linux/pgtable.h:6:
> > >> arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
> > 951 | page_table_check_pud_clear(mm, pud);
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
>
> Thanks, I added this:
It appears that this fix patch was applied to the wrong patch. The error
is about page_table_check_pud_check().
> --- a/arch/riscv/include/asm/pgtable.h~mm-page_table_check-reinstate-address-parameter-in-page_table_check_pud_set-fix
But this change is about page_table_check_pud_set(), so -next is now
broken in the opposite way
arch/riscv/include/asm/pgtable.h:951:42: error: too many arguments to function call, expected 2, have 3
951 | page_table_check_pud_clear(mm, address, pud);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~
include/linux/page_table_check.h:125:20: note: 'page_table_check_pud_clear' declared here
125 | static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
as it does not appear that e009b0f3187482a5756ff3b015cf30277cc1cfd9
is there.
> +++ a/arch/riscv/include/asm/pgtable.h
> @@ -948,7 +948,7 @@ static inline pud_t pudp_huge_get_and_cl
> {
> pud_t pud = __pud(atomic_long_xchg((atomic_long_t *)pudp, 0));
>
> - page_table_check_pud_clear(mm, pud);
> + page_table_check_pud_clear(mm, address, pud);
>
> return pud;
> }
> _
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
2025-08-25 20:07 ` Nathan Chancellor
@ 2025-08-25 22:38 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2025-08-25 22:38 UTC (permalink / raw)
To: Nathan Chancellor
Cc: kernel test robot, Rohan McLure, llvm, oe-kbuild-all,
Linux Memory Management List, Andrew Donnellan, Pasha Tatashin
On Mon, 25 Aug 2025 13:07:15 -0700 Nathan Chancellor <nathan@kernel.org> wrote:
> > > All errors (new ones prefixed by >>):
> > >
> > > In file included from arch/riscv/kernel/asm-offsets.c:8:
> > > In file included from include/linux/mm.h:31:
> > > In file included from include/linux/pgtable.h:6:
> > > >> arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2
> > > 951 | page_table_check_pud_clear(mm, pud);
> > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> >
> > Thanks, I added this:
>
> It appears that this fix patch was applied to the wrong patch. The error
> is about page_table_check_pud_check().
blah, OK, I'll drop everything.
Rohan, can you please refresh, retest, resend? Against
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm's mm-new branch,
preferably. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-25 22:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 21:30 [akpm-mm:mm-new 216/233] arch/riscv/include/asm/pgtable.h:951:36: error: too few arguments to function call, expected 3, have 2 kernel test robot
2025-08-22 22:09 ` Andrew Morton
2025-08-25 20:07 ` Nathan Chancellor
2025-08-25 22:38 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).