llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [sre-misc:thinkpad-t14s-x1e 43/95] drivers/media/platform/qcom/camss/camss-csiphy.c:821:59: warning: variable 'ret' is uninitialized when used here
@ 2025-08-29  9:01 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-08-29  9:01 UTC (permalink / raw)
  To: Bryan O'Donoghue; +Cc: llvm, oe-kbuild-all, Abel Vesa, Neil Armstrong

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-misc.git thinkpad-t14s-x1e
head:   9dd4135e4233415f1082b5addd91211121dad8af
commit: 3fa94f0306a4a32794678ae6022ae7b0fe768316 [43/95] media: qcom: camss: Add support for PHY API devices
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250829/202508291618.jy0uNieL-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250829/202508291618.jy0uNieL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508291618.jy0uNieL-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/qcom/camss/camss-csiphy.c:821:59: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     821 |                 dev_err(dev, "failed to get phy %s %d\n", csiphy->name, ret);
         |                                                                         ^~~
   include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err'
     154 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                                     ^~~~~~~~~~~
   drivers/media/platform/qcom/camss/camss-csiphy.c:808:9: note: initialize the variable 'ret' to silence this warning
     808 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +821 drivers/media/platform/qcom/camss/camss-csiphy.c

   794	
   795	/*
   796	 * msm_csiphy_subdev_init - Initialize CSIPHY device structure and resources
   797	 * @csiphy: CSIPHY device
   798	 * @res: CSIPHY module resources table
   799	 * @id: CSIPHY module id
   800	 *
   801	 * Return 0 on success or a negative error code otherwise
   802	 */
   803	int msm_csiphy_subdev_init(struct camss *camss,
   804				   struct csiphy_device *csiphy,
   805				   const struct camss_subdev_resources *res, u8 id)
   806	{
   807		struct device *dev = camss->dev;
   808		int ret;
   809	
   810		csiphy->camss = camss;
   811		csiphy->id = id;
   812		csiphy->cfg.combo_mode = 0;
   813		csiphy->res = &res->csiphy;
   814	
   815		snprintf(csiphy->name, ARRAY_SIZE(csiphy->name), "csiphy%d",
   816			 csiphy->id);
   817	
   818		csiphy->phy = devm_phy_get(dev, csiphy->name);
   819	
   820		if (IS_ERR(csiphy->phy)) {
 > 821			dev_err(dev, "failed to get phy %s %d\n", csiphy->name, ret);
   822			return PTR_ERR(csiphy->phy);
   823		}
   824	
   825		ret = phy_init(csiphy->phy);
   826		if (ret)
   827			dev_err(dev, "phy %s init fail %d\n", csiphy->name, ret);
   828	
   829		return ret;
   830	}
   831	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-29  9:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-29  9:01 [sre-misc:thinkpad-t14s-x1e 43/95] drivers/media/platform/qcom/camss/camss-csiphy.c:821:59: warning: variable 'ret' is uninitialized when used here kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).