From: Lee Jones <lee@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Simona Vetter <simona.vetter@ffwll.ch>,
"Daniel Thompson (RISCstar)" <danielt@kernel.org>
Subject: Re: [lee-backlight:for-backlight-next 14/14] drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c:718:25: error: call to undeclared function 'device_property_read_bool'; ISO C99 and later do not support implicit function declarations
Date: Wed, 17 Sep 2025 10:22:54 +0100 [thread overview]
Message-ID: <20250917092254.GD3893363@google.com> (raw)
In-Reply-To: <a555ff12-e0a9-4413-b90c-0b0fe8515723@suse.de>
On Wed, 17 Sep 2025, Thomas Zimmermann wrote:
> Hi,
>
> it seems impossible to catch all of those.
That's what it's there for. :)
> I'm going to send out a patch for
> the driver and get it upstream ASAP.
Sounds good, thanks.
> Am 16.09.25 um 22:29 schrieb kernel test robot:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next
> > head: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
> > commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2 [14/14] backlight: Do not include <linux/fb.h> in header file
> > config: x86_64-buildonly-randconfig-004-20250917 (https://download.01.org/0day-ci/archive/20250917/202509170410.RubSxK3n-lkp@intel.com/config)
> > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250917/202509170410.RubSxK3n-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202509170410.RubSxK3n-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > > > drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c:718:25: error: call to undeclared function 'device_property_read_bool'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> > 718 | ctx->flip_horizontal = device_property_read_bool(dev, "flip-horizontal");
> > | ^
> > drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c:718:25: note: did you mean 'drm_property_create_bool'?
> > include/drm/drm_property.h:271:22: note: 'drm_property_create_bool' declared here
> > 271 | struct drm_property *drm_property_create_bool(struct drm_device *dev,
> > | ^
> > > > drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c:748:61: error: array has incomplete element type 'const struct of_device_id'
> > 748 | static const struct of_device_id s6e88a0_ams427ap24_of_match[] = {
> > | ^
> > include/linux/device/driver.h:106:15: note: forward declaration of 'struct of_device_id'
> > 106 | const struct of_device_id *of_match_table;
> > | ^
> > 2 errors generated.
> >
> >
> > vim +/device_property_read_bool +718 drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> >
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 683
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 684 static int s6e88a0_ams427ap24_probe(struct mipi_dsi_device *dsi)
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 685 {
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 686 struct device *dev = &dsi->dev;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 687 struct s6e88a0_ams427ap24 *ctx;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 688 int ret;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 689
> > 3a21fd4c9065c3c Anusha Srivatsa 2025-05-29 690 ctx = devm_drm_panel_alloc(dev, struct s6e88a0_ams427ap24, panel,
> > 3a21fd4c9065c3c Anusha Srivatsa 2025-05-29 691 &s6e88a0_ams427ap24_panel_funcs,
> > 3a21fd4c9065c3c Anusha Srivatsa 2025-05-29 692 DRM_MODE_CONNECTOR_DSI);
> > 3a21fd4c9065c3c Anusha Srivatsa 2025-05-29 693 if (IS_ERR(ctx))
> > 3a21fd4c9065c3c Anusha Srivatsa 2025-05-29 694 return PTR_ERR(ctx);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 695
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 696 ret = devm_regulator_bulk_get_const(dev,
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 697 ARRAY_SIZE(s6e88a0_ams427ap24_supplies),
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 698 s6e88a0_ams427ap24_supplies,
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 699 &ctx->supplies);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 700 if (ret < 0)
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 701 return ret;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 702
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 703 ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 704 if (IS_ERR(ctx->reset_gpio))
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 705 return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 706 "Failed to get reset-gpios\n");
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 707
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 708 ctx->dsi = dsi;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 709 mipi_dsi_set_drvdata(dsi, ctx);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 710
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 711 dsi->lanes = 2;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 712 dsi->format = MIPI_DSI_FMT_RGB888;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 713 dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 714 MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_VIDEO_NO_HFP;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 715
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 716 ctx->panel.prepare_prev_first = true;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 717
> > e70d4f8e242bbc4 Jakob Hauser 2024-10-28 @718 ctx->flip_horizontal = device_property_read_bool(dev, "flip-horizontal");
> > e70d4f8e242bbc4 Jakob Hauser 2024-10-28 719
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 720 ret = s6e88a0_ams427ap24_register_backlight(ctx);
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 721 if (ret < 0)
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 722 return ret;
> > 5b67fdf1668fc37 Jakob Hauser 2024-10-28 723
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 724 drm_panel_add(&ctx->panel);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 725
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 726 ret = mipi_dsi_attach(dsi);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 727 if (ret < 0) {
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 728 dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 729 drm_panel_remove(&ctx->panel);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 730 return ret;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 731 }
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 732
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 733 return 0;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 734 }
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 735
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 736 static void s6e88a0_ams427ap24_remove(struct mipi_dsi_device *dsi)
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 737 {
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 738 struct s6e88a0_ams427ap24 *ctx = mipi_dsi_get_drvdata(dsi);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 739 int ret;
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 740
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 741 ret = mipi_dsi_detach(dsi);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 742 if (ret < 0)
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 743 dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 744
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 745 drm_panel_remove(&ctx->panel);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 746 }
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 747
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 @748 static const struct of_device_id s6e88a0_ams427ap24_of_match[] = {
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 749 { .compatible = "samsung,s6e88a0-ams427ap24" },
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 750 { /* sentinel */ },
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 751 };
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 752 MODULE_DEVICE_TABLE(of, s6e88a0_ams427ap24_of_match);
> > d5658db2a0768a7 Jakob Hauser 2024-10-28 753
> >
> > :::::: The code at line 718 was first introduced by commit
> > :::::: e70d4f8e242bbc4fd39f3a867dc3e33122d7e559 drm/panel: samsung-s6e88a0-ams427ap24: Add flip option
> >
> > :::::: TO: Jakob Hauser <jahau@rocketmail.com>
> > :::::: CC: Neil Armstrong <neil.armstrong@linaro.org>
> >
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-09-17 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 20:29 [lee-backlight:for-backlight-next 14/14] drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c:718:25: error: call to undeclared function 'device_property_read_bool'; ISO C99 and later do not support implicit function declarations kernel test robot
2025-09-17 6:52 ` Thomas Zimmermann
2025-09-17 6:55 ` Thomas Zimmermann
2025-09-17 9:23 ` Lee Jones
2025-09-17 9:22 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917092254.GD3893363@google.com \
--to=lee@kernel.org \
--cc=danielt@kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=simona.vetter@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox