From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC4053002D8 for ; Wed, 24 Sep 2025 11:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714704; cv=none; b=oLbcmnjmv27BO+DpvcjDfZCxV795FcvAmI5eXyaxrdWXZiHNsv1tc1oSbK5v9r0PGyHEyrJl1p+BnUUj+CktKnqYFg5E7Bi9lUo7uuIqCAiaLQ0HqhMQL03JG9YuepDGwBgL85f20kuLYtX0+lTo0/IoBrlE3kZXHBNQcSikww0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758714704; c=relaxed/simple; bh=ZEq5LCeeZxdZtY+a+kvZMIoWs2Mzj+sOmq7f1LtT1gE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nZfSKE/HAj2BM9dU5putJToQwoOch5kLdxIzE8MqAgKGoeoKhIERM/ZXPCvbLoqntLrSnXth/P6OUuRH0wrhcl0YynR1b8/Zm+xaL27blSNSoF1iyvcRjoBVLbSgTvKof8jCuRxr8mwUkU6jBJA4Qlh4XPE3NgxPWJOnRh/82rU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BS8EEYiC; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BS8EEYiC" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-267f0fe72a1so48519405ad.2 for ; Wed, 24 Sep 2025 04:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758714702; x=1759319502; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bd/jIJYyk1G6SYf0mNQVLBMDX4oiGoErfqkyMXn4+LQ=; b=BS8EEYiCL6nkNLTRkg+acxCEcZB6FxC6CgYsnuPj72VL/Jd/aUDqz2xhqiANmpto6L /JCeJXhL0Vwu+yuBV/zQDFXn/gQlHP4aA7IPOfD4gXoF5iRtJv1WdKw8RE6DMLjLuE0h uJKQ+9AdKqYJSFColzP+jkJ9w+SSbxBos9TAKXWi/F8bHgQh9I4gP0mkB0KZpHLNgLTI apm7MbtUQY/+rxR4q9WtvXYmNEMj7A8HfQZ6DttnxRXzWBkBVkBIqqCBi1VS5MayRWRl /T4M4XMarLq9u9O1kxk2SUYFhAeVTOH6+lAGWbtoq1VEyuuk60Vl1iUSchCmTSRLU54P mo9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758714702; x=1759319502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bd/jIJYyk1G6SYf0mNQVLBMDX4oiGoErfqkyMXn4+LQ=; b=UP4N+VkMFU5j9tBGDUquRAtF450BEBtmbaXN7A4BAqpphDPA6KN1tVWpPXrbwBYQXV Lcn3l8x2B3l6b50rl6Rqa0ERyEXMLTgQF5145ElN9FJ3t/MZKzZboDLI11KwP/5jjc5u KGZuqWgvwZ+m4cVZ9g/6H4hA6DUH9mePnhcJWP9axntbM3ee4AaHCe2TcFRqOdSXOQ1I JYayP3Hi+gjGEGGMbkvsM+de9dgNC9Y/6jzRLt2ikBZr0z1dBGw1JbS70E+lI7AOgyRs 3blh9V23dxqJHDCfHCog+qB7dxQFWzhigg947t1HpSulF8hGkVlXfHkp8K4j4CmUBK3k F/Dg== X-Forwarded-Encrypted: i=1; AJvYcCV7JkxCHT1IUW/jHrK7faeCDr/MQbjMgawPyoXvt3rYjQP2zsGZR+phIOcT4dfYBai/Am2n@lists.linux.dev X-Gm-Message-State: AOJu0YwF39nR6MW3SSINRfnExahAPv3VpONTEuKw2vo/gU2s+t2YTaaU I94WX9KG5WVnPI6ZfNZnSP4A4/2HcR4rXAxzUcGHQe6hCu7LdGZLshhW X-Gm-Gg: ASbGncs1C/rDXH5xyVlO6OmpnmgLax2LJA0j/QwO87D/6zwyJRn/89cvjqNdrI8vwRA 301aKyrESr5Z366GXAuE9Ivcq5IE4ojfNw1OvT36dsthgYJsgxpIeG6lLtTpzpWvY5x67sO3YnV 8WoKTE3mrVRbNW0CenDgktQsEKASbaD3THd/t7ScLRHcp6rjCZrr7yotwZZ3neIFTrDw5PlvRuE ZhKdYkwO1KaRCETkdD0KaHsJv6SQsajW+/0ZhUPM87vMDaVnu7FYddvrwhdOREqjuMrleArmeP+ 39HCWM251GwRfkKRBuJh+/YvCuBtvHXAEf6fYcMfJuXfdcKeIHTH0wk8WViIy9hVZiY/j+Q0+zF O+PfhLDKZaKl+D3m0gOKeMomgWw== X-Google-Smtp-Source: AGHT+IFwE8SCr0I5b3n0uusVXZp7apxLs7ITr185XQMEgGTCAgaUjk1MsH1EiRo81SdJuGldEPeMeA== X-Received: by 2002:a17:902:ca94:b0:276:b1ce:c094 with SMTP id d9443c01a7336-27cc543160bmr45804925ad.29.1758714701852; Wed, 24 Sep 2025 04:51:41 -0700 (PDT) Received: from localhost ([23.142.224.65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-269802df74asm189691615ad.94.2025.09.24.04.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 04:51:41 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v5 02/23] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint Date: Wed, 24 Sep 2025 19:50:45 +0800 Message-ID: <20250924115124.194940-3-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250924115124.194940-1-wangjinchao600@gmail.com> References: <20250924115124.194940-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The new arch_reinstall_hw_breakpoint() function can be used in an atomic context, unlike the more expensive free and re-allocation path. This allows callers to efficiently re-establish an existing breakpoint. Signed-off-by: Jinchao Wang Reviewed-by: Masami Hiramatsu (Google) --- arch/x86/include/asm/hw_breakpoint.h | 2 ++ arch/x86/kernel/hw_breakpoint.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/arch/x86/include/asm/hw_breakpoint.h b/arch/x86/include/asm/hw_breakpoint.h index aa6adac6c3a2..c22cc4e87fc5 100644 --- a/arch/x86/include/asm/hw_breakpoint.h +++ b/arch/x86/include/asm/hw_breakpoint.h @@ -21,6 +21,7 @@ struct arch_hw_breakpoint { enum bp_slot_action { BP_SLOT_ACTION_INSTALL, + BP_SLOT_ACTION_REINSTALL, BP_SLOT_ACTION_UNINSTALL, }; @@ -65,6 +66,7 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, int arch_install_hw_breakpoint(struct perf_event *bp); +int arch_reinstall_hw_breakpoint(struct perf_event *bp); void arch_uninstall_hw_breakpoint(struct perf_event *bp); void hw_breakpoint_pmu_read(struct perf_event *bp); void hw_breakpoint_pmu_unthrottle(struct perf_event *bp); diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c index 3658ace4bd8d..29c9369264d4 100644 --- a/arch/x86/kernel/hw_breakpoint.c +++ b/arch/x86/kernel/hw_breakpoint.c @@ -99,6 +99,10 @@ static int manage_bp_slot(struct perf_event *bp, enum bp_slot_action action) old_bp = NULL; new_bp = bp; break; + case BP_SLOT_ACTION_REINSTALL: + old_bp = bp; + new_bp = bp; + break; case BP_SLOT_ACTION_UNINSTALL: old_bp = bp; new_bp = NULL; @@ -187,6 +191,11 @@ int arch_install_hw_breakpoint(struct perf_event *bp) return arch_manage_bp(bp, BP_SLOT_ACTION_INSTALL); } +int arch_reinstall_hw_breakpoint(struct perf_event *bp) +{ + return arch_manage_bp(bp, BP_SLOT_ACTION_REINSTALL); +} + void arch_uninstall_hw_breakpoint(struct perf_event *bp) { arch_manage_bp(bp, BP_SLOT_ACTION_UNINSTALL); -- 2.43.0