From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C86B258ECB for ; Tue, 30 Sep 2025 02:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200332; cv=none; b=mWsuPLHmSN0TOe5j+PyAOzVWYQSmyJbhiz8MqGNOc53WuRHBATCZQvv1mrsYFve0RrTMLEpIZs6/3OGEeUPniThAyfvgI4/H333hkDhJRB3pANrV/GW4eB9sPGAWRD5DVfvYEuyHmH4LL8itr90eeRDgDI04F/XjanGY/+pDl7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200332; c=relaxed/simple; bh=Sl2YI7Td/C9YkkJpnWkOlkyn4hvpDBvdNr6f7stAoSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GRAK1qHQXd4SddmclhZlh0+CUZ7XKTnhRPeHYP1rMmek2aQoSv1JLgti1NdwxK/LGmtLkGCdU+If4pjTPZQtqxY2LIfvSOlPpXyEGT4mKbYP4ohtIR9gc5HmyQORsdLc4chJuMYprmDrlzk+clAlXR5DmT3qHNkMqjKWwCAghcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PcGgCAPx; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PcGgCAPx" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-782a77b5ec7so1927912b3a.1 for ; Mon, 29 Sep 2025 19:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759200329; x=1759805129; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sX4DcHmKN6k6jLli4BcDyPNAsEAGb3ORwL+dRbW7euA=; b=PcGgCAPxGzga4zOyZ3BEoR33eM0I+3hoIZbKPbpYzRtYKggrydsIws8+Hr8v/6zowg sxllFRN6WZLzgtRjlgaoZlCeNMXprvSLvGPoeMyYOpI71uCqMjo7BLlzcYVKkVD4TVHX WF2zFnBf7vB+VaOkAPtgb/WZYfAjsFbTHpY546cbJL+PE4iWtpZghE330iqx3/3Ah6AU ywbU++7q10TNjgnF/ro4/b4QTSl6D3nR2pyJ18iockXHYAfcD8prNa7i/dRqvFTVMOgj rIuJEfKUppjVy5inCpCFdFiqg9Rnn13EilcRi7Te/A31bovmQA38+3XX8Ybgd4AbV4+s E3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200329; x=1759805129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sX4DcHmKN6k6jLli4BcDyPNAsEAGb3ORwL+dRbW7euA=; b=eTyK7/K/+K/v7qaS4L1A1km+/Uc5OiUZpX4UNIAjshtDgiX8drjA/GpvT5tHwYYhxF bq6J88Bo6AKR0aQS4NATx2VzRr1ope3cpwurgAG5urgMDewm5ijAa3QkwRhmBKeuLGwd molOWaneZAj6Atwq31MZaTOjCqrMF0FGh44F+ihcGrjHndwGMy0v+2ZwOr7A2Iw+ub1d /L1C9b4std29Fpx8yEkf7V3RX6imI8RJfHqw+BogkW+7SN5aYGl83KIXtusj4zqFzcJk lQSI/qvWlfa5juQmi538qAWVaOVtu66H5+gHX7psYvWHm9vQ1nEMJMyR1i/Zh2Xy9M2I AYoA== X-Forwarded-Encrypted: i=1; AJvYcCWXPFq2VqmzERuU3tpJbQAC7NDbacadiJBdy59esF7zabyFE4odVCjqv5FlVfWCKJlxPvoH@lists.linux.dev X-Gm-Message-State: AOJu0Yz+jc0O0J/eMQVgQoaWyH58cZMjSe/vF8HKsfGCRaxGJIU3FN2w eRrOoaqD4XoZU3NR7Ckqhyq4YxuovbjEXRzckL1Nvtf9vZ122kAMY8fQ X-Gm-Gg: ASbGnctC2vC1wyAHGzb2lRoXr2MXGbQUILGHjpQzCuR3S8Yo+aNi6IF1E8Uz3iC7lLA hse/GvnQSb8w1IRjLXHlyS/OBJwfosvuAhNxnqp114+YWq0NCl+J1AOYdehOPrVFkHePfkwic1s SoYo8c+y1OwWjfuu8UdTWfW1IcR4c0gBT/5yX1rmcBBKsF+VNHUjFDzxiC49yCpo+wM8FUSRDQP GKczVHPgIzdQs10HkTOvMM9Csx7mpX1pSUyGQLXtASa3T1fGYD1dObK4G5tznwpAznAfbFTdQGI 6GA9CjkBbLRwM97uFjIxLCn3XQ+3Z+5iANbcMY+Fgedk6H1BkocIQs58zEnC534I5dDZUuZUfJm pf00t5R88ewZ8NkZvLy7kNiNE4ZNGMudrOJgzHQ4KbqIJxVu75wj5037pvDHrvz/Hv8XI9GZwkY d90kI8bjLKha8= X-Google-Smtp-Source: AGHT+IGTqTwXopd2ojQqxBEBkqI1vY+O5jS9ODQlBJjx1qTPcUYlj9RqM72R3p1od6/UyekDO+cXWA== X-Received: by 2002:a05:6a00:b53:b0:76e:885a:c332 with SMTP id d2e1a72fcca58-780fcf080d2mr23371738b3a.32.1759200329155; Mon, 29 Sep 2025 19:45:29 -0700 (PDT) Received: from localhost ([45.142.167.196]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-782e36c803fsm5830819b3a.38.2025.09.29.19.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 19:45:28 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v6 13/23] mm/ksw: add per-task ctx tracking Date: Tue, 30 Sep 2025 10:43:34 +0800 Message-ID: <20250930024402.1043776-14-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250930024402.1043776-1-wangjinchao600@gmail.com> References: <20250930024402.1043776-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Each task tracks its depth, stack pointer, and generation. A watchpoint is enabled only when the configured depth is reached, and disabled on function exit. The context is reset when probes are disabled, generation changes, or exit depth becomes inconsistent. Duplicate arming on the same frame is skipped. Signed-off-by: Jinchao Wang --- mm/kstackwatch/stack.c | 67 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/mm/kstackwatch/stack.c b/mm/kstackwatch/stack.c index 9f59f41d954c..e596ef97222d 100644 --- a/mm/kstackwatch/stack.c +++ b/mm/kstackwatch/stack.c @@ -12,6 +12,53 @@ static struct kprobe entry_probe; static struct fprobe exit_probe; +static bool probe_enable; +static u16 probe_generation; + +static void ksw_reset_ctx(void) +{ + struct ksw_ctx *ctx = ¤t->ksw_ctx; + + if (ctx->wp) + ksw_watch_off(ctx->wp); + + ctx->wp = NULL; + ctx->sp = 0; + ctx->depth = 0; + ctx->generation = READ_ONCE(probe_generation); +} + +static bool ksw_stack_check_ctx(bool entry) +{ + struct ksw_ctx *ctx = ¤t->ksw_ctx; + u16 cur_enable = READ_ONCE(probe_enable); + u16 cur_generation = READ_ONCE(probe_generation); + u16 cur_depth, target_depth = ksw_get_config()->depth; + + if (!cur_enable) { + ksw_reset_ctx(); + return false; + } + + if (ctx->generation != cur_generation) + ksw_reset_ctx(); + + if (!entry && !ctx->depth) { + ksw_reset_ctx(); + return false; + } + + if (entry) + cur_depth = ctx->depth++; + else + cur_depth = --ctx->depth; + + if (cur_depth == target_depth) + return true; + else + return false; +} + static int ksw_stack_prepare_watch(struct pt_regs *regs, const struct ksw_config *config, ulong *watch_addr, u16 *watch_len) @@ -26,10 +73,22 @@ static void ksw_stack_entry_handler(struct kprobe *p, struct pt_regs *regs, unsigned long flags) { struct ksw_ctx *ctx = ¤t->ksw_ctx; + ulong stack_pointer; ulong watch_addr; u16 watch_len; int ret; + stack_pointer = kernel_stack_pointer(regs); + + /* + * triggered more than once, may be in a loop + */ + if (ctx->wp && ctx->sp == stack_pointer) + return; + + if (!ksw_stack_check_ctx(true)) + return; + ret = ksw_watch_get(&ctx->wp); if (ret) return; @@ -50,6 +109,7 @@ static void ksw_stack_entry_handler(struct kprobe *p, struct pt_regs *regs, return; } + ctx->sp = stack_pointer; } static void ksw_stack_exit_handler(struct fprobe *fp, unsigned long ip, @@ -58,6 +118,8 @@ static void ksw_stack_exit_handler(struct fprobe *fp, unsigned long ip, { struct ksw_ctx *ctx = ¤t->ksw_ctx; + if (!ksw_stack_check_ctx(false)) + return; if (ctx->wp) { ksw_watch_off(ctx->wp); @@ -92,11 +154,16 @@ int ksw_stack_init(void) return ret; } + WRITE_ONCE(probe_generation, READ_ONCE(probe_generation) + 1); + WRITE_ONCE(probe_enable, true); + return 0; } void ksw_stack_exit(void) { + WRITE_ONCE(probe_enable, false); + WRITE_ONCE(probe_generation, READ_ONCE(probe_generation) + 1); unregister_fprobe(&exit_probe); unregister_kprobe(&entry_probe); } -- 2.43.0