From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE1922D792 for ; Tue, 30 Sep 2025 02:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200271; cv=none; b=NdK8pUq5yZ/6y/mJCuAXgS1WDP+DMuTIaq0G4L0O1awmCs0HG0BpSK6nHsMV1Bfd6wtD8lhalKc9jZtJzS3oXPkAtKtWID9jQ66yRq27SEGS4DR36/Bz280pc2ZBtll7gCvEPxkhtP5wHT8kYD3wCb9jJDLp5Xjqj8Kx2nILOFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200271; c=relaxed/simple; bh=ZEq5LCeeZxdZtY+a+kvZMIoWs2Mzj+sOmq7f1LtT1gE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kjzcg3hr38KW4urYSYF/dAqpyEyDw16eqPbvg3ExY9fnbSP3Pp1jV1dmdyfqmALzb6kIPd2n7mGHIEJje5CJWckuB8rFrZ+I7cN7kpvWCFciiV0ofKNX2erYGexQKkAQdxQyaTMspWjOCcyhzpwuy+OksQG+T1KqeV3nSVdIezE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EK0lBPGv; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EK0lBPGv" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b5506b28c98so3705281a12.1 for ; Mon, 29 Sep 2025 19:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759200268; x=1759805068; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bd/jIJYyk1G6SYf0mNQVLBMDX4oiGoErfqkyMXn4+LQ=; b=EK0lBPGvs6zFnn/jo8g77fkZYqrMvxvnt80orb10TUXxKQO+WylVw8VY5mh28USya2 mv5rwQvhpdEGb7Pw1clTYovLhtsrUTNddhS/uklFoVplAvw6LLyRv50HgcrXAKSJCJpz LsB3krHYa7NYSS65AT1JCVlQuIUyzjhi1BQlj2p0pytS3t0rOIsPNcNiQs95IhQoBr0p vdSbGrZ8coT1Fgrqof3cSwzwxggESTIk9FXeKJswBYV2TThGX3DzJVMzPRajKtlornJg pi19YtDfhBwAkBCMnOEaA1kFZpZLlB4wu81Udg4EC0V7TodDFbhymldrFM26T0E8npaZ miWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200268; x=1759805068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bd/jIJYyk1G6SYf0mNQVLBMDX4oiGoErfqkyMXn4+LQ=; b=dRjspY1f+8znu/ghm0oVHyl0uRFW2W7u6Wkkbrcn83QW2woiWQAb9u37X2NkF+A53U orz8rKzIsUBCuCd7e+XxS9SVblxMuHlGlsgNucbR8A1527xIdO78NCpIeoeibIaDMIz6 cXl3V8xP/zOmc0kSeVHF5zpBW9c69bBpt2yCthFIWgrt3WLpSgrZHI6M8BfBFg9OQeH9 DmuSoI7GzUKFaktdygqMk5KZQqFBmCZxcH3bFOcc8+vYNh7j6L7xcJAxVlFi/SRxa6nu pEvdNxxOMk8Got9palmxcHhiELoYkFhqh9gRcE1HB9FwOkHj/awJ44zg6hyPpt7VxQsR NMRA== X-Forwarded-Encrypted: i=1; AJvYcCX/AoxOpEzENeuU+OiLs7iXfqbMgExXI28AB+7D7bBaSg/fqXRqD0tNh95vAuYTNLKe1s/S@lists.linux.dev X-Gm-Message-State: AOJu0YyNVLGNYdvETrsjPMQBQWh4zy9/Zv4KFuu+vT5UOpmuje9KpDwf /EOytKscSE4jBYdhSVGLkVepJWq0i1A1yxCPkcf5u0Srhw2CUGbWxb55 X-Gm-Gg: ASbGncu9SmlyjvOcHhVHunUVVBQtNQVOlILqPd9kI5gDXeraWMgRUZyeURdoFbKYVjP UxH8NHSNcAVsnA4R7u//v11GRUODmU7UWsReUFjZX0gwTgLZBDQynsnE0cihT5grv33r7IZF6Fn TGuW5JRDJuGvKLxyno+I+kGA4M/PWUGq1xCzWtscGc09Ufg43ozA3Um8lwwLeMIOMJu46z9akyQ kYr0y3hsqKXBUt8zTGrLHxyVXRHABcjaoTPQdPGHA/pjoRL9X4aqC3HdNXg0i/+q+XVM6f9u3Er lh5fUgKDSO/APRFdGmEKZierlLqUwsJdcggezIHpXCnY+0PoyUBDKaMaDaCyUMZ6ri3SjrnrK6S IiepVgWke8w7OL8t/x3mUt19E55zD1rkJQcNwWD3+cj9ZDofyqjuOfeS+1O6u4drp7JypcZnbJ2 2c X-Google-Smtp-Source: AGHT+IHMOcWUXY/HnXgeQLe6jbo4QIzPdgwdgujFPg5G7XU1dMaY5AtA37WyD38lOg5pTss5CR5fOg== X-Received: by 2002:a17:903:a8b:b0:27d:339c:4b0 with SMTP id d9443c01a7336-27ed4aa57f1mr154617195ad.35.1759200267317; Mon, 29 Sep 2025 19:44:27 -0700 (PDT) Received: from localhost ([45.142.167.196]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed66d43b8sm144778285ad.9.2025.09.29.19.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 19:44:26 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v6 02/23] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint Date: Tue, 30 Sep 2025 10:43:23 +0800 Message-ID: <20250930024402.1043776-3-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250930024402.1043776-1-wangjinchao600@gmail.com> References: <20250930024402.1043776-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The new arch_reinstall_hw_breakpoint() function can be used in an atomic context, unlike the more expensive free and re-allocation path. This allows callers to efficiently re-establish an existing breakpoint. Signed-off-by: Jinchao Wang Reviewed-by: Masami Hiramatsu (Google) --- arch/x86/include/asm/hw_breakpoint.h | 2 ++ arch/x86/kernel/hw_breakpoint.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/arch/x86/include/asm/hw_breakpoint.h b/arch/x86/include/asm/hw_breakpoint.h index aa6adac6c3a2..c22cc4e87fc5 100644 --- a/arch/x86/include/asm/hw_breakpoint.h +++ b/arch/x86/include/asm/hw_breakpoint.h @@ -21,6 +21,7 @@ struct arch_hw_breakpoint { enum bp_slot_action { BP_SLOT_ACTION_INSTALL, + BP_SLOT_ACTION_REINSTALL, BP_SLOT_ACTION_UNINSTALL, }; @@ -65,6 +66,7 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, int arch_install_hw_breakpoint(struct perf_event *bp); +int arch_reinstall_hw_breakpoint(struct perf_event *bp); void arch_uninstall_hw_breakpoint(struct perf_event *bp); void hw_breakpoint_pmu_read(struct perf_event *bp); void hw_breakpoint_pmu_unthrottle(struct perf_event *bp); diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c index 3658ace4bd8d..29c9369264d4 100644 --- a/arch/x86/kernel/hw_breakpoint.c +++ b/arch/x86/kernel/hw_breakpoint.c @@ -99,6 +99,10 @@ static int manage_bp_slot(struct perf_event *bp, enum bp_slot_action action) old_bp = NULL; new_bp = bp; break; + case BP_SLOT_ACTION_REINSTALL: + old_bp = bp; + new_bp = bp; + break; case BP_SLOT_ACTION_UNINSTALL: old_bp = bp; new_bp = NULL; @@ -187,6 +191,11 @@ int arch_install_hw_breakpoint(struct perf_event *bp) return arch_manage_bp(bp, BP_SLOT_ACTION_INSTALL); } +int arch_reinstall_hw_breakpoint(struct perf_event *bp) +{ + return arch_manage_bp(bp, BP_SLOT_ACTION_REINSTALL); +} + void arch_uninstall_hw_breakpoint(struct perf_event *bp) { arch_manage_bp(bp, BP_SLOT_ACTION_UNINSTALL); -- 2.43.0