From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22FA2BF3CF for ; Sun, 5 Oct 2025 21:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759699352; cv=none; b=ZG+VvVagbKcNbVOhQUb3BImWHHiJAx9pMX2mpYH4++Ec2xdaHFjsxbJW705Kc1m4d3zcSNGZrIdXJn3UHFDQgVKyzTPBFJysHEtGJAjpA1d6j8n6geXOvVzD5Mbzs9CAFqQkkVZU1kxTfQlhY7WrAbxIAyuNE4nkpm6bAgWslhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759699352; c=relaxed/simple; bh=CCQPc58TSvr0cy3nKc2lprmjbQNbCaQTJI1JHBO4fZk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=To6U1yFhXzvm9nrmS0Vkf6wTSvgPiQ7DIAWUCGVRchxsSM/1GqcYNko8aRLmTjCjCmfbOWCihr9FlJtHPYfEzaWDlaGJ/NNBJjpY3FgJ8ZmnqhS9khoBUmSVIS6SGoFxrq1zg6/ntpYAh+gpxodIFNGp2I0l/dZHAMNNcr326sM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WR7U7k5X; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WR7U7k5X" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-27eeb9730d9so43667665ad.0 for ; Sun, 05 Oct 2025 14:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759699349; x=1760304149; darn=lists.linux.dev; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=fDQxJshrzMcNiF4ov5sFxJSEj5wisWjGXrUgTQiuK7I=; b=WR7U7k5XhohMOBv7E7/xuVqhe/dyZzX5WIqAqKl25lOut0Gy89siAn2LKjlxjNbF6T 6DAfFS10VaXsvZBn9B+jWmxPpcMuMQwa/tzdDd0/xkzyEdzkHb4C0q/mvcRLSoOP42b+ PJuxPq+faiD3TwgkXfkEjBvv+ja4JJGc7mpgeFUY4wxDoelv46Ie1nHxxcvl6W+Jq7r0 GTKc28AR/SvwMyH1Epl79g3zxqrfOSBYZDSnXy5WMKWlepxAZPZ8RQSuODO0jThmGn+p HKLT5uk74jUl39QeLV3+vsGxdNnO2u0d3BPfSQLMjic9D6HZk+I9LPk1iRkS6+q50JWS tskA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759699349; x=1760304149; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fDQxJshrzMcNiF4ov5sFxJSEj5wisWjGXrUgTQiuK7I=; b=nIDS0qf31W6M1NUfqBnat1DB+W1xL8fOPMcpMOo3WvFSu6VrG/9p3/OW27p+zngrS2 ZUkL1Mx//R9R6jIP038GllE5P8dKT4gkLODbhGkeLKr2wVlMQdc2f+XEet6UgECL47QM CbOiBQ1gKxR6BtDmpCHFsmIGBucJH+m+ejKis1nnHP0AqP5QTWtA4mstbU2Ki3OzTkj/ V72IpN91HID95Y2jVF3kfWcjan8khngWTppjT3aRO7LehIqoqRUTRkhkpQzVVOvzaTFW yGE4ennZiVtRrbLmIB78PdxetPUmwQUnE1SGRGcz3XnJ1aQvYVDoBOIR9U4pJnSp1lcE fAKw== X-Forwarded-Encrypted: i=1; AJvYcCXXApixTl1ey1rF+GYoczQWus1oPtcV9+je6wDmOLR9i5HIsa+sDZlFS8f/tVuaRvkHwN1s@lists.linux.dev X-Gm-Message-State: AOJu0YyAaHXznhp0oI2/niujLq91UVYhLbaT/+B0ylbMfZKjw5w/lK7D ehaHXlY3z1kIKBZgGtJtyqc5XvGKIVb2RIAzPJ6HO7sLS2u+N++pv0L4If4O0Ce5qsGuMlAvpBH 84yzlIQT6Jg== X-Google-Smtp-Source: AGHT+IHNmdwNHNGJJio68vZQzxJW4gUw2wiEz4abGSKgXJDJaQ0VM0ja+fEKLhEkaSVx43BLmivRKC1zYmpG X-Received: from plps1.prod.google.com ([2002:a17:902:9881:b0:24c:966a:4a6b]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2c0c:b0:24b:25f:5f81 with SMTP id d9443c01a7336-28e9a574b99mr129613255ad.17.1759699349121; Sun, 05 Oct 2025 14:22:29 -0700 (PDT) Date: Sun, 5 Oct 2025 14:22:05 -0700 In-Reply-To: <20251005212212.2892175-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251005212212.2892175-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251005212212.2892175-5-irogers@google.com> Subject: [PATCH v7 04/11] perf dso: Support BPF programs in dso__read_symbol From: Ian Rogers To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Charlie Jenkins , Eric Biggers , "Masami Hiramatsu (Google)" , James Clark , Collin Funk , "Dr. David Alan Gilbert" , Li Huafei , Athira Rajeev , Stephen Brennan , Dmitry Vyukov , Alexandre Ghiti , Haibo Xu , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Song Liu Content-Type: text/plain; charset="UTF-8" Set the buffer to the code in the BPF linear info. This enables BPF JIT code disassembly by LLVM and capstone. Move the common but minimal disassmble_bpf_image call to disassemble_objdump so that it is only called after falling back to the objdump option. Similarly move the disassmble_bpf function to disassemble_objdump and rename to disassmble_bpf_libbfd to make it clearer that this support relies on libbfd. Signed-off-by: Ian Rogers --- tools/perf/util/disasm.c | 12 +++-- tools/perf/util/dso.c | 100 ++++++++++++++++++++++++++------------- tools/perf/util/libbfd.c | 4 +- tools/perf/util/libbfd.h | 6 +-- 4 files changed, 80 insertions(+), 42 deletions(-) diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c index a1240543c89c..e64902e520ab 100644 --- a/tools/perf/util/disasm.c +++ b/tools/perf/util/disasm.c @@ -1521,6 +1521,12 @@ static int symbol__disassemble_objdump(const char *filename, struct symbol *sym, struct child_process objdump_process; int err; + if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_PROG_INFO) + return symbol__disassemble_bpf_libbfd(sym, args); + + if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_IMAGE) + return symbol__disassemble_bpf_image(sym, args); + err = asprintf(&command, "%s %s%s --start-address=0x%016" PRIx64 " --stop-address=0x%016" PRIx64 @@ -1655,11 +1661,7 @@ int symbol__disassemble(struct symbol *sym, struct annotate_args *args) pr_debug("annotating [%p] %30s : [%p] %30s\n", dso, dso__long_name(dso), sym, sym->name); - if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_PROG_INFO) { - return symbol__disassemble_bpf(sym, args); - } else if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_IMAGE) { - return symbol__disassemble_bpf_image(sym, args); - } else if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND) { + if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND) { return SYMBOL_ANNOTATE_ERRNO__COULDNT_DETERMINE_FILE_TYPE; } else if (dso__is_kcore(dso)) { kce.addr = map__rip_2objdump(map, sym->start); diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 87d075942de6..0aed5c8691bd 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -1816,23 +1816,17 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg) return 0; } -const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename, - const struct map *map, const struct symbol *sym, - u8 **out_buf, u64 *out_buf_len, bool *is_64bit) +static const u8 *__dso__read_symbol(struct dso *dso, const char *symfs_filename, + u64 start, size_t len, + u8 **out_buf, u64 *out_buf_len, bool *is_64bit) { struct nscookie nsc; - u64 start = map__rip_2objdump(map, sym->start); - u64 end = map__rip_2objdump(map, sym->end); - int fd, count; - u8 *buf = NULL; - size_t len; + int fd; + ssize_t count; struct find_file_offset_data data = { .ip = start, }; - - *out_buf = NULL; - *out_buf_len = 0; - *is_64bit = false; + u8 *code_buf = NULL; nsinfo__mountns_enter(dso__nsinfo(dso), &nsc); fd = open(symfs_filename, O_RDONLY); @@ -1840,28 +1834,70 @@ const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename, if (fd < 0) return NULL; - if (file__read_maps(fd, /*exe=*/true, find_file_offset, &data, is_64bit) == 0) - goto err; - - len = end - start; - buf = malloc(len); - if (buf == NULL) - goto err; - - count = pread(fd, buf, len, data.offset); + if (file__read_maps(fd, /*exe=*/true, find_file_offset, &data, is_64bit) == 0) { + close(fd); + return NULL; + } + code_buf = malloc(len); + if (code_buf == NULL) { + close(fd); + return NULL; + } + count = pread(fd, code_buf, len, data.offset); close(fd); - fd = -1; + if ((u64)count != len) { + free(code_buf); + return NULL; + } + *out_buf = code_buf; + *out_buf_len = len; + return code_buf; +} - if ((u64)count != len) - goto err; +/* + * Read a symbol into memory for disassembly by a library like capstone of + * libLLVM. If memory is allocated out_buf holds it. + */ +const u8 *dso__read_symbol(struct dso *dso, const char *symfs_filename, + const struct map *map, const struct symbol *sym, + u8 **out_buf, u64 *out_buf_len, bool *is_64bit) +{ + u64 start = map__rip_2objdump(map, sym->start); + u64 end = map__rip_2objdump(map, sym->end); + size_t len = end - start; - *out_buf = buf; - *out_buf_len = len; - return buf; + *out_buf = NULL; + *out_buf_len = 0; + *is_64bit = false; -err: - if (fd >= 0) - close(fd); - free(buf); - return NULL; + if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_IMAGE) { + /* + * Note, there is fallback BPF image disassembly in the objdump + * version but it currently does nothing. + */ + return NULL; + } + if (dso__binary_type(dso) == DSO_BINARY_TYPE__BPF_PROG_INFO) { +#ifdef HAVE_LIBBPF_SUPPORT + struct bpf_prog_info_node *info_node; + struct perf_bpil *info_linear; + + *is_64bit = sizeof(void *) == sizeof(u64); + info_node = perf_env__find_bpf_prog_info(dso__bpf_prog(dso)->env, + dso__bpf_prog(dso)->id); + if (!info_node) { + errno = SYMBOL_ANNOTATE_ERRNO__BPF_MISSING_BTF; + return NULL; + } + info_linear = info_node->info_linear; + assert(len <= info_linear->info.jited_prog_len); + *out_buf_len = len; + return (const u8 *)(uintptr_t)(info_linear->info.jited_prog_insns); +#else + pr_debug("No BPF program disassembly support\n"); + return NULL; +#endif + } + return __dso__read_symbol(dso, symfs_filename, start, len, + out_buf, out_buf_len, is_64bit); } diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c index 09a0eeb78a1a..01147fbf73b3 100644 --- a/tools/perf/util/libbfd.c +++ b/tools/perf/util/libbfd.c @@ -448,8 +448,8 @@ int libbfd_filename__read_debuglink(const char *filename, char *debuglink, return err; } -int symbol__disassemble_bpf(struct symbol *sym __maybe_unused, - struct annotate_args *args __maybe_unused) +int symbol__disassemble_bpf_libbfd(struct symbol *sym __maybe_unused, + struct annotate_args *args __maybe_unused) { #ifdef HAVE_LIBBPF_SUPPORT struct annotation *notes = symbol__annotation(sym); diff --git a/tools/perf/util/libbfd.h b/tools/perf/util/libbfd.h index 7441e95f8ec0..e300f171d1bd 100644 --- a/tools/perf/util/libbfd.h +++ b/tools/perf/util/libbfd.h @@ -29,7 +29,7 @@ int libbfd__read_build_id(const char *filename, struct build_id *bid, bool block int libbfd_filename__read_debuglink(const char *filename, char *debuglink, size_t size); -int symbol__disassemble_bpf(struct symbol *sym, struct annotate_args *args); +int symbol__disassemble_bpf_libbfd(struct symbol *sym, struct annotate_args *args); #else // !defined(HAVE_LIBBFD_SUPPORT) #include "annotate.h" @@ -72,8 +72,8 @@ static inline int libbfd_filename__read_debuglink(const char *filename __always_ return -1; } -static inline int symbol__disassemble_bpf(struct symbol *sym __always_unused, - struct annotate_args *args __always_unused) +static inline int symbol__disassemble_bpf_libbfd(struct symbol *sym __always_unused, + struct annotate_args *args __always_unused) { return SYMBOL_ANNOTATE_ERRNO__NO_LIBOPCODES_FOR_BPF; } -- 2.51.0.618.g983fd99d29-goog