From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22EA2561C2 for ; Tue, 7 Oct 2025 16:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759855127; cv=none; b=OguDem+rrhrXOr0FLa6LM4F/oiSbOq19j5JWyJthH0QiGdn9vsZ28V1O6myWAYkI9WG8jfnNseiCRzrmX3gySx5C6vD4UvaiZYapv+c1YSJ/oc4wL6TV2IbIU4ZeBEYJbaFZ9nGVsNMFW/q4WNznlxPxNo2Owo6oFzBeDidT/bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759855127; c=relaxed/simple; bh=Iz+x78HLYSZaQpNLm3kCHEGGKMwxMagiRtN4S/z3TNU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=R8wraw8i9HWg4gD11dtZDrtDUC9O45vNHdcusAJu7Ff8KOsa1n32fAOy9ern/ABTvYZRD4104dmXnKznVuOQGGlj2BDZUzc4AHPvPjIYpDw2RDEJXPw8ewDDtfNuLrFljFSM/0ubwyfsGYI5329hgz8Dj5rET2H7MLIycU6eNKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EA5fcc81; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EA5fcc81" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2681623f927so58601115ad.0 for ; Tue, 07 Oct 2025 09:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759855125; x=1760459925; darn=lists.linux.dev; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=A0ywbA7sIthMk8Bw7nASVIQCHDtkv+Fy+F9l75lqBYY=; b=EA5fcc81fo3cvKCaZJ0dr/5Kpkax72DF1brdKigMIURgzPuFvmOjfEB9EeyMJHdD+I LGKAdD1lZuuW7t3FnjcJjS9f2frM8yHJCu2tWHkfrVXGrOZmcdCVf6ymQfgeapASpcxI ps1wYYu1WNEM39oJj7VUIkEZVjduUJ2ogiLz+cFAUrdLKAfYgc1li8LBMo+gAD8O+rsj LPrq7dcY6eawo10HCJ+z1Expbo05AFVTQ9aL0IsIH2qcLVVCEXf4OlfEclgF3gPRtk7y 2GRRRedb/gEQL00FcfQehGfX+PboiFvjq832uDyPGUzZtKCwTsv+7zA8Q6Xf0rD9QnJ/ sDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759855125; x=1760459925; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A0ywbA7sIthMk8Bw7nASVIQCHDtkv+Fy+F9l75lqBYY=; b=SAXHjc/seQXMUURXjKSb2uMq/Ri2jaos69vQUBiTlZ6LTKPxFOtL8EWHeQmzlUJ5Co kJ5SUsHuJgLdu9QnZKUG5bRIeTYNkgKOU2PFpCSu6351tYPtJRc0+nakmL/maFh6OjVD Z1LRpaW9kN/qmayZMnzO9e0cwWNdofQQcYcVLYe/pXlNX1LZ1YBePFWXIXPZ/yb54usC FmzCtnb5/xIi4sRkNmBXNSfNwRheJ3Mi9qaRtbWRWM3Gzk8UhYFBjR9wDMYi6SHJQSGR L4tWB0EZcbiazzD9Yn6AebJ8rHWidESNUF9IEsnIR+njFkYgVsvHxUm6bgG3v+5u+MtC t9tA== X-Forwarded-Encrypted: i=1; AJvYcCXaxY/aGsosEaAuOuxOY+zEB8WHwr/C4SMBSvU5HUbVLxuIhxTSxosgDg2ZPkMdccwjLWa4@lists.linux.dev X-Gm-Message-State: AOJu0YzxsRJZDj5P01x85pCjQ2J09oxdm+1oaiPkVL7Rq38Jm9nBZWiH 3GDiKahuzlEFk/teq3m3/A8V6Gt9rLbrHyEEzPud/v1vJI41+nVWXUj+dPYWvnta+E3hLf87b4b PD0LH+38Ucw== X-Google-Smtp-Source: AGHT+IF5Gg026PMBc+wmeeoFlHQXhDUm7S6G6MprWABukRZeRHmcK3qyq3gJFr7xHIHnJj5SArS8h4iGYEyu X-Received: from plrt19.prod.google.com ([2002:a17:902:b213:b0:267:d801:ca2f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:8cc:b0:24c:9a51:9a33 with SMTP id d9443c01a7336-2902723c258mr3999935ad.22.1759855125193; Tue, 07 Oct 2025 09:38:45 -0700 (PDT) Date: Tue, 7 Oct 2025 09:38:32 -0700 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251007163835.3152881-1-irogers@google.com> Subject: [PATCH v8 0/3] Capstone/llvm dlopen support From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Charlie Jenkins , "Masami Hiramatsu (Google)" , James Clark , Collin Funk , Dmitry Vyukov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Linking against libcapstone and libLLVM can be a significant increase in dependencies and file size if building statically. The dependencies are also quite cumbersome if bringing perf into a distribution. For something like `perf record` the disassembler and addr2line functionality of libcapstone and libLLVM won't be used. These patches support dynamically loading these libraries using dlopen and then calling the appropriate functions found using dlsym. Using dlopen allows libcapstone and libLLVM to be installed separately to perf and when that's done the performance will improve as separate commands for objdump and addr2line won't be invoked. The patch series adds perf_ variants of the capstone/llvm functions that will either directly call the function or (NO_CAPSTONE=1 and NO_LIBLLVM=1 cases) use dlopen/dlsym to discover and then call the function. To support the function signatures when HAVE_LIBCAPSTONE_SUPPORT and HAVE_LIBLLVM_SUPPORT aren't defined prototypes generated using pahole are given. This avoids requiring libcapstone or libLLVM for the sake of the header files. It also avoids having a build where neither dlopen or dynamic linking against libcapstone or libLLVM is supported. There are other possibilities in how to organize this, but the chosen approach was done so for the simplicity and cleanliness of the code. The addr2line LLVM functionality is written in C++. To avoid linking against libLLVM for this, a new LIBLLVM_DYNAMIC option is added where the C++ code with the libLLVM dependency will be built into a libperf-llvm.so and that dlsym-ed and called against. Ideally LLVM would extend their C API to avoid this. v8: Rebase down to 3 patches. Update commit and cover messages. v7: Refactor now the first 5 patches, that largely moved code around, have landed. Move the dlopen code to the end of the series so that the first 8 patches can be picked improving capstone/LLVM support without adding the dlopen code. Rename the cover letter and disassembler cleanup patches. v6: Refactor the libbfd along with capstone and LLVM, previous patch series had tried to avoid this by just removing the deprecated BUILD_NONDISTRO code. Remove the libtracefs removal into its own patch. v5: Rebase and comment typo fix. v4: Rebase and addition of a patch removing an unused struct variable. v3: Add srcline addr2line fallback trying LLVM first then forking a process. This came up in conversation with Steinar Gunderson . Tweak the cover letter message to try to address Andi Kleen's feedback that the series doesn't really achieve anything. v2: Add mangling of the function names in libperf-llvm.so to avoid potential infinite recursion. Add BPF JIT disassembly support to LLVM and capstone. Add/rebase the BUILD_NONDISTRO cleanup onto the series from: https://lore.kernel.org/lkml/20250111202851.1075338-1-irogers@google.com/ Some other minor additional clean up. Ian Rogers (3): perf capstone: Support for dlopen-ing libcapstone.so perf llvm: Support for dlopen-ing libLLVM.so perf llvm: Mangle libperf-llvm.so function names tools/perf/Makefile.config | 13 ++ tools/perf/Makefile.perf | 24 ++- tools/perf/tests/make | 2 + tools/perf/util/Build | 2 +- tools/perf/util/capstone.c | 285 +++++++++++++++++++++++++---- tools/perf/util/llvm-c-helpers.cpp | 120 +++++++++++- tools/perf/util/llvm-c-helpers.h | 24 ++- tools/perf/util/llvm.c | 273 ++++++++++++++++++++++++--- 8 files changed, 660 insertions(+), 83 deletions(-) -- 2.51.0.618.g983fd99d29-goog