From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 343EE2EA177 for ; Thu, 9 Oct 2025 10:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007491; cv=none; b=ItqHvdkj+XnvmxzL3xqE3g/ADgSJ3u1ps14N2rSdfIDLLd1ro5pQFn2aA+EZHBekVDtz+714beR/EOWB7P9OSCtx1FXBZObWn3+8mlJIvgD2cpugesaXdbOYxmBKLOB6LtZGE8fpPXx//omyitYuMbyLRbuVO6UuD8eKP2EjqHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007491; c=relaxed/simple; bh=jb47W2mefivkhEZpeuyQPhjnJkRHRCJ2NscvV1apXQg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S7c6ix17Oy1itkulGUZg8DOpWjw+wkmHyqGJ6q+VmOsA++pyuH36IeKwIJksS+q2CmOLPjtD5XTaaI2K3PpwhIYRXIWVD31y4Pr2DgDelP7ffyIPOTMdKE6DPOqdRV93MLgFSsUq+Gea4sN8ueocnjRBZG450PHhCjFi21HzrxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ScG/GoHC; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ScG/GoHC" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-279e2554b6fso6014245ad.2 for ; Thu, 09 Oct 2025 03:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760007487; x=1760612287; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kFRia/GHfKKxxNt0IUc2kN+EVm0fmr2Lz8hq8oGCXGU=; b=ScG/GoHCoYc4umNIAhxDIc/emo+Khq2luIp2+3Ec5+eB1IC3gm0jowlsiiN0sOnOsX 9PvbwdKpPVxgyJ8iVFxbGnifUzsIzoZlxJuCNnv4BqQagbSyDg0OzVWT89dvqX/iVZ/o YPW12T6feE2UcWnL9MEgia03P+Xn7hbPfhehPLCqQsUD1E724kA8hIGG2vSNq4+qzmFw 1+/q8moqqepJWMKTSeHdhqIPPfDPrp9lmrOeUQvdod9G1DLpdiirPb3zCXtegZv+5xFn vImx9g1z5D22d11eSRxoQ0p9OsoUz1c13uIdhEmfV1xkAFlDTbJQTa5adRmsyjpwHfOO XoYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760007487; x=1760612287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFRia/GHfKKxxNt0IUc2kN+EVm0fmr2Lz8hq8oGCXGU=; b=A4BO59hWKxILfVi2ECWbTjjvUdVCTdpOyG0ckH0yYRLmHOe/na/AyOL/twxUZc89qx vCHw3B+Gc3htU8ePRh29SR0x2UxE3QV/V84Q5w7OacwqQdgh2UBQ2LUY3r94viOe4HKK eKp5lNTJJhOeN3b8G/l9YwFOH9FWu8tvhSFWmjYQO3d3m7BuYp8MI8to8mv++H+ZCMXB NEwK/cWeuXTLXUOOMfu3KkbKkcpxtxU6Q/h2VHwXGRR+tEDoujfn3ua0pVt2G7AaE258 BO7NMidI+YjIXFZ+wi1gKPtb/52IhTfcQv8D16X4DUlYQYG10D28Ybols7ke/l1QpTpF /fug== X-Forwarded-Encrypted: i=1; AJvYcCVs+xCmwTxu00h+kv05td7wDlTY6VCcfRox3UDBvn35koumopBKNG0MmAPZbB/p4xtOzw4f@lists.linux.dev X-Gm-Message-State: AOJu0Yy+WeuCvs7JhV1uyhSffnrftvv+wzxZ2u62b6X/FXXaohn4FZRy uPOfhqM0yBoaRhl5MLdjfftuMy9xLp3Qaz03k1bZHZROtHS/ed3to6PA X-Gm-Gg: ASbGnctNM80JJCthM91KG3kuRMSEwBweEpUYOHFcI/NT18TuIoWr+RE12UgnYLPQx/X +lrBIPFL/y97TGR0aYVtvatVIsUKNYxBFLuJ+vRFw5Md/Vk0Eb+7rrmzYLvicM5a7S5C4KP/Lqu OWO3A0uMfrLXVQNAu7VNB9PWuknqMPbBs3U4sztULDQyaQp6pyeuKEIoLXv+2KZP+dkaKvZuObZ sr9GBvSlJ7edTEKTZQg2sgVGu4u+vvILCTVr2Z2EjUaBn1iJSdTn9sPKJKolaaB2v8DIChF16sC XcCfB7O420TASYn1k3rdKJXY2blxGRLrYm518e2O+Py1DFST+E5euzu5IU9+Xb/z4WM8w1OlS5f LuOneBNUx+fGTl0J+ujhtt9KsPtXHy//xtJPE1nQ53j8duiP114DhssyVOPiJDfr7w9rSleo= X-Google-Smtp-Source: AGHT+IEEjbaanbFet6ymw5rLaG4ER6hS8x4PnRfmIgvGUILNfBcq5r77DsCvwjAQjB7po7/MVjYJ6Q== X-Received: by 2002:a17:902:e94e:b0:270:4aa8:2dcc with SMTP id d9443c01a7336-2902737c5e9mr92201005ad.19.1760007487406; Thu, 09 Oct 2025 03:58:07 -0700 (PDT) Received: from localhost ([45.142.165.62]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b51105813sm6628595a91.10.2025.10.09.03.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 03:58:06 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v7 15/23] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Thu, 9 Oct 2025 18:55:51 +0800 Message-ID: <20251009105650.168917-16-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009105650.168917-1-wangjinchao600@gmail.com> References: <20251009105650.168917-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow dynamic enabling/disabling of KStackWatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 60 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 898ebb2966fe..57628bace365 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -14,6 +14,43 @@ static struct ksw_config *ksw_config; static struct dentry *dbgfs_config; static struct dentry *dbgfs_dir; +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret = ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret = ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active = true; + + pr_info("start watching: %s\n", ksw_config->user_input); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active = false; + + pr_info("stop watching: %s\n", ksw_config->user_input); +} + struct param_map { const char *name; /* long name */ const char *short_name; /* short name (2 letters) */ @@ -117,8 +154,18 @@ static int ksw_parse_config(char *buf, struct ksw_config *config) static ssize_t ksw_dbgfs_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) { - return simple_read_from_buffer(buf, count, ppos, ksw_config->user_input, - ksw_config->user_input ? strlen(ksw_config->user_input) : 0); + const char *out; + size_t len; + + if (watching_active && ksw_config->user_input) { + out = ksw_config->user_input; + len = strlen(out); + } else { + out = "not watching\n"; + len = strlen(out); + } + + return simple_read_from_buffer(buf, count, ppos, out, len); } static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, @@ -133,6 +180,9 @@ static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, if (copy_from_user(input, buffer, count)) return -EFAULT; + if (watching_active) + ksw_stop_watching(); + input[count] = '\0'; strim(input); @@ -147,6 +197,12 @@ static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, return ret; } + ret = ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } -- 2.43.0