From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 147432E62D1 for ; Thu, 9 Oct 2025 10:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007458; cv=none; b=lHnEXeGGRisS0vKUyuaeG7xUNDUAqXpuyvAKsRsUKNRio5XnhW3rlgbYy5Uyg9zMR4l6dQw9TOnN3B5J7PFQu1PDu+f9JnhzN4ccfFlpHVsbVeLfT60EoodGNmjK1X+zSFTeM/TiXaLay+O3TrGG2TTU3QhNSB3fJcu+2llhC1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007458; c=relaxed/simple; bh=nvDFxA5+kzzGy254IQd/07joD3bGnycuza2xxZ+JqIE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oK5eKoQ/JpARq9oD/n//oaeUWeqzBFQY/JCZUwpaJRDANj2B29DWezHNlcANJo7Au+fquVq4FD0/SuXmozu9KRXbfSWIcOusnDN5R5nFCJaLLBOnSHIwTy+ydyy7c6L8oTdH4cnAhjfpA8umEJADdHYa49fHR/FBoOCyImHQFqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YwwS0cvg; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YwwS0cvg" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-33082aed31dso923336a91.3 for ; Thu, 09 Oct 2025 03:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760007455; x=1760612255; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5NW3rnfkFZjd7Zh69vJKiLybxjQ5f/0P49rVAWgM4UU=; b=YwwS0cvg6OfHsMNEoGa7uDXzelSCYk5abXNnHigowR0pDJsOU9PP6noAoZoON4Pfbk 2Pg3HGAXh9O3wg4xD7CEzDAoOhxwwZR6uDM+pzS5U7UW4IOrjsmo1mKjWxFQTjl1New7 ymY7cbREM/tf4AC7DFQ0s6W2wzPaJuPenfgAyk+hOaFVw7e91ZagW719UPuKSjaxflQz WPqj2/J2BthGJ5cOjgtN7RfPFM5p7ita7x9xaM5nLgN5MPa2NHh87x4XSNnGQrNbus2Q S4XxkLcJ+8Fiec6ifk1wZfBzaxbT79Rna4rnX7dQMwgFUKFiMCdO6U7xt0mR24B0g92l OoVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760007455; x=1760612255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5NW3rnfkFZjd7Zh69vJKiLybxjQ5f/0P49rVAWgM4UU=; b=aw0YkAYEtdNjijwURpnp719EFc9MfZsO8e/O4bIjjNJbn8Fozvnu/iV4/yF8ZhQO1G 4eBD6CrnNkCy3EPjUverEKcqPvYiy+pVn4eX3MAL4+KpwJaNNwOIJTkc9QJvQk8GErzb ggKXN+zekkT4uQo3cxRBathClC8pcy0HT7ADyIn3JW40L5GFvAYteaHuzeyXGhADsnuX 7zlwpV88/T9u3YstCAoIzNYLqzCWVhmA/Jj31m1zYCII+PZA+U6QARfqfI3AUpziAqlD BzcyiXDSyEQMIsL28LWycPhr29p37haXwQAxTQwf5GoHaDXWs0fSvzrbR7pw6jJd6Amx URMA== X-Forwarded-Encrypted: i=1; AJvYcCVt9EkJ2q194fid5G+2/pZVlvorI1WaxZ1dSQ59sS2Ss0r/3MPw4NXGNRYyj7vRyrP9sjs4@lists.linux.dev X-Gm-Message-State: AOJu0YzCHOKrHr3FMXBCipJBgXoNvsbC7chdns/Pip/I8ij2KQKCzLZJ LVfoqLjbDeghit/b47sDNKOafwtsQcTEN63CzCtoVDzWyaCv7tllN0KW X-Gm-Gg: ASbGnct/W/Q7NJIFcHkcdjP1EuvDrwEEpX6jocLx4H7rxKZ2uI8jF5ayzeQLGTlPbY0 LSlnZZTI/fgM/IichwvzPo5b6FdCecGLOsYf8OGuiM6VzKQ0xmMt5tY9wa+5GY4mxFK9H87sCvS 8DHdlp8XR/ZxzYE48nu6n9AxUsnaw9RnSRC5PCB7VkblmA0dGgv6u6HUdiQfdKtDv1IAoi7vKPg nUDVIJ86cnc6iTp7F07B4IJyu1JepMH+C4r43yTc+ELqbfq0NicGHqT8dNM03BcR1oS5DRs1nZK fY62z7jRo3wAoJOtwYSXCW4xu7UR8AmjPDgSOoNQnXJMSPjHaOG1tljyL73/62VAVm2deOjIobz He0rZWnSyelevyecBtigeh4Bvu+Vdm5+tiLlfdKQyhI8X8wx2eiXIAI/1kJ/J X-Google-Smtp-Source: AGHT+IFC13odZspSVqGRoywijSg0VBbkFQPkMFOijqia9KTXZKXwmvUEM0W1W0I7XOEEhq8lnQYbLg== X-Received: by 2002:a17:90b:2249:b0:32b:cafc:e339 with SMTP id 98e67ed59e1d1-33b5139c4f4mr8493028a91.36.1760007455151; Thu, 09 Oct 2025 03:57:35 -0700 (PDT) Received: from localhost ([45.142.165.62]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b510fc5e6sm6727834a91.6.2025.10.09.03.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 03:57:34 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v7 07/23] mm/ksw: add HWBP pre-allocation Date: Thu, 9 Oct 2025 18:55:43 +0800 Message-ID: <20251009105650.168917-8-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009105650.168917-1-wangjinchao600@gmail.com> References: <20251009105650.168917-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pre-allocate per-CPU hardware breakpoints at init with a place holder address, which will be retargeted dynamically in kprobe handler. This avoids allocation in atomic context. At most max_watch breakpoints are allocated (0 means no limit). Signed-off-by: Jinchao Wang --- mm/kstackwatch/kstackwatch.h | 13 +++++ mm/kstackwatch/watch.c | 97 ++++++++++++++++++++++++++++++++++++ 2 files changed, 110 insertions(+) diff --git a/mm/kstackwatch/kstackwatch.h b/mm/kstackwatch/kstackwatch.h index 983125d5cf18..4eac1be3b325 100644 --- a/mm/kstackwatch/kstackwatch.h +++ b/mm/kstackwatch/kstackwatch.h @@ -2,6 +2,9 @@ #ifndef _KSTACKWATCH_H #define _KSTACKWATCH_H +#include +#include +#include #include #define MAX_CONFIG_STR_LEN 128 @@ -32,4 +35,14 @@ struct ksw_config { // singleton, only modified in kernel.c const struct ksw_config *ksw_get_config(void); +/* watch management */ +struct ksw_watchpoint { + struct perf_event *__percpu *event; + struct perf_event_attr attr; + struct llist_node node; // for atomic watch_on and off + struct list_head list; // for cpu online and offline +}; +int ksw_watch_init(void); +void ksw_watch_exit(void); + #endif /* _KSTACKWATCH_H */ diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index cec594032515..1d8e24fede54 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -1 +1,98 @@ // SPDX-License-Identifier: GPL-2.0 +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include + +#include "kstackwatch.h" + +static LLIST_HEAD(free_wp_list); +static LIST_HEAD(all_wp_list); +static DEFINE_MUTEX(all_wp_mutex); + +static ulong holder; +bool panic_on_catch; +module_param(panic_on_catch, bool, 0644); +MODULE_PARM_DESC(panic_on_catch, "panic immediately on corruption catch"); + +static void ksw_watch_handler(struct perf_event *bp, + struct perf_sample_data *data, + struct pt_regs *regs) +{ + pr_err("========== KStackWatch: Caught stack corruption =======\n"); + pr_err("config %s\n", ksw_get_config()->user_input); + dump_stack(); + pr_err("=================== KStackWatch End ===================\n"); + + if (panic_on_catch) + panic("Stack corruption detected"); +} + +static int ksw_watch_alloc(void) +{ + int max_watch = ksw_get_config()->max_watch; + struct ksw_watchpoint *wp; + int success = 0; + int ret; + + init_llist_head(&free_wp_list); + + //max_watch=0 means at most + while (!max_watch || success < max_watch) { + wp = kzalloc(sizeof(*wp), GFP_KERNEL); + if (!wp) + return success > 0 ? success : -EINVAL; + + hw_breakpoint_init(&wp->attr); + wp->attr.bp_addr = (ulong)&holder; + wp->attr.bp_len = sizeof(ulong); + wp->attr.bp_type = HW_BREAKPOINT_W; + wp->event = register_wide_hw_breakpoint(&wp->attr, + ksw_watch_handler, wp); + if (IS_ERR((void *)wp->event)) { + ret = PTR_ERR((void *)wp->event); + kfree(wp); + return success > 0 ? success : ret; + } + llist_add(&wp->node, &free_wp_list); + mutex_lock(&all_wp_mutex); + list_add(&wp->list, &all_wp_list); + mutex_unlock(&all_wp_mutex); + success++; + } + + return success; +} + +static void ksw_watch_free(void) +{ + struct ksw_watchpoint *wp, *tmp; + + mutex_lock(&all_wp_mutex); + list_for_each_entry_safe(wp, tmp, &all_wp_list, list) { + list_del(&wp->list); + unregister_wide_hw_breakpoint(wp->event); + kfree(wp); + } + mutex_unlock(&all_wp_mutex); +} + +int ksw_watch_init(void) +{ + int ret; + + ret = ksw_watch_alloc(); + if (ret <= 0) + return -EBUSY; + + + return 0; +} + +void ksw_watch_exit(void) +{ + ksw_watch_free(); +} -- 2.43.0