From: Nathan Chancellor <nathan@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
"kernel test robot" <lkp@intel.com>,
"Kees Cook" <kees@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH] PCI: rcar-host: Avoid objtool no-cfi warning in rcar_pcie_probe()
Date: Tue, 14 Oct 2025 10:43:45 -0700 [thread overview]
Message-ID: <20251014174345.GA3062995@ax162> (raw)
In-Reply-To: <uebexl7d5gfjopb26gstftahu2ouab3ekonw4dzgegw3on5cwr@vqc2zmxiluvt>
On Tue, Oct 14, 2025 at 06:32:59PM +0530, Manivannan Sadhasivam wrote:
> TBH, I hate both of these CONFIG_OF checks as most of the controller drivers
> are just OF drivers. If we were to sprinkle CONFIG_OF check, then it has to be
> done in almost all controller drivers (except VMD, Hyper-V).
>
> If compiler is getting smart enough to detect these NULL invocations, then it
> may start to trigger the same issue for other OF APIs as well. So I'd prefer to
> have the OF dependency in Kconfig, sacrificing COMPILE_TEST on non-OF configs.
Alright, fair enough. I will send a v2 soon just adding the dependency
on OF.
Cheers,
Nathan
prev parent reply other threads:[~2025-10-14 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 18:25 [PATCH] PCI: rcar-host: Avoid objtool no-cfi warning in rcar_pcie_probe() Nathan Chancellor
2025-10-14 7:16 ` Geert Uytterhoeven
2025-10-14 8:32 ` Nathan Chancellor
2025-10-14 13:02 ` Manivannan Sadhasivam
2025-10-14 17:43 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014174345.GA3062995@ax162 \
--to=nathan@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kees@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox