Re: [PATCH v1 1/1] ceph: Amend checking to fix `make W=1` build breakage

andriy.shevchenko
2025-11-24T18:58:29Z

On Mon, Nov 24, 2025 at 06:49:26PM +0000, Viacheslav Dubeyko wrote:
> On Mon, 2025-11-24 at 20:43 +0200, andriy.shevchenko@linux.intel.com wrote:
> > On Mon, Nov 24, 2025 at 05:47:04PM +0000, Viacheslav Dubeyko wrote:
> > > On Mon, 2025-11-24 at 17:09 +0200, andriy.shevchenko@linux.intel.com wrote:
> > > > On Mon, Nov 10, 2025 at 08:42:13PM +0000, Viacheslav Dubeyko wrote:
> > > > > On Mon, 2025-11-10 at 21:43 +0200, andriy.shevchenko@linux.intel.com wrote:

...

> > > > > I think we can take the patch as it. It looks good. Probably, it makes sense to
> > > > > take a deeper look in the code on our side.
> > > > >
> > > > > Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
> > > >
> > > > Thanks, can this be applied? My builds are still broken.
> > >
> > > The patchset has been applied on testing branch already [1].
> >
> > Thanks for the information. The Linux Next still has no that branch in.
> > I recommend to write Stephen a message to include your testing branch or
> > something like that into Linux Next, so it will get more test coverage.
>
> It's not my personal branch. :) It's the branch that receives all new patches
> for CephFS kernel client and, usually, it is used for internal testing by Ceph
> team.

Exactly, that's why my proposal. I would not recommend to do the same for
a (semi-)private branches.

> Ilya gathers all patches from there and sends it upstream. So, we need to
> ping Ilya. :)

> > > Ilya, when are we planning to send this patchset upstream?
> >
> > > [1] https://github.com/ceph/ceph-client.git

--
With Best Regards,
Andy Shevchenko