Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags

Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags

[kernel test robot]

Hi David,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0c1c7a6a83feaf2cf182c52983ffe330ffb50280]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Heidelberg-via-B4-Relay/mm-vmalloc-warn-only-once-when-vmalloc-detect-invalid-gfp-flags/20251118-080722
base:   0c1c7a6a83feaf2cf182c52983ffe330ffb50280
patch link:    https://lore.kernel.org/r/20251118-only-one-vmalloc-v1-1-29f8eacb4605%40ixit.cz
patch subject: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags
config: hexagon-allnoconfig (https://download.01.org/0day-ci/archive/20251118/202511180916.NwW7M3B6-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 0bba1e76581bad04e7d7f09f5115ae5e2989e0d9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251118/202511180916.NwW7M3B6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511180916.NwW7M3B6-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/vmalloc.c:3938:5: error: expected ')'
    3938 |                   invalid_mask, &invalid_mask, flags, &flags);
         |                   ^
   mm/vmalloc.c:3937:2: note: to match this '('
    3937 |         WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
         |         ^
   include/asm-generic/bug.h:159:29: note: expanded from macro 'WARN_ONCE'
     159 |         DO_ONCE_LITE_IF(condition, WARN, 1, format)
         |                                    ^
   1 error generated.


vim +3938 mm/vmalloc.c

^1da177e4c3f41 Linus Torvalds        2005-04-16  3921  
7179b225631532 Vishal Moola (Oracle  2025-11-12  3922) /*
7179b225631532 Vishal Moola (Oracle  2025-11-12  3923)  * See __vmalloc_node_range() for a clear list of supported vmalloc flags.
7179b225631532 Vishal Moola (Oracle  2025-11-12  3924)  * This gfp lists all flags currently passed through vmalloc. Currently,
7179b225631532 Vishal Moola (Oracle  2025-11-12  3925)  * __GFP_ZERO is used by BPF and __GFP_NORETRY is used by percpu. Both drm
7179b225631532 Vishal Moola (Oracle  2025-11-12  3926)  * and BPF also use GFP_USER, which is GFP_KERNEL | __GFP_HARDWALL.
7179b225631532 Vishal Moola (Oracle  2025-11-12  3927)  */
7179b225631532 Vishal Moola (Oracle  2025-11-12  3928) #define GFP_VMALLOC_SUPPORTED (GFP_KERNEL | GFP_ATOMIC | GFP_NOWAIT |\
7179b225631532 Vishal Moola (Oracle  2025-11-12  3929) 				__GFP_NOFAIL |  __GFP_ZERO | __GFP_NORETRY |\
7179b225631532 Vishal Moola (Oracle  2025-11-12  3930) 				__GFP_HARDWALL)
7179b225631532 Vishal Moola (Oracle  2025-11-12  3931) 
7179b225631532 Vishal Moola (Oracle  2025-11-12  3932) static gfp_t vmalloc_fix_flags(gfp_t flags)
7179b225631532 Vishal Moola (Oracle  2025-11-12  3933) {
7179b225631532 Vishal Moola (Oracle  2025-11-12  3934) 	gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
7179b225631532 Vishal Moola (Oracle  2025-11-12  3935) 
7179b225631532 Vishal Moola (Oracle  2025-11-12  3936) 	flags &= GFP_VMALLOC_SUPPORTED;
bf791000a32caf David Heidelberg      2025-11-18  3937  	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
7179b225631532 Vishal Moola (Oracle  2025-11-12 @3938) 		  invalid_mask, &invalid_mask, flags, &flags);
7179b225631532 Vishal Moola (Oracle  2025-11-12  3939) 	return flags;
7179b225631532 Vishal Moola (Oracle  2025-11-12  3940) }
7179b225631532 Vishal Moola (Oracle  2025-11-12  3941) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki