* Re: [PATCH] leds: add aw91xxx driver
[not found] <tencent_1B2BC712D34FBE7DEB01320E665BEB2D8908@qq.com>
@ 2025-11-19 0:54 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-11-19 0:54 UTC (permalink / raw)
To: 429368636, lee
Cc: llvm, oe-kbuild-all, pavel, linus.walleij, brgl, linux-kernel,
linux-leds, linux-gpio, zhangxinyu
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.18-rc6 next-20251118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/429368636-qq-com/leds-add-aw91xxx-driver/20251117-175335
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/tencent_1B2BC712D34FBE7DEB01320E665BEB2D8908%40qq.com
patch subject: [PATCH] leds: add aw91xxx driver
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20251119/202511190823.KypHuQek-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511190823.KypHuQek-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511190823.KypHuQek-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/leds/leds-aw91xxx.c:653:23: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
653 | if (sscanf(buf, "%x %x", &databuf[0]) == 1)
| ~^
>> drivers/leds/leds-aw91xxx.c:1309:13: warning: no previous prototype for function 'aw91xxx_irq_func' [-Wmissing-prototypes]
1309 | irqreturn_t aw91xxx_irq_func(int irq, void *key_data)
| ^
drivers/leds/leds-aw91xxx.c:1309:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1309 | irqreturn_t aw91xxx_irq_func(int irq, void *key_data)
| ^
| static
>> drivers/leds/leds-aw91xxx.c:1395:6: warning: no previous prototype for function 'aw91xxx_int_work' [-Wmissing-prototypes]
1395 | void aw91xxx_int_work(struct work_struct *work)
| ^
drivers/leds/leds-aw91xxx.c:1395:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1395 | void aw91xxx_int_work(struct work_struct *work)
| ^
| static
drivers/leds/leds-aw91xxx.c:1425:6: warning: variable 'key_num' set but not used [-Wunused-but-set-variable]
1425 | int key_num = 0;
| ^
4 warnings generated.
vim +653 drivers/leds/leds-aw91xxx.c
645
646 static ssize_t
647 blink_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len)
648 {
649 unsigned int databuf[2];
650 struct led_classdev *led_cdev = dev_get_drvdata(dev);
651 struct aw91xxx *aw91xxx = container_of(led_cdev, struct aw91xxx, cdev);
652
> 653 if (sscanf(buf, "%x %x", &databuf[0]) == 1)
654 aw91xxx_led_blink(aw91xxx, databuf[0], 3);
655
656 return len;
657 }
658
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread