Re: [RFC PATCH 3/8] uprobe/x86: Add support to emulate mov reg,reg instructions

Re: [RFC PATCH 3/8] uprobe/x86: Add support to emulate mov reg,reg instructions

[kernel test robot]

Hi Jiri,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on bpf-next/net bpf-next/master bpf/master linus/master v6.18-rc6 next-20251119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiri-Olsa/uprobe-x86-Introduce-struct-arch_uprobe_xol-object/20251117-205911
base:   tip/x86/core
patch link:    https://lore.kernel.org/r/20251117124057.687384-4-jolsa%40kernel.org
patch subject: [RFC PATCH 3/8] uprobe/x86: Add support to emulate mov reg,reg instructions
config: x86_64-buildonly-randconfig-6003-20251120 (https://download.01.org/0day-ci/archive/20251120/202511201932.iuDaTkGE-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251120/202511201932.iuDaTkGE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511201932.iuDaTkGE-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/kernel/uprobes.c:1600:39: error: too few arguments to function call, expected 2, have 1
    1600 |         off_src = insn_get_modrm_reg_off(insn);
         |                   ~~~~~~~~~~~~~~~~~~~~~~     ^
   arch/x86/include/asm/insn-eval.h:23:5: note: 'insn_get_modrm_reg_off' declared here
      23 | int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs);
         |     ^                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/kernel/uprobes.c:1603:38: error: too few arguments to function call, expected 2, have 1
    1603 |         off_dst = insn_get_modrm_rm_off(insn);
         |                   ~~~~~~~~~~~~~~~~~~~~~     ^
   arch/x86/include/asm/insn-eval.h:22:5: note: 'insn_get_modrm_rm_off' declared here
      22 | int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs);
         |     ^                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +1600 arch/x86/kernel/uprobes.c

  1580	
  1581	#ifdef CONFIG_X86_64
  1582	/* Returns -ENOSYS if mov_xol_ops doesn't handle this insn */
  1583	static int mov_setup_xol_ops(struct arch_uprobe_xol *xol, struct insn *insn)
  1584	{
  1585		u8 opc1 = OPCODE1(insn);
  1586		int off_src, off_dst;
  1587	
  1588		/* validate opcode */
  1589		if (opc1 != 0x89)
  1590			return -ENOSYS;
  1591		if (insn->rex_prefix.nbytes != 1 ||
  1592		    insn->rex_prefix.bytes[0] != 0x48)
  1593			return -ENOSYS;
  1594	
  1595		/* only register operands */
  1596		if (X86_MODRM_MOD(insn->modrm.value) != 3)
  1597			return -ENOSYS;
  1598	
  1599		/* get registers offset */
> 1600		off_src = insn_get_modrm_reg_off(insn);
  1601		if (off_src < 0)
  1602			return off_src;
  1603		off_dst = insn_get_modrm_rm_off(insn);
  1604		if (off_dst < 0)
  1605			return off_dst;
  1606	
  1607		xol->mov.src = off_src;
  1608		xol->mov.dst = off_dst;
  1609		xol->mov.ilen = insn->length;
  1610		xol->ops = &mov_xol_ops;
  1611		return 0;
  1612	}
  1613	#else
  1614	static int mov_setup_xol_ops(struct arch_uprobe_xol *xol, struct insn *insn)
  1615	{
  1616		return -ENOSYS;
  1617	}
  1618	#endif
  1619	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki