Re: [PATCH v7 1/2] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

Re: [PATCH v7 1/2] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

[kernel test robot]

Hi Rob,

kernel test robot noticed the following build warnings:

[auto build test WARNING on remoteproc/rproc-next]
[also build test WARNING on linus/master v6.18-rc7 next-20251125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rob-Herring-Arm/remoteproc-qcom-Use-of_reserved_mem_region_-functions-for-memory-region/20251125-023031
base:   https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git rproc-next
patch link:    https://lore.kernel.org/r/20251124182751.507624-1-robh%40kernel.org
patch subject: [PATCH v7 1/2] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"
config: arm-defconfig (https://download.01.org/0day-ci/archive/20251125/202511252230.MRBagKGI-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251125/202511252230.MRBagKGI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511252230.MRBagKGI-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/remoteproc/st_remoteproc.c:158:3: warning: variable 'index' is incremented both in the loop header and in the loop body [-Wfor-loop-analysis]
     158 |                 index++;
         |                 ^
   drivers/remoteproc/st_remoteproc.c:127:39: note: incremented here
     127 |         for (int index = 0; index < entries; index++) {
         |                                              ^
   1 warning generated.


vim +/index +158 drivers/remoteproc/st_remoteproc.c

3df52ed7f269a2 Loic Pallardy     2019-01-10  117  
3df52ed7f269a2 Loic Pallardy     2019-01-10  118  static int st_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
3df52ed7f269a2 Loic Pallardy     2019-01-10  119  {
3df52ed7f269a2 Loic Pallardy     2019-01-10  120  	struct device *dev = rproc->dev.parent;
3df52ed7f269a2 Loic Pallardy     2019-01-10  121  	struct device_node *np = dev->of_node;
3df52ed7f269a2 Loic Pallardy     2019-01-10  122  	struct rproc_mem_entry *mem;
63a1074795248e Rob Herring (Arm  2025-11-24  123) 	int entries;
63a1074795248e Rob Herring (Arm  2025-11-24  124) 
63a1074795248e Rob Herring (Arm  2025-11-24  125) 	entries = of_reserved_mem_region_count(np);
63a1074795248e Rob Herring (Arm  2025-11-24  126) 
63a1074795248e Rob Herring (Arm  2025-11-24  127) 	for (int index = 0; index < entries; index++) {
63a1074795248e Rob Herring (Arm  2025-11-24  128) 		struct resource res;
63a1074795248e Rob Herring (Arm  2025-11-24  129) 		int ret;
63a1074795248e Rob Herring (Arm  2025-11-24  130) 
63a1074795248e Rob Herring (Arm  2025-11-24  131) 		ret = of_reserved_mem_region_to_resource(np, index, &res);
63a1074795248e Rob Herring (Arm  2025-11-24  132) 		if (ret)
63a1074795248e Rob Herring (Arm  2025-11-24  133) 			return ret;
3df52ed7f269a2 Loic Pallardy     2019-01-10  134  
3df52ed7f269a2 Loic Pallardy     2019-01-10  135  		/*  No need to map vdev buffer */
63a1074795248e Rob Herring (Arm  2025-11-24  136) 		if (!strstarts(res.name, "vdev0buffer")) {
3df52ed7f269a2 Loic Pallardy     2019-01-10  137  			/* Register memory region */
3df52ed7f269a2 Loic Pallardy     2019-01-10  138  			mem = rproc_mem_entry_init(dev, NULL,
63a1074795248e Rob Herring (Arm  2025-11-24  139) 						   (dma_addr_t)res.start,
63a1074795248e Rob Herring (Arm  2025-11-24  140) 						   resource_size(&res), res.start,
3df52ed7f269a2 Loic Pallardy     2019-01-10  141  						   st_rproc_mem_alloc,
3df52ed7f269a2 Loic Pallardy     2019-01-10  142  						   st_rproc_mem_release,
63a1074795248e Rob Herring (Arm  2025-11-24  143) 						   "%.*s",
63a1074795248e Rob Herring (Arm  2025-11-24  144) 						   strchrnul(res.name, '@') - res.name,
63a1074795248e Rob Herring (Arm  2025-11-24  145) 						   res.name);
3df52ed7f269a2 Loic Pallardy     2019-01-10  146  		} else {
3df52ed7f269a2 Loic Pallardy     2019-01-10  147  			/* Register reserved memory for vdev buffer allocation */
3df52ed7f269a2 Loic Pallardy     2019-01-10  148  			mem = rproc_of_resm_mem_entry_init(dev, index,
63a1074795248e Rob Herring (Arm  2025-11-24  149) 							   resource_size(&res),
63a1074795248e Rob Herring (Arm  2025-11-24  150) 							   res.start,
63a1074795248e Rob Herring (Arm  2025-11-24  151) 							   "vdev0buffer");
3df52ed7f269a2 Loic Pallardy     2019-01-10  152  		}
3df52ed7f269a2 Loic Pallardy     2019-01-10  153  
63a1074795248e Rob Herring (Arm  2025-11-24  154) 		if (!mem)
3df52ed7f269a2 Loic Pallardy     2019-01-10  155  			return -ENOMEM;
3df52ed7f269a2 Loic Pallardy     2019-01-10  156  
3df52ed7f269a2 Loic Pallardy     2019-01-10  157  		rproc_add_carveout(rproc, mem);
3df52ed7f269a2 Loic Pallardy     2019-01-10 @158  		index++;
3df52ed7f269a2 Loic Pallardy     2019-01-10  159  	}
3df52ed7f269a2 Loic Pallardy     2019-01-10  160  
3df52ed7f269a2 Loic Pallardy     2019-01-10  161  	return rproc_elf_load_rsc_table(rproc, fw);
3df52ed7f269a2 Loic Pallardy     2019-01-10  162  }
3df52ed7f269a2 Loic Pallardy     2019-01-10  163  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki