From: kernel test robot <lkp@intel.com>
To: Lachlan Hodges <lachlan.hodges@morsemicro.com>,
johannes@sipsolutions.net
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-wireless@vger.kernel.org, arien.judge@morsemicro.com,
Lachlan Hodges <lachlan.hodges@morsemicro.com>
Subject: Re: [PATCH wireless-next 3/3] wifi: mac80211: allow sharing identical chanctx for S1G interfaces
Date: Wed, 26 Nov 2025 05:08:43 +0800 [thread overview]
Message-ID: <202511260404.HHDhZkqk-lkp@intel.com> (raw)
In-Reply-To: <20251125025927.245280-4-lachlan.hodges@morsemicro.com>
Hi Lachlan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.18-rc7 next-20251125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lachlan-Hodges/wifi-cfg80211-include-s1g_primary_2mhz-when-sending-chandef/20251125-110125
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20251125025927.245280-4-lachlan.hodges%40morsemicro.com
patch subject: [PATCH wireless-next 3/3] wifi: mac80211: allow sharing identical chanctx for S1G interfaces
config: arm-randconfig-001-20251126 (https://download.01.org/0day-ci/archive/20251126/202511260404.HHDhZkqk-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251126/202511260404.HHDhZkqk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511260404.HHDhZkqk-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/mac80211/chan.c:671:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
671 | case NL80211_CHAN_WIDTH_20_NOHT:
| ^
net/mac80211/chan.c:671:2: note: insert 'break;' to avoid fall-through
671 | case NL80211_CHAN_WIDTH_20_NOHT:
| ^
| break;
1 warning generated.
vim +671 net/mac80211/chan.c
52363af3a9c989 Johannes Berg 2025-11-05 643
b72a455a2409fd Johannes Berg 2023-05-04 644 static void _ieee80211_change_chanctx(struct ieee80211_local *local,
d6c375095ade4e Mordechay Goodstein 2021-06-18 645 struct ieee80211_chanctx *ctx,
d6c375095ade4e Mordechay Goodstein 2021-06-18 646 struct ieee80211_chanctx *old_ctx,
6092077ad09ce8 Johannes Berg 2024-01-29 647 const struct ieee80211_chan_req *chanreq,
b72a455a2409fd Johannes Berg 2023-05-04 648 struct ieee80211_link_data *rsvd_for)
d6c375095ade4e Mordechay Goodstein 2021-06-18 649 {
6092077ad09ce8 Johannes Berg 2024-01-29 650 const struct cfg80211_chan_def *chandef = &chanreq->oper;
761748f001800d Johannes Berg 2024-01-29 651 struct ieee80211_chan_req ctx_req = {
761748f001800d Johannes Berg 2024-01-29 652 .oper = ctx->conf.def,
761748f001800d Johannes Berg 2024-01-29 653 .ap = ctx->conf.ap,
761748f001800d Johannes Berg 2024-01-29 654 };
761748f001800d Johannes Berg 2024-01-29 655 u32 changed = 0;
44b72ca8163b8c Ilan Peer 2020-12-06 656
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 657 /* 5/10 MHz not handled here */
44b72ca8163b8c Ilan Peer 2020-12-06 658 switch (chandef->width) {
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 659 case NL80211_CHAN_WIDTH_1:
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 660 case NL80211_CHAN_WIDTH_2:
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 661 case NL80211_CHAN_WIDTH_4:
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 662 case NL80211_CHAN_WIDTH_8:
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 663 case NL80211_CHAN_WIDTH_16:
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 664 /*
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 665 * mac80211 currently only supports sharing identical
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 666 * chanctx's for S1G interfaces.
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 667 */
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 668 if (ieee80211_chanreq_identical(&ctx_req, chanreq))
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 669 return;
ffaa1f7cd953b4 Lachlan Hodges 2025-11-25 670 WARN_ON(1);
44b72ca8163b8c Ilan Peer 2020-12-06 @671 case NL80211_CHAN_WIDTH_20_NOHT:
44b72ca8163b8c Ilan Peer 2020-12-06 672 case NL80211_CHAN_WIDTH_20:
44b72ca8163b8c Ilan Peer 2020-12-06 673 case NL80211_CHAN_WIDTH_40:
44b72ca8163b8c Ilan Peer 2020-12-06 674 case NL80211_CHAN_WIDTH_80:
44b72ca8163b8c Ilan Peer 2020-12-06 675 case NL80211_CHAN_WIDTH_80P80:
44b72ca8163b8c Ilan Peer 2020-12-06 676 case NL80211_CHAN_WIDTH_160:
5dca295dd76756 Ilan Peer 2022-02-14 677 case NL80211_CHAN_WIDTH_320:
44b72ca8163b8c Ilan Peer 2020-12-06 678 break;
44b72ca8163b8c Ilan Peer 2020-12-06 679 default:
44b72ca8163b8c Ilan Peer 2020-12-06 680 WARN_ON(1);
44b72ca8163b8c Ilan Peer 2020-12-06 681 }
44b72ca8163b8c Ilan Peer 2020-12-06 682
d6c375095ade4e Mordechay Goodstein 2021-06-18 683 /* Check maybe BW narrowed - we do this _before_ calling recalc_chanctx_min_def
d6c375095ade4e Mordechay Goodstein 2021-06-18 684 * due to maybe not returning from it, e.g in case new context was added
d6c375095ade4e Mordechay Goodstein 2021-06-18 685 * first time with all parameters up to date.
d6c375095ade4e Mordechay Goodstein 2021-06-18 686 */
b27512368591fc Johannes Berg 2024-06-12 687 ieee80211_chan_bw_change(local, old_ctx, false, true);
44b72ca8163b8c Ilan Peer 2020-12-06 688
761748f001800d Johannes Berg 2024-01-29 689 if (ieee80211_chanreq_identical(&ctx_req, chanreq)) {
52363af3a9c989 Johannes Berg 2025-11-05 690 _ieee80211_recalc_chanctx_min_def(local, ctx, rsvd_for, false);
d6c375095ade4e Mordechay Goodstein 2021-06-18 691 return;
d6c375095ade4e Mordechay Goodstein 2021-06-18 692 }
d6c375095ade4e Mordechay Goodstein 2021-06-18 693
761748f001800d Johannes Berg 2024-01-29 694 WARN_ON(ieee80211_chanctx_refcount(local, ctx) > 1 &&
761748f001800d Johannes Berg 2024-01-29 695 !cfg80211_chandef_compatible(&ctx->conf.def, &chanreq->oper));
d6c375095ade4e Mordechay Goodstein 2021-06-18 696
d34be4310cbe3a Evan Quan 2023-12-11 697 ieee80211_remove_wbrf(local, &ctx->conf.def);
d34be4310cbe3a Evan Quan 2023-12-11 698
b82730bf57b548 Johannes Berg 2024-01-29 699 if (!cfg80211_chandef_identical(&ctx->conf.def, &chanreq->oper)) {
b82730bf57b548 Johannes Berg 2024-01-29 700 if (ctx->conf.def.width != chanreq->oper.width)
761748f001800d Johannes Berg 2024-01-29 701 changed |= IEEE80211_CHANCTX_CHANGE_WIDTH;
b82730bf57b548 Johannes Berg 2024-01-29 702 if (ctx->conf.def.punctured != chanreq->oper.punctured)
b82730bf57b548 Johannes Berg 2024-01-29 703 changed |= IEEE80211_CHANCTX_CHANGE_PUNCTURING;
b82730bf57b548 Johannes Berg 2024-01-29 704 }
761748f001800d Johannes Berg 2024-01-29 705 if (!cfg80211_chandef_identical(&ctx->conf.ap, &chanreq->ap))
761748f001800d Johannes Berg 2024-01-29 706 changed |= IEEE80211_CHANCTX_CHANGE_AP;
d6c375095ade4e Mordechay Goodstein 2021-06-18 707 ctx->conf.def = *chandef;
761748f001800d Johannes Berg 2024-01-29 708 ctx->conf.ap = chanreq->ap;
d6c375095ade4e Mordechay Goodstein 2021-06-18 709
d6c375095ade4e Mordechay Goodstein 2021-06-18 710 /* check if min chanctx also changed */
52363af3a9c989 Johannes Berg 2025-11-05 711 changed |= __ieee80211_recalc_chanctx_min_def(local, ctx, rsvd_for,
52363af3a9c989 Johannes Berg 2025-11-05 712 false);
d34be4310cbe3a Evan Quan 2023-12-11 713
d34be4310cbe3a Evan Quan 2023-12-11 714 ieee80211_add_wbrf(local, &ctx->conf.def);
d34be4310cbe3a Evan Quan 2023-12-11 715
d6c375095ade4e Mordechay Goodstein 2021-06-18 716 drv_change_chanctx(local, ctx, changed);
55de908ab292c0 Johannes Berg 2012-07-26 717
761748f001800d Johannes Berg 2024-01-29 718 /* check if BW is wider */
b27512368591fc Johannes Berg 2024-06-12 719 ieee80211_chan_bw_change(local, old_ctx, false, false);
0aaffa9b969989 Johannes Berg 2010-05-05 720 }
d01a1e658606a0 Michal Kazior 2012-06-26 721
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2025-11-25 21:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20251125025927.245280-4-lachlan.hodges@morsemicro.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511260404.HHDhZkqk-lkp@intel.com \
--to=lkp@intel.com \
--cc=arien.judge@morsemicro.com \
--cc=johannes@sipsolutions.net \
--cc=lachlan.hodges@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox