From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB8936D50A; Mon, 1 Dec 2025 20:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621098; cv=none; b=Xl5KwARuBZTT0oMt9vqPNktvqoAKF3MNc1nkjzGs875Im2TvDy5PG1dkp+UNUzjkgcFLuVGDJ4YKvglOvhSjzYkzix642zMVZTWsTZSu6wdtkMHmSbg6uDEPLbLkYF5RRpItbg3R/7wKDT+gIjRFgAldjB4b0mYkue7PZd1VNXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621098; c=relaxed/simple; bh=FQ3pZ8DZew4MZtKz6TIyMvbg23wpdd3rgF3FO1enbqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ORhYgChDH5nvrHBAp0U1B6RWKYdqnE/IzpWLbAreYCR5SLjKrFZbKOs6VFGkY43MRPlKxHdlvaiF2/yct8LwjKIa2J6t8xT1BhN1W+Q6/00rLMhtdfo2FzOCJOeBlePEe/9xmn7bXFMNrEcyvZ0wy8uanpcFW84XdnVjbAEJCII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fiXF2nej; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fiXF2nej" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764621096; x=1796157096; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FQ3pZ8DZew4MZtKz6TIyMvbg23wpdd3rgF3FO1enbqU=; b=fiXF2nejv6MgXOCMRzg3NjZtPe5uwHAvNbO2dgC/7VGqAuujGLA5x8sp BmHhgQPI+Gj91J66jlDXBZ4nfEXHhsMX/+aZSAn5wTeOE5Zx/pOmz15zJ E8lTnFmJcHPXGBHH4wOQAmOX6NcJ755EzN383Gs4q3fVQ7EJlh3inLY98 1KPMiliLxnc0xGVwlkLzeb6AOFS5B1W0Aqdgn6P3ucU0tUphXg5Fujw3h kQEVz3WYAA86m1KGV/Z6H3Eb98xahH8t6hHnEq9eul/NV2FASYF8OPg+D g3/yxgTXtE0oOtndr2zV1xUDxlkcxkJ1DCMYtiqETytQ1shpPL0M/Nzdn g==; X-CSE-ConnectionGUID: Toz4L2p3RLa9EOU2MWhWog== X-CSE-MsgGUID: URO7ZmdNRQ+bPSGepRvrLg== X-IronPort-AV: E=McAfee;i="6800,10657,11630"; a="66651134" X-IronPort-AV: E=Sophos;i="6.20,241,1758610800"; d="scan'208";a="66651134" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 12:31:35 -0800 X-CSE-ConnectionGUID: czKx/aigQSSZF3PjaEUaBQ== X-CSE-MsgGUID: xzQ2aqJmTZuDmFPBG90uhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,241,1758610800"; d="scan'208";a="199298618" Received: from lkp-server01.sh.intel.com (HELO 4664bbef4914) ([10.239.97.150]) by orviesa005.jf.intel.com with ESMTP; 01 Dec 2025 12:31:35 -0800 Received: from kbuild by 4664bbef4914 with local (Exim 4.98.2) (envelope-from ) id 1vQAYV-0000000097N-3ijP; Mon, 01 Dec 2025 20:31:31 +0000 Date: Tue, 2 Dec 2025 04:31:20 +0800 From: kernel test robot To: Swaraj Gaikwad Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH RFC] mm/memblock: Fix reserve_mem allocation overlapping KHO scratch regions Message-ID: <202512020406.fLEkXsNR-lkp@intel.com> References: <20251130172939.574999-1-swarajgaikwad1925@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251130172939.574999-1-swarajgaikwad1925@gmail.com> Hi Swaraj, [This is a private test report for your RFC patch.] kernel test robot noticed the following build errors: [auto build test ERROR on 2178727587e1eaa930b8266377119ed6043067df] url: https://github.com/intel-lab-lkp/linux/commits/Swaraj-Gaikwad/mm-memblock-Fix-reserve_mem-allocation-overlapping-KHO-scratch-regions/20251130-200138 base: 2178727587e1eaa930b8266377119ed6043067df patch link: https://lore.kernel.org/r/20251130172939.574999-1-swarajgaikwad1925%40gmail.com patch subject: [PATCH RFC] mm/memblock: Fix reserve_mem allocation overlapping KHO scratch regions config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20251202/202512020406.fLEkXsNR-lkp@intel.com/config) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251202/202512020406.fLEkXsNR-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202512020406.fLEkXsNR-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/memblock.c:2692:18: error: use of undeclared identifier 'kho_scratch_cnt' 2692 | for (i = 0; i < kho_scratch_cnt; i++) { | ^ >> mm/memblock.c:2693:19: error: use of undeclared identifier 'kho_scratch' 2693 | scratch_start = kho_scratch[i].addr; | ^ mm/memblock.c:2694:17: error: use of undeclared identifier 'kho_scratch' 2694 | scratch_end = kho_scratch[i].addr + kho_scratch[i].size; | ^ mm/memblock.c:2694:39: error: use of undeclared identifier 'kho_scratch' 2694 | scratch_end = kho_scratch[i].addr + kho_scratch[i].size; | ^ 4 errors generated. vim +/kho_scratch_cnt +2692 mm/memblock.c 2627 2628 /* 2629 * Parse reserve_mem=nn:align:name 2630 */ 2631 static int __init reserve_mem(char *p) 2632 { 2633 phys_addr_t start, size, align, tmp; 2634 char *name; 2635 char *oldp; 2636 int len; 2637 2638 if (!p) 2639 return -EINVAL; 2640 2641 /* Check if there's room for more reserved memory */ 2642 if (reserved_mem_count >= RESERVE_MEM_MAX_ENTRIES) 2643 return -EBUSY; 2644 2645 oldp = p; 2646 size = memparse(p, &p); 2647 if (!size || p == oldp) 2648 return -EINVAL; 2649 2650 if (*p != ':') 2651 return -EINVAL; 2652 2653 align = memparse(p+1, &p); 2654 if (*p != ':') 2655 return -EINVAL; 2656 2657 /* 2658 * memblock_phys_alloc() doesn't like a zero size align, 2659 * but it is OK for this command to have it. 2660 */ 2661 if (align < SMP_CACHE_BYTES) 2662 align = SMP_CACHE_BYTES; 2663 2664 name = p + 1; 2665 len = strlen(name); 2666 2667 /* name needs to have length but not too big */ 2668 if (!len || len >= RESERVE_MEM_NAME_SIZE) 2669 return -EINVAL; 2670 2671 /* Make sure that name has text */ 2672 for (p = name; *p; p++) { 2673 if (!isspace(*p)) 2674 break; 2675 } 2676 if (!*p) 2677 return -EINVAL; 2678 2679 /* Make sure the name is not already used */ 2680 if (reserve_mem_find_by_name(name, &start, &tmp)) 2681 return -EBUSY; 2682 2683 /* Pick previous allocations up from KHO if available */ 2684 if (reserve_mem_kho_revive(name, size, align)) 2685 return 1; 2686 2687 phys_addr_t scratch_start, scratch_end; 2688 phys_addr_t curr_start_addr = 0; 2689 phys_addr_t alloc_end_addr = MEMBLOCK_ALLOC_ACCESSIBLE; 2690 unsigned int i; 2691 > 2692 for (i = 0; i < kho_scratch_cnt; i++) { > 2693 scratch_start = kho_scratch[i].addr; 2694 scratch_end = kho_scratch[i].addr + kho_scratch[i].size; 2695 alloc_end_addr = scratch_start; 2696 if (alloc_end_addr > curr_start_addr) { 2697 start = memblock_phys_alloc_range(size, align, curr_start_addr, alloc_end_addr); 2698 if (start) 2699 break; 2700 } 2701 curr_start_addr = scratch_end; 2702 } 2703 if (!start) 2704 return -ENOMEM; 2705 2706 reserved_mem_add(start, size, name); 2707 2708 return 1; 2709 } 2710 __setup("reserve_mem=", reserve_mem); 2711 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki