From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] Revert "scripts/clang-tools: Handle included .c files in gen_compile_commands"
Date: Thu, 18 Dec 2025 09:13:36 +0900 [thread overview]
Message-ID: <20251218001336.GA2451437@ax162> (raw)
In-Reply-To: <20251217-revert-scripts-clang-rools-handle-included-c-files-v1-1-def5651446da@kernel.org>
On Wed, Dec 17, 2025 at 08:13:43PM +0100, Nicolas Schier wrote:
> This reverts commit 9362d34acf91a706c543d919ade3e651b9bd2d6f.
>
> Dmitry Vyukov reported that commit 9362d34acf91 ("scripts/clang-tools:
> Handle included .c files in gen_compile_commands") generates false
> entries in some cases for C files that are included in other C files but
> not meant for standalone compilation.
>
> For properly forking clangd, including .c files is discouraged.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Closes: https://lore.kernel.org/r/CACT4Y+Z8aCz0XcoJx9XXPHZSZHxGF8Kx9iUbFarhpTSEPDhMfg@mail.gmail.com
> Signed-off-by: Nicolas Schier <nsc@kernel.org>
Acked-by: Nathan Chancellor <nathan@kernel.org>
next prev parent reply other threads:[~2025-12-18 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 19:13 [PATCH] Revert "scripts/clang-tools: Handle included .c files in gen_compile_commands" Nicolas Schier
2025-12-18 0:13 ` Nathan Chancellor [this message]
2025-12-18 7:03 ` Dmitry Vyukov
2025-12-27 20:10 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218001336.GA2451437@ax162 \
--to=nathan@kernel.org \
--cc=dvyukov@google.com \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox