* [gdamjan:v6.19/thinkpad-x9-14 6/6] drivers/media/i2c/imx471.c:1053:1: warning: unused label 'error_power_off'
@ 2025-12-20 13:46 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-12-20 13:46 UTC (permalink / raw)
To: Дамјан Георгиевски
Cc: llvm, oe-kbuild-all, Serin Yeh
tree: https://github.com/gdamjan/linux v6.19/thinkpad-x9-14
head: 89f00ee2600546cc930a1fbad7d401bc134d54e4
commit: 89f00ee2600546cc930a1fbad7d401bc134d54e4 [6/6] Add IMX471 power management for correct behaviors
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20251220/202512202128.RJ8OLja9-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251220/202512202128.RJ8OLja9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512202128.RJ8OLja9-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/imx471.c:1053:1: warning: unused label 'error_power_off' [-Wunused-label]
1053 | error_power_off:
| ^~~~~~~~~~~~~~~~
1 warning generated.
vim +/error_power_off +1053 drivers/media/i2c/imx471.c
961
962 static int imx471_probe(struct i2c_client *client)
963 {
964 struct imx471 *imx471;
965 bool full_power;
966 int ret;
967
968
969 /* Check HW config */
970 ret = imx471_check_hwcfg(&client->dev);
971 if (ret) {
972 dev_err(&client->dev, "failed to check hwcfg: %d", ret);
973 return ret;
974 }
975
976 imx471 = devm_kzalloc(&client->dev, sizeof(*imx471), GFP_KERNEL);
977 if (!imx471)
978 return -ENOMEM;
979
980 mutex_init(&imx471->mutex);
981
982 /* Initialize subdev */
983 v4l2_i2c_subdev_init(&imx471->sd, client, &imx471_subdev_ops);
984
985 ret = imx471_get_pm_resources(&client->dev);
986 if (ret)
987 return ret;
988
989 full_power = acpi_dev_state_d0(&client->dev);
990 if (full_power) {
991 ret = imx471_power_on(&client->dev);
992 if (ret) {
993 dev_err(&client->dev, "failed to power on\n");
994 return ret;
995 }
996
997 /* Check module identity */
998 ret = imx471_identify_module(imx471);
999 if (ret) {
1000 dev_err(&client->dev, "failed to find sensor: %d", ret);
1001 goto error_probe;
1002 }
1003 }
1004
1005 /* Set default mode to max resolution */
1006 imx471->cur_mode = &supported_modes[0];
1007
1008 ret = imx471_init_controls(imx471);
1009 if (ret) {
1010 dev_err(&client->dev, "failed to init controls: %d", ret);
1011 goto error_probe;
1012 }
1013
1014 /* Initialize subdev */
1015 imx471->sd.internal_ops = &imx471_internal_ops;
1016 imx471->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
1017 V4L2_SUBDEV_FL_HAS_EVENTS;
1018 imx471->sd.entity.ops = &imx471_subdev_entity_ops;
1019 imx471->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
1020
1021 /* Initialize source pad */
1022 imx471->pad.flags = MEDIA_PAD_FL_SOURCE;
1023 ret = media_entity_pads_init(&imx471->sd.entity, 1, &imx471->pad);
1024 if (ret) {
1025 dev_err(&client->dev, "failed to init entity pads: %d", ret);
1026 goto error_handler_free;
1027 }
1028
1029 /* Set the device's state to active if it's in D0 state. */
1030 if (full_power)
1031 pm_runtime_set_active(&client->dev);
1032 pm_runtime_enable(&client->dev);
1033 pm_runtime_idle(&client->dev);
1034
1035 ret = v4l2_async_register_subdev_sensor(&imx471->sd);
1036 if (ret < 0)
1037 goto error_media_entity_pm;
1038
1039 dev_info(&client->dev, "imx471 probe successfully\n");
1040 return 0;
1041
1042 error_media_entity_pm:
1043 pm_runtime_disable(&client->dev);
1044 pm_runtime_set_suspended(&client->dev);
1045 media_entity_cleanup(&imx471->sd.entity);
1046
1047 error_handler_free:
1048 v4l2_ctrl_handler_free(imx471->sd.ctrl_handler);
1049
1050 error_probe:
1051 mutex_destroy(&imx471->mutex);
1052
> 1053 error_power_off:
1054 imx471_power_off(&client->dev);
1055
1056 return ret;
1057 }
1058
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [gdamjan:v6.19/thinkpad-x9-14 6/6] drivers/media/i2c/imx471.c:1053:1: warning: unused label 'error_power_off'
@ 2026-01-25 1:50 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-01-25 1:50 UTC (permalink / raw)
To: Дамјан Георгиевски
Cc: llvm, oe-kbuild-all, Serin Yeh
tree: https://github.com/gdamjan/linux v6.19/thinkpad-x9-14
head: f7bddb11dc3d768f1af5f0a4eb2c6984689ab88b
commit: f7bddb11dc3d768f1af5f0a4eb2c6984689ab88b [6/6] Add IMX471 power management for correct behaviors
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260125/202601250952.D6Ov8DPD-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260125/202601250952.D6Ov8DPD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601250952.D6Ov8DPD-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/imx471.c:1053:1: warning: unused label 'error_power_off' [-Wunused-label]
1053 | error_power_off:
| ^~~~~~~~~~~~~~~~
1 warning generated.
vim +/error_power_off +1053 drivers/media/i2c/imx471.c
961
962 static int imx471_probe(struct i2c_client *client)
963 {
964 struct imx471 *imx471;
965 bool full_power;
966 int ret;
967
968
969 /* Check HW config */
970 ret = imx471_check_hwcfg(&client->dev);
971 if (ret) {
972 dev_err(&client->dev, "failed to check hwcfg: %d", ret);
973 return ret;
974 }
975
976 imx471 = devm_kzalloc(&client->dev, sizeof(*imx471), GFP_KERNEL);
977 if (!imx471)
978 return -ENOMEM;
979
980 mutex_init(&imx471->mutex);
981
982 /* Initialize subdev */
983 v4l2_i2c_subdev_init(&imx471->sd, client, &imx471_subdev_ops);
984
985 ret = imx471_get_pm_resources(&client->dev);
986 if (ret)
987 return ret;
988
989 full_power = acpi_dev_state_d0(&client->dev);
990 if (full_power) {
991 ret = imx471_power_on(&client->dev);
992 if (ret) {
993 dev_err(&client->dev, "failed to power on\n");
994 return ret;
995 }
996
997 /* Check module identity */
998 ret = imx471_identify_module(imx471);
999 if (ret) {
1000 dev_err(&client->dev, "failed to find sensor: %d", ret);
1001 goto error_probe;
1002 }
1003 }
1004
1005 /* Set default mode to max resolution */
1006 imx471->cur_mode = &supported_modes[0];
1007
1008 ret = imx471_init_controls(imx471);
1009 if (ret) {
1010 dev_err(&client->dev, "failed to init controls: %d", ret);
1011 goto error_probe;
1012 }
1013
1014 /* Initialize subdev */
1015 imx471->sd.internal_ops = &imx471_internal_ops;
1016 imx471->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
1017 V4L2_SUBDEV_FL_HAS_EVENTS;
1018 imx471->sd.entity.ops = &imx471_subdev_entity_ops;
1019 imx471->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
1020
1021 /* Initialize source pad */
1022 imx471->pad.flags = MEDIA_PAD_FL_SOURCE;
1023 ret = media_entity_pads_init(&imx471->sd.entity, 1, &imx471->pad);
1024 if (ret) {
1025 dev_err(&client->dev, "failed to init entity pads: %d", ret);
1026 goto error_handler_free;
1027 }
1028
1029 /* Set the device's state to active if it's in D0 state. */
1030 if (full_power)
1031 pm_runtime_set_active(&client->dev);
1032 pm_runtime_enable(&client->dev);
1033 pm_runtime_idle(&client->dev);
1034
1035 ret = v4l2_async_register_subdev_sensor(&imx471->sd);
1036 if (ret < 0)
1037 goto error_media_entity_pm;
1038
1039 dev_info(&client->dev, "imx471 probe successfully\n");
1040 return 0;
1041
1042 error_media_entity_pm:
1043 pm_runtime_disable(&client->dev);
1044 pm_runtime_set_suspended(&client->dev);
1045 media_entity_cleanup(&imx471->sd.entity);
1046
1047 error_handler_free:
1048 v4l2_ctrl_handler_free(imx471->sd.ctrl_handler);
1049
1050 error_probe:
1051 mutex_destroy(&imx471->mutex);
1052
> 1053 error_power_off:
1054 imx471_power_off(&client->dev);
1055
1056 return ret;
1057 }
1058
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-25 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-20 13:46 [gdamjan:v6.19/thinkpad-x9-14 6/6] drivers/media/i2c/imx471.c:1053:1: warning: unused label 'error_power_off' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-01-25 1:50 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox