public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
* Re: [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags
       [not found] ` <20251217224050.1186896-1-siddhesh@gotplt.org>
@ 2026-01-04 20:53   ` Miguel Ojeda
  2026-01-05 10:58     ` Siddhesh Poyarekar
  2026-01-05 23:03     ` Nathan Chancellor
  0 siblings, 2 replies; 3+ messages in thread
From: Miguel Ojeda @ 2026-01-04 20:53 UTC (permalink / raw)
  To: Siddhesh Poyarekar, Nathan Chancellor, Nicolas Schier,
	Nick Desaulniers, Bill Wendling, Justin Stitt
  Cc: rust-for-linux, Kees Cook, Alice Ryhl, Miguel Ojeda, Boqun Feng,
	Gary Guo, stable, Linux Kbuild mailing list, clang-built-linux

On Wed, Dec 17, 2025 at 11:41 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>
> but clang does not have this option, so avoid passing it to bindgen.

This looks indeed correct, although it is not yet in a released GCC
(testing quickly in Compiler Explorer, GCC 15.2 doesn't have it, but
GCC trunk has).

I will apply it -- Cc'ing ClangBuiltLinux and Kbuild so that they are aware.

Thanks!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags
  2026-01-04 20:53   ` [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags Miguel Ojeda
@ 2026-01-05 10:58     ` Siddhesh Poyarekar
  2026-01-05 23:03     ` Nathan Chancellor
  1 sibling, 0 replies; 3+ messages in thread
From: Siddhesh Poyarekar @ 2026-01-05 10:58 UTC (permalink / raw)
  To: Miguel Ojeda, Nathan Chancellor, Nicolas Schier, Nick Desaulniers,
	Bill Wendling, Justin Stitt
  Cc: rust-for-linux, Kees Cook, Alice Ryhl, Miguel Ojeda, Boqun Feng,
	Gary Guo, stable, Linux Kbuild mailing list, clang-built-linux

On 2026-01-04 15:53, Miguel Ojeda wrote:
> On Wed, Dec 17, 2025 at 11:41 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>>
>> but clang does not have this option, so avoid passing it to bindgen.
> 
> This looks indeed correct, although it is not yet in a released GCC
> (testing quickly in Compiler Explorer, GCC 15.2 doesn't have it, but
> GCC trunk has).

Yes, sorry I didn't mention that in my commit message; it's mentioned in 
Kees' commit message (7454048db27d6).

> I will apply it -- Cc'ing ClangBuiltLinux and Kbuild so that they are aware.

Thank you!

Sid

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags
  2026-01-04 20:53   ` [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags Miguel Ojeda
  2026-01-05 10:58     ` Siddhesh Poyarekar
@ 2026-01-05 23:03     ` Nathan Chancellor
  1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2026-01-05 23:03 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Siddhesh Poyarekar, Nicolas Schier, Nick Desaulniers,
	Bill Wendling, Justin Stitt, rust-for-linux, Kees Cook,
	Alice Ryhl, Miguel Ojeda, Boqun Feng, Gary Guo, stable,
	Linux Kbuild mailing list, clang-built-linux

On Sun, Jan 04, 2026 at 09:53:25PM +0100, Miguel Ojeda wrote:
> On Wed, Dec 17, 2025 at 11:41 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> >
> > but clang does not have this option, so avoid passing it to bindgen.
> 
> This looks indeed correct, although it is not yet in a released GCC
> (testing quickly in Compiler Explorer, GCC 15.2 doesn't have it, but
> GCC trunk has).
> 
> I will apply it -- Cc'ing ClangBuiltLinux and Kbuild so that they are aware.

Right, this does look correct, as this option is specific to GCC for the
purpose of exposing more information from GCC internals to the user for
understanding diagnostics better.

I will say if this makes 6.19, the stable tag is not necessary since
7454048db27d6 landed in 6.19-rc1 and I would not expect it to get
backported (but even if it did via AUTOSEL or something, the Fixes tag
should ensure it gets included).

Cheers,
Nathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-05 23:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20251217150010.665153-1-siddhesh@gotplt.org>
     [not found] ` <20251217224050.1186896-1-siddhesh@gotplt.org>
2026-01-04 20:53   ` [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags Miguel Ojeda
2026-01-05 10:58     ` Siddhesh Poyarekar
2026-01-05 23:03     ` Nathan Chancellor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox