Re: [PATCH v3 2/2] mm: vmscan: add PIDs to vmscan tracepoints

Re: [PATCH v3 2/2] mm: vmscan: add PIDs to vmscan tracepoints

[kernel test robot]

Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Ballasi/mm-vmscan-add-cgroup-IDs-to-vmscan-tracepoints/20260106-000721
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260105160423.23708-3-tballasi%40linux.microsoft.com
patch subject: [PATCH v3 2/2] mm: vmscan: add PIDs to vmscan tracepoints
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260106/202601061007.oLjwuFir-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260106/202601061007.oLjwuFir-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601061007.oLjwuFir-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from mm/vmscan.c:73:
   In file included from include/trace/events/vmscan.h:569:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:256:
>> include/trace/events/vmscan.h:140:4: error: call to undeclared function '__event_in_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     140 | +               __event_in_irq() ? "(in-irq)" : "")
         |                 ^
   include/trace/events/vmscan.h:188:3: error: call to undeclared function '__event_in_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     188 |                 __event_in_irq() ? "(in-irq)" : "")
         |                 ^
   include/trace/events/vmscan.h:263:4: error: call to undeclared function '__event_in_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     263 | +               __event_in_irq() ? "(in-irq)" : "")
         |                 ^
   include/trace/events/vmscan.h:306:4: error: call to undeclared function '__event_in_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     306 | +               __event_in_irq() ? "(in-irq)" : "")
         |                 ^
   4 errors generated.


vim +/__event_in_irq +140 include/trace/events/vmscan.h

   116	
   117		TP_PROTO(gfp_t gfp_flags, int order, unsigned short memcg_id),
   118	
   119		TP_ARGS(gfp_flags, order, memcg_id),
   120	
   121		TP_STRUCT__entry(
   122			__field(	unsigned long,	gfp_flags	)
   123			__field(	int,	order		)
   124			__field(	int,	pid		)
   125			__field(	unsigned short,	memcg_id	)
   126		),
   127	
   128		TP_fast_assign(
   129			__entry->gfp_flags	= (__force unsigned long)gfp_flags;
   130			__entry->order		= order;
   131			__entry->pid		= current->pid;
   132			__entry->memcg_id	= memcg_id;
   133		),
   134	
   135		TP_printk("order=%d gfp_flags=%s pid=%d memcg_id=%u %s",
   136			__entry->order,
   137			show_gfp_flags(__entry->gfp_flags),
   138			__entry->pid,
   139			__entry->memcg_id,
 > 140	+		__event_in_irq() ? "(in-irq)" : "")
   141	);
   142	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki