Re: [RFC] s390x/kdump: pass dm-crypt keys to kdump kernel

Re: [RFC] s390x/kdump: pass dm-crypt keys to kdump kernel

[kernel test robot]

Hi Coiby,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 7f98ab9da046865d57c102fd3ca9669a29845f67]

url:    https://github.com/intel-lab-lkp/linux/commits/Coiby-Xu/s390x-kdump-pass-dm-crypt-keys-to-kdump-kernel/20260116-183709
base:   7f98ab9da046865d57c102fd3ca9669a29845f67
patch link:    https://lore.kernel.org/r/20260116103347.523747-1-coxu%40redhat.com
patch subject: [RFC] s390x/kdump: pass dm-crypt keys to kdump kernel
config: s390-defconfig (https://download.01.org/0day-ci/archive/20260118/202601181322.wUUqO1Ok-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260118/202601181322.wUUqO1Ok-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601181322.wUUqO1Ok-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/crash_dump_dm_crypt.c:55:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
      55 |         int ret;
         |             ^
>> kernel/crash_dump_dm_crypt.c:432:6: warning: variable 'r' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
     432 |         if (!is_dm_key_reused) {
         |             ^~~~~~~~~~~~~~~~~
   kernel/crash_dump_dm_crypt.c:461:9: note: uninitialized use occurs here
     461 |         return r;
         |                ^
   kernel/crash_dump_dm_crypt.c:432:2: note: remove the 'if' if its condition is always true
     432 |         if (!is_dm_key_reused) {
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/crash_dump_dm_crypt.c:424:7: note: initialize the variable 'r' to silence this warning
     424 |         int r;
         |              ^
         |               = 0
   2 warnings generated.


vim +/ret +55 kernel/crash_dump_dm_crypt.c

    51	
    52	static int __init setup_dmcryptkeys_size(char *arg)
    53	{
    54		size_t keys_size;
  > 55		int ret;
    56	
    57		if (dm_crypt_keys_addr == 0) {
    58			pr_warn("dmcryptkeys=0\n");
    59			return -EINVAL;
    60		}
    61	
    62		if (!arg)
    63			return -EINVAL;
    64	
    65		ret = kstrtoul(arg, 0, &keys_size);
    66		memblock_reserve((phys_addr_t)dm_crypt_keys_addr, keys_size);
    67		return 0;
    68	}
    69	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [RFC] s390x/kdump: pass dm-crypt keys to kdump kernel

[kernel test robot]

Hi Coiby,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 7f98ab9da046865d57c102fd3ca9669a29845f67]

url:    https://github.com/intel-lab-lkp/linux/commits/Coiby-Xu/s390x-kdump-pass-dm-crypt-keys-to-kdump-kernel/20260116-183709
base:   7f98ab9da046865d57c102fd3ca9669a29845f67
patch link:    https://lore.kernel.org/r/20260116103347.523747-1-coxu%40redhat.com
patch subject: [RFC] s390x/kdump: pass dm-crypt keys to kdump kernel
config: s390-randconfig-002-20260118 (https://download.01.org/0day-ci/archive/20260118/202601182109.oKlosNBC-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260118/202601182109.oKlosNBC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601182109.oKlosNBC-lkp@intel.com/

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: dm_crypt_keys_addr
   >>> referenced by crash_dump.c:0 (arch/s390/kernel/crash_dump.c:0)
   >>>               arch/s390/kernel/crash_dump.o:(dm_crypt_keys_read) in archive vmlinux.a

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki