* Re: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
[not found] <20260120222018.404741-16-detlev.casanova@collabora.com>
@ 2026-01-21 14:27 ` kernel test robot
2026-01-21 14:46 ` Nicolas Dufresne
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-01-21 14:27 UTC (permalink / raw)
To: Detlev Casanova, linux-kernel
Cc: llvm, oe-kbuild-all, Mauro Carvalho Chehab, linux-media,
Detlev Casanova, Ezequiel Garcia, Heiko Stuebner, Daniel Almeida,
Jonathan Corbet, Ricardo Ribalda, Hans Verkuil, Yunke Cao,
Hans de Goede, Laurent Pinchart, Nicolas Dufresne, Pavan Bobba,
Sakari Ailus, James Cowgill, linux-rockchip, linux-arm-kernel,
kernel, Jonas Karlman, Diederik de Haas
Hi Detlev,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on linuxtv-media-pending/master media-tree/master linus/master v6.19-rc6 next-20260120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Detlev-Casanova/media-uapi-HEVC-Add-v4l2_ctrl_hevc_ext_sps_-ls-t_rps-controls/20260121-071026
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link: https://lore.kernel.org/r/20260120222018.404741-16-detlev.casanova%40collabora.com
patch subject: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20260121/202601211924.rqKS2Ihm-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260121/202601211924.rqKS2Ihm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601211924.rqKS2Ihm-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-h264.c:485:12: warning: stack frame size (2064) exceeds limit (2048) in 'rkvdec_h264_run' [-Wframe-larger-than]
485 | static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
| ^
1 warning generated.
vim +/rkvdec_h264_run +485 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-h264.c
484
> 485 static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
486 {
487 struct v4l2_h264_reflist_builder reflist_builder;
488 struct rkvdec_dev *rkvdec = ctx->dev;
489 struct rkvdec_h264_ctx *h264_ctx = ctx->priv;
490 struct rkvdec_h264_run run;
491 struct rkvdec_h264_priv_tbl *tbl = h264_ctx->priv_tbl.cpu;
492 u32 timeout_threshold;
493
494 rkvdec_h264_run_preamble(ctx, &run);
495
496 /* Build the P/B{0,1} ref lists. */
497 v4l2_h264_init_reflist_builder(&reflist_builder, run.decode_params,
498 run.sps, run.decode_params->dpb);
499 v4l2_h264_build_p_ref_list(&reflist_builder, h264_ctx->reflists.p);
500 v4l2_h264_build_b_ref_lists(&reflist_builder, h264_ctx->reflists.b0,
501 h264_ctx->reflists.b1);
502
503 assemble_hw_scaling_list(&run, &tbl->scaling_list);
504 assemble_hw_pps(ctx, &run);
505 lookup_ref_buf_idx(ctx, &run);
506 assemble_hw_rps(&reflist_builder, &run, &h264_ctx->reflists, &tbl->rps);
507
508 config_registers(ctx, &run);
509
510 rkvdec_run_postamble(ctx, &run.base);
511
512 timeout_threshold = h264_ctx->regs.common.reg013_core_timeout_threshold;
513 rkvdec_schedule_watchdog(rkvdec, timeout_threshold);
514
515 /* Start decoding! */
516 writel(timeout_threshold, rkvdec->link + VDPU383_LINK_TIMEOUT_THRESHOLD);
517 writel(0, rkvdec->link + VDPU383_LINK_IP_ENABLE);
518 writel(VDPU383_DEC_E_BIT, rkvdec->link + VDPU383_LINK_DEC_ENABLE);
519
520 return 0;
521 }
522
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
2026-01-21 14:27 ` [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant kernel test robot
@ 2026-01-21 14:46 ` Nicolas Dufresne
2026-01-21 23:04 ` Nathan Chancellor
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dufresne @ 2026-01-21 14:46 UTC (permalink / raw)
To: kernel test robot, Detlev Casanova, linux-kernel
Cc: llvm, oe-kbuild-all, Mauro Carvalho Chehab, linux-media,
Ezequiel Garcia, Heiko Stuebner, Daniel Almeida, Jonathan Corbet,
Ricardo Ribalda, Hans Verkuil, Yunke Cao, Hans de Goede,
Laurent Pinchart, Pavan Bobba, Sakari Ailus, James Cowgill,
linux-rockchip, linux-arm-kernel, kernel, Jonas Karlman,
Diederik de Haas
[-- Attachment #1: Type: text/plain, Size: 4489 bytes --]
Hi,
Le mercredi 21 janvier 2026 à 22:27 +0800, kernel test robot a écrit :
> Hi Detlev,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on rockchip/for-next]
> [also build test WARNING on linuxtv-media-pending/master media-tree/master linus/master v6.19-rc6 next-20260120]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Detlev-Casanova/media-uapi-HEVC-Add-v4l2_ctrl_hevc_ext_sps_-ls-t_rps-controls/20260121-071026
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
> patch link: https://lore.kernel.org/r/20260120222018.404741-16-detlev.casanova%40collabora.com
> patch subject: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
> config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20260121/202601211924.rqKS2Ihm-lkp@intel.com/config)
> compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
Modification has been done to reduce the stack utilization on clang, though we
believe we are hitting limitations/bugs on older clang. We went ahead with these
patch by updating our CI to clang 21, which allocate a lot less stack with KASAN
enabled and this code. Our general advise is to use a newer clang, or GCC for
testing with KASAN.
The stack utilization is caused by the combination of loop unrolling, agressive
inlining, and write operations to bitfield (which requires the compiler to
generate more code for memory checks, since the writes are not aligned).
cheers,
Nicolas
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260121/202601211924.rqKS2Ihm-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202601211924.rqKS2Ihm-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> > > drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-h264.c:485:12: warning: stack frame size (2064) exceeds limit (2048) in 'rkvdec_h264_run' [-Wframe-larger-than]
> 485 | static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
> | ^
> 1 warning generated.
>
>
> vim +/rkvdec_h264_run +485 drivers/media/platform/rockchip/rkvdec/rkvdec-vdpu383-h264.c
>
> 484
> > 485 static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
> 486 {
> 487 struct v4l2_h264_reflist_builder reflist_builder;
> 488 struct rkvdec_dev *rkvdec = ctx->dev;
> 489 struct rkvdec_h264_ctx *h264_ctx = ctx->priv;
> 490 struct rkvdec_h264_run run;
> 491 struct rkvdec_h264_priv_tbl *tbl = h264_ctx->priv_tbl.cpu;
> 492 u32 timeout_threshold;
> 493
> 494 rkvdec_h264_run_preamble(ctx, &run);
> 495
> 496 /* Build the P/B{0,1} ref lists. */
> 497 v4l2_h264_init_reflist_builder(&reflist_builder, run.decode_params,
> 498 run.sps, run.decode_params->dpb);
> 499 v4l2_h264_build_p_ref_list(&reflist_builder, h264_ctx->reflists.p);
> 500 v4l2_h264_build_b_ref_lists(&reflist_builder, h264_ctx->reflists.b0,
> 501 h264_ctx->reflists.b1);
> 502
> 503 assemble_hw_scaling_list(&run, &tbl->scaling_list);
> 504 assemble_hw_pps(ctx, &run);
> 505 lookup_ref_buf_idx(ctx, &run);
> 506 assemble_hw_rps(&reflist_builder, &run, &h264_ctx->reflists, &tbl->rps);
> 507
> 508 config_registers(ctx, &run);
> 509
> 510 rkvdec_run_postamble(ctx, &run.base);
> 511
> 512 timeout_threshold = h264_ctx->regs.common.reg013_core_timeout_threshold;
> 513 rkvdec_schedule_watchdog(rkvdec, timeout_threshold);
> 514
> 515 /* Start decoding! */
> 516 writel(timeout_threshold, rkvdec->link + VDPU383_LINK_TIMEOUT_THRESHOLD);
> 517 writel(0, rkvdec->link + VDPU383_LINK_IP_ENABLE);
> 518 writel(VDPU383_DEC_E_BIT, rkvdec->link + VDPU383_LINK_DEC_ENABLE);
> 519
> 520 return 0;
> 521 }
> 522
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
2026-01-21 14:46 ` Nicolas Dufresne
@ 2026-01-21 23:04 ` Nathan Chancellor
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2026-01-21 23:04 UTC (permalink / raw)
To: Nicolas Dufresne
Cc: kernel test robot, Detlev Casanova, linux-kernel, llvm,
oe-kbuild-all, Mauro Carvalho Chehab, linux-media,
Ezequiel Garcia, Heiko Stuebner, Daniel Almeida, Jonathan Corbet,
Ricardo Ribalda, Hans Verkuil, Yunke Cao, Hans de Goede,
Laurent Pinchart, Pavan Bobba, Sakari Ailus, James Cowgill,
linux-rockchip, linux-arm-kernel, kernel, Jonas Karlman,
Diederik de Haas
On Wed, Jan 21, 2026 at 09:46:48AM -0500, Nicolas Dufresne wrote:
> Le mercredi 21 janvier 2026 à 22:27 +0800, kernel test robot a écrit :
> > Hi Detlev,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on rockchip/for-next]
> > [also build test WARNING on linuxtv-media-pending/master media-tree/master linus/master v6.19-rc6 next-20260120]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Detlev-Casanova/media-uapi-HEVC-Add-v4l2_ctrl_hevc_ext_sps_-ls-t_rps-controls/20260121-071026
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
> > patch link: https://lore.kernel.org/r/20260120222018.404741-16-detlev.casanova%40collabora.com
> > patch subject: [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant
> > config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20260121/202601211924.rqKS2Ihm-lkp@intel.com/config)
> > compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
>
> Modification has been done to reduce the stack utilization on clang, though we
> believe we are hitting limitations/bugs on older clang. We went ahead with these
> patch by updating our CI to clang 21, which allocate a lot less stack with KASAN
> enabled and this code. Our general advise is to use a newer clang, or GCC for
> testing with KASAN.
>
> The stack utilization is caused by the combination of loop unrolling, agressive
> inlining, and write operations to bitfield (which requires the compiler to
> generate more code for memory checks, since the writes are not aligned).
Yes, this is an area that has known pain points, even in current
versions (but it is certainly better in most cases):
https://github.com/llvm/llvm-project/issues/143908
https://github.com/llvm/llvm-project/issues/115862
Thank you for working around this.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-21 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260120222018.404741-16-detlev.casanova@collabora.com>
2026-01-21 14:27 ` [PATCH v9 15/17] media: rkvdec: Add H264 support for the VDPU383 variant kernel test robot
2026-01-21 14:46 ` Nicolas Dufresne
2026-01-21 23:04 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox