[thomas-weissschuh:b4/sysfs-const-driver-attribute 17/17] drivers/s390/crypto/ap_bus.c:1507:20: error: initializing 'struct ap_driver *' with an expression of type 'const struct ap_driver *' discards qualifiers

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thomas.weissschuh/linux.git b4/sysfs-const-driver-attribute
head:   92cff81ee317b9c2c7c4e3bb80f46c9feddbfa9d
commit: 92cff81ee317b9c2c7c4e3bb80f46c9feddbfa9d [17/17] bus_for_each_drv
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260126/202601260335.bRgOolw4-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601260335.bRgOolw4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601260335.bRgOolw4-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/s390/crypto/ap_bus.c:1507:20: error: initializing 'struct ap_driver *' with an expression of type 'const struct ap_driver *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    1507 |         struct ap_driver *ap_drv = to_ap_drv(drv);
         |                           ^        ~~~~~~~~~~~~~~
   1 error generated.


vim +1507 drivers/s390/crypto/ap_bus.c

7e0bdbe5c21cb8 Harald Freudenberger 2018-07-20  1503  
92cff81ee317b9 Thomas Weißschuh     2026-01-25  1504  static int __verify_card_reservations(const struct device_driver *drv, void *data)
4f8206b882868b Tony Krowiak         2019-02-01  1505  {
4f8206b882868b Tony Krowiak         2019-02-01  1506  	int rc = 0;
4f8206b882868b Tony Krowiak         2019-02-01 @1507  	struct ap_driver *ap_drv = to_ap_drv(drv);
4f8206b882868b Tony Krowiak         2019-02-01  1508  	unsigned long *newapm = (unsigned long *)data;
6917f434fda346 Harald Freudenberger 2025-11-19  1509  	unsigned long aqm_any[BITS_TO_LONGS(AP_DOMAINS)];
4f8206b882868b Tony Krowiak         2019-02-01  1510  
4f8206b882868b Tony Krowiak         2019-02-01  1511  	/*
4f8206b882868b Tony Krowiak         2019-02-01  1512  	 * increase the driver's module refcounter to be sure it is not
4f8206b882868b Tony Krowiak         2019-02-01  1513  	 * going away when we invoke the callback function.
4f8206b882868b Tony Krowiak         2019-02-01  1514  	 */
4f8206b882868b Tony Krowiak         2019-02-01  1515  	if (!try_module_get(drv->owner))
4f8206b882868b Tony Krowiak         2019-02-01  1516  		return 0;
4f8206b882868b Tony Krowiak         2019-02-01  1517  
4f8206b882868b Tony Krowiak         2019-02-01  1518  	if (ap_drv->in_use) {
6917f434fda346 Harald Freudenberger 2025-11-19  1519  		bitmap_fill(aqm_any, AP_DOMAINS);
6917f434fda346 Harald Freudenberger 2025-11-19  1520  		rc = ap_drv->in_use(newapm, aqm_any);
4f8206b882868b Tony Krowiak         2019-02-01  1521  		if (rc)
4f8206b882868b Tony Krowiak         2019-02-01  1522  			rc = -EBUSY;
4f8206b882868b Tony Krowiak         2019-02-01  1523  	}
4f8206b882868b Tony Krowiak         2019-02-01  1524  
4f8206b882868b Tony Krowiak         2019-02-01  1525  	/* release the driver's module */
4f8206b882868b Tony Krowiak         2019-02-01  1526  	module_put(drv->owner);
4f8206b882868b Tony Krowiak         2019-02-01  1527  
4f8206b882868b Tony Krowiak         2019-02-01  1528  	return rc;
4f8206b882868b Tony Krowiak         2019-02-01  1529  }
4f8206b882868b Tony Krowiak         2019-02-01  1530  

:::::: The code at line 1507 was first introduced by commit
:::::: 4f8206b882868b62dc15ddfc0c17bb031876afb5 s390/ap: driver callback to indicate resource in use

:::::: TO: Tony Krowiak <akrowiak@linux.ibm.com>
:::::: CC: Vasily Gorbik <gor@linux.ibm.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki