public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
* [sj:damon/next 112/124] mm/damon/core.c:1862:4: error: use of undeclared identifier 'c'
@ 2026-02-09 13:52 kernel test robot
  2026-02-09 15:13 ` SeongJae Park
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-02-09 13:52 UTC (permalink / raw)
  To: SeongJae Park; +Cc: llvm, oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   74672caf715ec5f49e15d405b8030ce9cb686d4f
commit: 7fdffc23ed84ea44a9f15f71d15b00a94f326acd [112/124] mm/damon/core: unify damon_warn_fix_nr_accesses_corruption() with damon_verify_reset_aggregated()
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260209/202602092126.d6pfqcbG-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260209/202602092126.d6pfqcbG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602092126.d6pfqcbG-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/damon/core.c:1862:4: error: use of undeclared identifier 'c'
    1862 |                         c->passed_sample_intervals,
         |                         ^
   mm/damon/core.c:1863:4: error: use of undeclared identifier 'c'
    1863 |                         c->next_aggregation_sis);
         |                         ^
   2 errors generated.


vim +/c +1862 mm/damon/core.c

89796f03081328 SeongJae Park 2025-12-02  1844  
591c4c78be0636 SeongJae Park 2025-05-12  1845  /*
591c4c78be0636 SeongJae Park 2025-05-12  1846   * Warn and fix corrupted ->nr_accesses[_bp] for investigations and preventing
591c4c78be0636 SeongJae Park 2025-05-12  1847   * the problem being propagated.
591c4c78be0636 SeongJae Park 2025-05-12  1848   */
591c4c78be0636 SeongJae Park 2025-05-12  1849  static void damon_warn_fix_nr_accesses_corruption(struct damon_region *r)
591c4c78be0636 SeongJae Park 2025-05-12  1850  {
591c4c78be0636 SeongJae Park 2025-05-12  1851  	if (r->nr_accesses_bp == r->nr_accesses * 10000)
591c4c78be0636 SeongJae Park 2025-05-12  1852  		return;
7fdffc23ed84ea SeongJae Park 2026-02-04  1853  #ifndef CONFIG_DAMON_HARDENED
591c4c78be0636 SeongJae Park 2025-05-12  1854  	WARN_ONCE(true, "invalid nr_accesses_bp at reset: %u %u\n",
591c4c78be0636 SeongJae Park 2025-05-12  1855  			r->nr_accesses_bp, r->nr_accesses);
591c4c78be0636 SeongJae Park 2025-05-12  1856  	r->nr_accesses_bp = r->nr_accesses * 10000;
7fdffc23ed84ea SeongJae Park 2026-02-04  1857  #else
5b9f4fef2cb618 SeongJae Park 2026-01-03  1858  	pr_err("reset time invalid region found!\n");
5b9f4fef2cb618 SeongJae Park 2026-01-03  1859  	pr_err("nr_accesses_bp %u last_nr_acceses %u\n",
5b9f4fef2cb618 SeongJae Park 2026-01-03  1860  			r->nr_accesses_bp, r->last_nr_accesses);
5b9f4fef2cb618 SeongJae Park 2026-01-03  1861  	pr_err("passed_sis %lu next_aggregation_sis %lu\n",
5b9f4fef2cb618 SeongJae Park 2026-01-03 @1862  			c->passed_sample_intervals,
5b9f4fef2cb618 SeongJae Park 2026-01-03  1863  			c->next_aggregation_sis);
5b9f4fef2cb618 SeongJae Park 2026-01-03  1864  	BUG();
5b9f4fef2cb618 SeongJae Park 2026-01-03  1865  #endif
7fdffc23ed84ea SeongJae Park 2026-02-04  1866  }
5b9f4fef2cb618 SeongJae Park 2026-01-03  1867  

:::::: The code at line 1862 was first introduced by commit
:::::: 5b9f4fef2cb618ee597b3345dee579340e8d5d43 mm/damon/core: add damon_reset_aggregated() hardening

:::::: TO: SeongJae Park <sj@kernel.org>
:::::: CC: SeongJae Park <sj@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [sj:damon/next 112/124] mm/damon/core.c:1862:4: error: use of undeclared identifier 'c'
  2026-02-09 13:52 [sj:damon/next 112/124] mm/damon/core.c:1862:4: error: use of undeclared identifier 'c' kernel test robot
@ 2026-02-09 15:13 ` SeongJae Park
  0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2026-02-09 15:13 UTC (permalink / raw)
  To: kernel test robot; +Cc: SeongJae Park, llvm, oe-kbuild-all, damon

On Mon, 09 Feb 2026 21:52:26 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   74672caf715ec5f49e15d405b8030ce9cb686d4f
> commit: 7fdffc23ed84ea44a9f15f71d15b00a94f326acd [112/124] mm/damon/core: unify damon_warn_fix_nr_accesses_corruption() with damon_verify_reset_aggregated()
> config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260209/202602092126.d6pfqcbG-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260209/202602092126.d6pfqcbG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202602092126.d6pfqcbG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> mm/damon/core.c:1862:4: error: use of undeclared identifier 'c'
>     1862 |                         c->passed_sample_intervals,
>          |                         ^
>    mm/damon/core.c:1863:4: error: use of undeclared identifier 'c'
>     1863 |                         c->next_aggregation_sis);
>          |                         ^
>    2 errors generated.

Thank you for this report!  I just reverted the problematic commit and pushed
it to damon/next.


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-09 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09 13:52 [sj:damon/next 112/124] mm/damon/core.c:1862:4: error: use of undeclared identifier 'c' kernel test robot
2026-02-09 15:13 ` SeongJae Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox