Re: [RFC PATCH] mm: only set fault addrsss' access bit in do_anonymous_page

Re: [RFC PATCH] mm: only set fault addrsss' access bit in do_anonymous_page

[kernel test robot]

Hi Wenchao,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Wenchao-Hao/mm-only-set-fault-addrsss-access-bit-in-do_anonymous_page/20260210-123706
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260210043456.2137482-1-haowenchao22%40gmail.com
patch subject: [RFC PATCH] mm: only set fault addrsss' access bit in do_anonymous_page
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20260210/202602101655.FLOBeato-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260210/202602101655.FLOBeato-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602101655.FLOBeato-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:14:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:32:
>> include/linux/pgtable.h:432:45: error: too few arguments to function call, expected 5, have 4
     432 |         page_table_check_ptes_set(mm, ptep, pte, nr);
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~                  ^
   include/linux/page_table_check.h:139:20: note: 'page_table_check_ptes_set' declared here
     139 | static inline void page_table_check_ptes_set(struct mm_struct *mm,
         |                    ^                         ~~~~~~~~~~~~~~~~~~~~~
     140 |                                              unsigned long addr, pte_t *ptep,
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     141 |                                              pte_t pte, unsigned int nr)
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
   make[3]: *** [scripts/Makefile.build:182: arch/x86/kernel/asm-offsets.s] Error 1
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1314: prepare0] Error 2
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:248: __sub-make] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +432 include/linux/pgtable.h

   425	
   426	#ifndef set_ptes
   427	static inline void set_anon_ptes(struct mm_struct *mm, unsigned long addr,
   428			unsigned long fault_addr, pte_t *ptep, pte_t pte, unsigned int nr)
   429	{
   430		bool young = pte_young(pte);
   431	
 > 432		page_table_check_ptes_set(mm, ptep, pte, nr);
   433	
   434		for (;;) {
   435			if (young && addr == fault_addr)
   436				pte = pte_mkyoung(pte);
   437			else
   438				pte = pte_mkold(pte);
   439	
   440			set_pte(ptep, pte);
   441			if (--nr == 0)
   442				break;
   443	
   444			addr += PAGE_SIZE;
   445			ptep++;
   446			pte = pte_next_pfn(pte);
   447		}
   448	}
   449	#else
   450	#define set_anon_ptes(mm, addr, fault_addr, ptep, pte, nr) \
   451			set_ptes(mm, addr, ptep, pte, nr)
   452	#endif
   453	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki