Re: [PATCH v2 09/25] media: i2c: imx283: Define recommended area

Re: [PATCH v2 09/25] media: i2c: imx283: Define recommended area

[kernel test robot]

Hi Kieran,

kernel test robot noticed the following build errors:

[auto build test ERROR on c824345288d11e269ce41b36c105715bc2286050]

url:    https://github.com/intel-lab-lkp/linux/commits/Kieran-Bingham/media-i2c-imx283-Report-correct-V4L2_SEL_TGT_CROP/20260213-221320
base:   c824345288d11e269ce41b36c105715bc2286050
patch link:    https://lore.kernel.org/r/20260213-mainline-imx283-v2-v2-9-be40a3770ebf%40ideasonboard.com
patch subject: [PATCH v2 09/25] media: i2c: imx283: Define recommended area
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260214/202602141812.smD7Mebb-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260214/202602141812.smD7Mebb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602141812.smD7Mebb-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/i2c/imx283.c:510:11: error: initializer element is not a compile-time constant
                   .crop = imx283_recommended_area,
                           ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/imx283.c:571:11: error: initializer element is not a compile-time constant
                   .crop = imx283_recommended_area,
                           ^~~~~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +510 drivers/media/i2c/imx283.c

   489	
   490	/* Mode configs */
   491	static const struct imx283_mode supported_modes_12bit[] = {
   492		{
   493			/* 20MPix 21.40 fps readout mode 0 */
   494			.scan = &imx283_scan_modes[IMX283_MODE_0],
   495	
   496			.width = 5472,
   497			.height = 3648,
   498			.min_hmax = 5914, /* 887 @ 480MHz/72MHz */
   499			.min_vmax = 3793, /* Lines */
   500	
   501			.hbin_ratio = 1,
   502			.vbin_ratio = 1,
   503	
   504			/* 20.00 FPS */
   505			.default_hmax = 6000, /* 900 @ 480MHz/72MHz */
   506			.default_vmax = 4000,
   507	
   508			.min_shr = 11,
   509	
 > 510			.crop = imx283_recommended_area,
   511		},
   512		{
   513			/*
   514			 * Readout mode 2 : 2/2 binned mode (2736x1824)
   515			 */
   516			.scan = &imx283_scan_modes[IMX283_MODE_2],
   517			.width = 2736,
   518			.height = 1824,
   519			.min_hmax = 2414, /* Pixels (362 * 480MHz/72MHz + padding) */
   520			.min_vmax = 3840, /* Lines */
   521	
   522			/* 50.00 FPS */
   523			.default_hmax = 2500, /* 375 @ 480MHz/72Mhz */
   524			.default_vmax = 3840,
   525	
   526			.hbin_ratio = 2,
   527			.vbin_ratio = 2,
   528	
   529			.min_shr = 12,
   530	
   531			.crop = imx283_recommended_area,
   532		},
   533		{
   534			/*
   535			 * Readout mode 3 : 3/3 binned mode (1824x1216)
   536			 */
   537			.scan = &imx283_scan_modes[IMX283_MODE_3],
   538			.width = 1824,
   539			.height = 1216,
   540			.min_hmax = 1894, /* Pixels (284 * 480MHz/72MHz + padding) */
   541			.min_vmax = 4200, /* Lines */
   542	
   543			/* 60.00 fps */
   544			.default_hmax = 1900, /* 285 @ 480MHz/72Mhz */
   545			.default_vmax = 4200,
   546	
   547			.hbin_ratio = 3,
   548			.vbin_ratio = 3,
   549	
   550			.min_shr = 16,
   551	
   552			.crop = imx283_recommended_area,
   553		},
   554	};
   555	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki