Re: [PATCH v2] rtl_pci: add support for Realtek management device

[kernel test robot <lkp@intel.com>]

Hi javen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus soc/for-next linus/master v7.0-rc2 next-20260304]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/javen/rtl_pci-add-support-for-Realtek-management-device/20260303-142108
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20260303061841.1431-1-javen_xu%40realsil.com.cn
patch subject: [PATCH v2] rtl_pci: add support for Realtek management device
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260306/202603061745.9efKfvTe-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603061745.9efKfvTe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603061745.9efKfvTe-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/misc/rtl_pci.c:27:69: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
      27 |         { PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_PCIBR), .class_mask = 0xff00 },
         |                                                                            ^~~~~~
   drivers/misc/rtl_pci.c:27:4: note: previous initialization is here
      27 |         { PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_PCIBR), .class_mask = 0xff00 },
         |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/pci.h:1123:55: note: expanded from macro 'PCI_VDEVICE'
    1123 |         .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, 0, 0
         |                                                              ^
>> drivers/misc/rtl_pci.c:60:32: warning: unused variable 'rtl_pm_ops' [-Wunused-const-variable]
      60 | static const struct dev_pm_ops rtl_pm_ops = {
         |                                ^~~~~~~~~~
   2 warnings generated.


vim +/rtl_pm_ops +60 drivers/misc/rtl_pci.c

    20	
    21	static struct pci_device_id rtl_pci_tbl[] = {
    22		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_PTOU), },
    23		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_COM1), },
    24		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_COM2), },
    25		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_IPMI), },
    26		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_BMC), },
  > 27		{ PCI_VDEVICE(REALTEK, PCI_DEVICE_ID_REALTEK_PCIBR), .class_mask = 0xff00 },
    28		{ }
    29	};
    30	
    31	MODULE_DEVICE_TABLE(pci, rtl_pci_tbl);
    32	
    33	static int rtl_probe(struct pci_dev *pdev,
    34				 const struct pci_device_id *ent)
    35	{
    36		int rc;
    37	
    38		/* enable device (incl. PCI PM wakeup and hotplug setup) */
    39		rc = pcim_enable_device(pdev);
    40		if (rc < 0)
    41			return dev_err_probe(&pdev->dev, rc, "enable failure\n");
    42	
    43		dev_info(&pdev->dev, "enable device\n");
    44	
    45		return rc;
    46	}
    47	
    48	static void rtl_remove(struct pci_dev *pdev) {}
    49	
    50	static int rtl_pm_suspend(struct device *device)
    51	{
    52		return 0;
    53	}
    54	
    55	static int rtl_pm_resume(struct device *device)
    56	{
    57		return 0;
    58	}
    59	
  > 60	static const struct dev_pm_ops rtl_pm_ops = {
    61		SYSTEM_SLEEP_PM_OPS(rtl_pm_suspend, rtl_pm_resume)
    62	};
    63	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki