* [dhowells-fs:netfs-next 25/25] fs/ceph/addr.c:312:37: error: too many arguments to function call, expected single argument 'subreq', have 2 arguments
@ 2026-03-16 12:01 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-03-16 12:01 UTC (permalink / raw)
To: David Howells; +Cc: llvm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-next
head: 1aea2bfdfc039b008ff97eec23c755b5ac4b25a4
commit: 1aea2bfdfc039b008ff97eec23c755b5ac4b25a4 [25/25] netfs: Combine prepare and issue ops and grab the buffers on request
config: x86_64-randconfig-015-20260316 (https://download.01.org/0day-ci/archive/20260316/202603161930.JduIXD0e-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260316/202603161930.JduIXD0e-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603161930.JduIXD0e-lkp@intel.com/
All errors (new ones prefixed by >>):
fs/ceph/addr.c:273:18: warning: declaration of 'struct netfs_read_context' will not be visible outside of this function [-Wvisibility]
273 | struct netfs_read_context *rctx)
| ^
fs/ceph/addr.c:297:8: error: call to undeclared function 'netfs_subreq_get_buffer'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
297 | err = netfs_subreq_get_buffer(subreq, rctx, UINT_MAX);
| ^
>> fs/ceph/addr.c:312:37: error: too many arguments to function call, expected single argument 'subreq', have 2 arguments
312 | netfs_mark_read_submission(subreq, rctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
include/linux/netfs.h:456:6: note: 'netfs_mark_read_submission' declared here
456 | void netfs_mark_read_submission(struct netfs_io_subrequest *subreq);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ceph/addr.c:327:71: error: no member named 'io_iter' in 'struct netfs_io_subrequest'
327 | err = copy_to_iter(iinfo->inline_data + subreq->start, len, &subreq->io_iter);
| ~~~~~~ ^
fs/ceph/addr.c:344:13: warning: declaration of 'struct netfs_read_context' will not be visible outside of this function [-Wvisibility]
344 | struct netfs_read_context *rctx)
| ^
>> fs/ceph/addr.c:363:44: error: incompatible pointer types passing 'struct netfs_read_context *' to parameter of type 'struct netfs_read_context *' [-Werror,-Wincompatible-pointer-types]
363 | err = ceph_netfs_issue_op_inline(subreq, rctx);
| ^~~~
fs/ceph/addr.c:273:38: note: passing argument to parameter 'rctx' here
273 | struct netfs_read_context *rctx)
| ^
fs/ceph/addr.c:401:8: error: call to undeclared function 'netfs_subreq_get_buffer'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
401 | err = netfs_subreq_get_buffer(subreq, rctx, UINT_MAX);
| ^
fs/ceph/addr.c:425:11: error: no member named 'io_iter' in 'struct netfs_io_subrequest'
425 | subreq->io_iter.count = len;
| ~~~~~~ ^
fs/ceph/addr.c:427:44: error: no member named 'io_iter' in 'struct netfs_io_subrequest'
427 | err = iov_iter_get_pages_alloc2(&subreq->io_iter, &pages, len, &page_off);
| ~~~~~~ ^
fs/ceph/addr.c:443:47: error: no member named 'io_iter' in 'struct netfs_io_subrequest'
443 | osd_req_op_extent_osd_iter(req, 0, &subreq->io_iter);
| ~~~~~~ ^
fs/ceph/addr.c:455:37: error: too many arguments to function call, expected single argument 'subreq', have 2 arguments
455 | netfs_mark_read_submission(subreq, rctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
include/linux/netfs.h:456:6: note: 'netfs_mark_read_submission' declared here
456 | void netfs_mark_read_submission(struct netfs_io_subrequest *subreq);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ceph/addr.c:472:12: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
472 | __set_bit(NETFS_RREQ_USE_PGPRIV2, &rreq->flags);
| ^
fs/ceph/addr.c:472:12: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
fs/ceph/addr.c:472:12: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
fs/ceph/addr.c:517:22: error: no member named 'sreq_max_len' in 'struct netfs_io_stream'
517 | rreq->io_streams[0].sreq_max_len = fsc->mount_options->rsize;
| ~~~~~~~~~~~~~~~~~~~ ^
>> fs/ceph/addr.c:545:17: error: incompatible function pointer types initializing 'int (*)(struct netfs_io_subrequest *)' with an expression of type 'int (struct netfs_io_subrequest *, struct netfs_read_context *)' [-Wincompatible-function-pointer-types]
545 | .issue_read = ceph_netfs_issue_read,
| ^~~~~~~~~~~~~~~~~~~~~
2 warnings and 14 errors generated.
vim +/subreq +312 fs/ceph/addr.c
271
272 static int ceph_netfs_issue_op_inline(struct netfs_io_subrequest *subreq,
273 struct netfs_read_context *rctx)
274 {
275 struct netfs_io_request *rreq = subreq->rreq;
276 struct inode *inode = rreq->inode;
277 struct ceph_mds_reply_info_parsed *rinfo;
278 struct ceph_mds_reply_info_in *iinfo;
279 struct ceph_mds_request *req;
280 struct ceph_mds_client *mdsc = ceph_sb_to_mdsc(inode->i_sb);
281 struct ceph_inode_info *ci = ceph_inode(inode);
282 ssize_t err;
283 size_t len;
284 int mode;
285
286 if (rreq->origin != NETFS_UNBUFFERED_READ &&
287 rreq->origin != NETFS_DIO_READ)
288 __set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags);
289 __clear_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags);
290
291 if (subreq->start >= inode->i_size) {
292 __set_bit(NETFS_SREQ_HIT_EOF, &subreq->flags);
293 err = 0;
294 goto out;
295 }
296
297 err = netfs_subreq_get_buffer(subreq, rctx, UINT_MAX);
298 if (err < 0)
299 return err;
300
301 /* We need to fetch the inline data. */
302 mode = ceph_try_to_choose_auth_mds(inode, CEPH_STAT_CAP_INLINE_DATA);
303 req = ceph_mdsc_create_request(mdsc, CEPH_MDS_OP_GETATTR, mode);
304 if (IS_ERR(req))
305 return PTR_ERR(req);
306
307 req->r_ino1 = ci->i_vino;
308 req->r_args.getattr.mask = cpu_to_le32(CEPH_STAT_CAP_INLINE_DATA);
309 req->r_num_caps = 2;
310
311 /* After this point, we're not allowed to return an error. */
> 312 netfs_mark_read_submission(subreq, rctx);
313
314 err = ceph_mdsc_do_request(mdsc, NULL, req);
315 if (err < 0)
316 goto out;
317
318 rinfo = &req->r_reply_info;
319 iinfo = &rinfo->targeti;
320 if (iinfo->inline_version == CEPH_INLINE_NONE) {
321 /* The data got uninlined */
322 ceph_mdsc_put_request(req);
323 return 1;
324 }
325
326 len = min_t(size_t, iinfo->inline_len - subreq->start, subreq->len);
327 err = copy_to_iter(iinfo->inline_data + subreq->start, len, &subreq->io_iter);
328 if (err == 0) {
329 err = -EFAULT;
330 } else {
331 subreq->transferred += err;
332 err = 0;
333 }
334
335 ceph_mdsc_put_request(req);
336 out:
337 subreq->error = err;
338 trace_netfs_sreq(subreq, netfs_sreq_trace_io_progress);
339 netfs_read_subreq_terminated(subreq);
340 return -EIOCBQUEUED;
341 }
342
343 static int ceph_netfs_issue_read(struct netfs_io_subrequest *subreq,
344 struct netfs_read_context *rctx)
345 {
346 struct netfs_io_request *rreq = subreq->rreq;
347 struct inode *inode = rreq->inode;
348 struct ceph_inode_info *ci = ceph_inode(inode);
349 struct ceph_fs_client *fsc = ceph_inode_to_fs_client(inode);
350 struct ceph_client *cl = fsc->client;
351 struct ceph_osd_request *req = NULL;
352 struct ceph_vino vino = ceph_vino(inode);
353 u64 objno, objoff, len, off = subreq->start;
354 u32 maxlen;
355 int err;
356 bool sparse = IS_ENCRYPTED(inode) || ceph_test_mount_opt(fsc, SPARSEREAD);
357 int extent_cnt;
358
359 if (ceph_inode_is_shutdown(inode))
360 return -EIO;
361
362 if (ceph_has_inline_data(ci)) {
> 363 err = ceph_netfs_issue_op_inline(subreq, rctx);
364 if (err != 1)
365 return err;
366 }
367
368 /* Truncate the extent at the end of the current block */
369 ceph_calc_file_object_mapping(&ci->i_layout, subreq->start, subreq->len,
370 &objno, &objoff, &maxlen);
371 maxlen = umin(maxlen, fsc->mount_options->rsize);
372 len = umin(subreq->len, maxlen);
373 subreq->len = len;
374
375 // TODO: This rounding here is slightly dodgy. It *should* work, for
376 // now, as the cache only deals in blocks that are a multiple of
377 // PAGE_SIZE and fscrypt blocks are at most PAGE_SIZE. What needs to
378 // happen is for the fscrypt driving to be moved into netfslib and the
379 // data in the cache also to be stored encrypted.
380 ceph_fscrypt_adjust_off_and_len(inode, &off, &len);
381
382 req = ceph_osdc_new_request(&fsc->client->osdc, &ci->i_layout, vino,
383 off, &len, 0, 1, sparse ? CEPH_OSD_OP_SPARSE_READ : CEPH_OSD_OP_READ,
384 CEPH_OSD_FLAG_READ, NULL, ci->i_truncate_seq,
385 ci->i_truncate_size, false);
386 if (IS_ERR(req))
387 return PTR_ERR(req);
388
389 if (sparse) {
390 extent_cnt = __ceph_sparse_read_ext_count(inode, len);
391 err = ceph_alloc_sparse_ext_map(&req->r_ops[0], extent_cnt);
392 if (err) {
393 ceph_osdc_put_request(req);
394 return err;
395 }
396 }
397
398 doutc(cl, "%llx.%llx pos=%llu orig_len=%zu len=%llu\n",
399 ceph_vinop(inode), subreq->start, subreq->len, len);
400
401 err = netfs_subreq_get_buffer(subreq, rctx, UINT_MAX);
402 if (err < 0) {
403 ceph_osdc_put_request(req);
404 return err;
405 }
406
407 /*
408 * FIXME: For now, use CEPH_OSD_DATA_TYPE_PAGES instead of _ITER for
409 * encrypted inodes. We'd need infrastructure that handles an iov_iter
410 * instead of page arrays, and we don't have that as of yet. Once the
411 * dust settles on the write helpers and encrypt/decrypt routines for
412 * netfs, we should be able to rework this.
413 */
414 if (IS_ENCRYPTED(inode)) {
415 struct page **pages;
416 size_t page_off;
417
418 /*
419 * FIXME: io_iter.count needs to be corrected to aligned
420 * length. Otherwise, iov_iter_get_pages_alloc2() operates
421 * with the initial unaligned length value. As a result,
422 * ceph_msg_data_cursor_init() triggers BUG_ON() in the case
423 * if msg->sparse_read_total > msg->data_length.
424 */
425 subreq->io_iter.count = len;
426
427 err = iov_iter_get_pages_alloc2(&subreq->io_iter, &pages, len, &page_off);
428 if (err < 0) {
429 doutc(cl, "%llx.%llx failed to allocate pages, %d\n",
430 ceph_vinop(inode), err);
431 ceph_osdc_put_request(req);
432 return -EIO;
433 }
434
435 /* should always give us a page-aligned read */
436 WARN_ON_ONCE(page_off);
437 len = err;
438 err = 0;
439
440 osd_req_op_extent_osd_data_pages(req, 0, pages, len, 0, false,
441 false);
442 } else {
443 osd_req_op_extent_osd_iter(req, 0, &subreq->io_iter);
444 }
445 if (!ceph_inc_osd_stopping_blocker(fsc->mdsc)) {
446 ceph_osdc_put_request(req);
447 return -EIO;
448 }
449 req->r_callback = finish_netfs_read;
450 req->r_priv = subreq;
451 req->r_inode = inode;
452 ihold(inode);
453
454 /* After this point, we're not allowed to return an error. */
455 netfs_mark_read_submission(subreq, rctx);
456 ceph_osdc_start_request(req->r_osdc, req);
457 ceph_osdc_put_request(req);
458 doutc(cl, "%llx.%llx result -EIOCBQUEUED\n", ceph_vinop(inode));
459 return -EIOCBQUEUED;
460 }
461
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-03-16 12:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16 12:01 [dhowells-fs:netfs-next 25/25] fs/ceph/addr.c:312:37: error: too many arguments to function call, expected single argument 'subreq', have 2 arguments kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox