Re: [PATCH v2] platform/x86: asus-wmi: log thermal notification event

Re: [PATCH v2] platform/x86: asus-wmi: log thermal notification event

[kernel test robot]

Hi Jonathan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v7.0-rc4 next-20260316]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jonathan-Grant/platform-x86-asus-wmi-log-thermal-notification-event/20260316-204950
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/94dbe1e1-d706-47aa-abf5-f5d76aacf017%40jguk.org
patch subject: [PATCH v2] platform/x86: asus-wmi: log thermal notification event
config: i386-randconfig-014-20260317 (https://download.01.org/0day-ci/archive/20260318/202603180137.ePqnMidQ-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603180137.ePqnMidQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603180137.ePqnMidQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/asus-wmi.c:4603:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
    4603 |                 else
         |                 ^
   1 warning generated.


vim +4603 drivers/platform/x86/asus-wmi.c

  4538	
  4539	static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
  4540	{
  4541		enum led_brightness led_value;
  4542		unsigned int key_value = 1;
  4543		bool autorelease = 1;
  4544	
  4545		if (asus->driver->key_filter) {
  4546			asus->driver->key_filter(asus->driver, &code, &key_value,
  4547						 &autorelease);
  4548			if (code == ASUS_WMI_KEY_IGNORE)
  4549				return;
  4550		}
  4551	
  4552		if (acpi_video_get_backlight_type() == acpi_backlight_vendor &&
  4553		    code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNDOWN_MAX) {
  4554			asus_wmi_backlight_notify(asus, code);
  4555			return;
  4556		}
  4557	
  4558		scoped_guard(spinlock_irqsave, &asus_ref.lock)
  4559			led_value = asus->kbd_led_wk;
  4560	
  4561		if (code == NOTIFY_KBD_BRTUP) {
  4562			kbd_led_set_by_kbd(asus, led_value + 1);
  4563			return;
  4564		}
  4565		if (code == NOTIFY_KBD_BRTDWN) {
  4566			kbd_led_set_by_kbd(asus, led_value - 1);
  4567			return;
  4568		}
  4569		if (code == NOTIFY_KBD_BRTTOGGLE) {
  4570			if (led_value >= ASUS_EV_MAX_BRIGHTNESS)
  4571				kbd_led_set_by_kbd(asus, 0);
  4572			else
  4573				kbd_led_set_by_kbd(asus, led_value + 1);
  4574			return;
  4575		}
  4576	
  4577		if (code == NOTIFY_FNLOCK_TOGGLE) {
  4578			asus->fnlock_locked = !asus->fnlock_locked;
  4579			asus_wmi_fnlock_update(asus);
  4580			return;
  4581		}
  4582	
  4583		if (code == asus->tablet_switch_event_code) {
  4584			asus_wmi_tablet_mode_get_state(asus);
  4585			return;
  4586		}
  4587	
  4588		if (code == NOTIFY_KBD_FBM || code == NOTIFY_KBD_TTP) {
  4589			if (asus->fan_boost_mode_available)
  4590				fan_boost_mode_switch_next(asus);
  4591			if (asus->throttle_thermal_policy_dev)
  4592				platform_profile_cycle();
  4593			return;
  4594		}
  4595	
  4596		if (is_display_toggle(code) && asus->driver->quirks->no_display_toggle)
  4597			return;
  4598	
  4599		if (!sparse_keymap_report_event(asus->inputdev, code,
  4600						key_value, autorelease))
  4601			if (code == NOTIFY_THERMAL)
  4602				pr_info("Thermal state change\n");
> 4603			else
  4604				pr_info("Unknown key code 0x%x\n", code);
  4605	}
  4606	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki